From 03e7b1ca9f56ef7da0b8d199a1f2e8bacc75ab05 Mon Sep 17 00:00:00 2001 From: Wenhao-H Date: Wed, 6 Jun 2018 21:37:27 +0800 Subject: [PATCH] change totalError to rmse --- src/mlpack/tests/cf_test.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/mlpack/tests/cf_test.cpp b/src/mlpack/tests/cf_test.cpp index 74e0b70583..ac5270f30a 100644 --- a/src/mlpack/tests/cf_test.cpp +++ b/src/mlpack/tests/cf_test.cpp @@ -296,10 +296,10 @@ void CFPredict(bool cleanData = true) totalError += error; } - totalError = std::sqrt(totalError) / savedCols.n_cols; + const double rmse = std::sqrt(totalError / savedCols.n_cols); - // The mean squared error should be less than one. - BOOST_REQUIRE_LT(totalError, 0.6); + // The root mean square error should be less than ?. + BOOST_REQUIRE_LT(rmse, 4.3); } // Do the same thing as the previous test, but ensure that the ratings we