From 686c4041c584c1002860d18ff9672d0e12176198 Mon Sep 17 00:00:00 2001 From: Marcus Edel Date: Tue, 6 Oct 2020 01:42:11 +0200 Subject: [PATCH 1/8] Build against the latest version of macOS. --- .ci/ci.yaml | 2 +- .ci/macos-steps.yaml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.ci/ci.yaml b/.ci/ci.yaml index 89adaec398..687a2e1b4f 100644 --- a/.ci/ci.yaml +++ b/.ci/ci.yaml @@ -40,7 +40,7 @@ jobs: - job: macOS timeoutInMinutes: 360 pool: - vmImage: macOS-10.14 + vmImage: macOS-latest strategy: matrix: Plain: diff --git a/.ci/macos-steps.yaml b/.ci/macos-steps.yaml index 09ee11f538..6fc5f64b17 100644 --- a/.ci/macos-steps.yaml +++ b/.ci/macos-steps.yaml @@ -12,7 +12,7 @@ steps: # Install Build Dependencies - script: | set -e - sudo xcode-select --switch /Applications/Xcode_10.1.app/Contents/Developer + sudo xcode-select --switch /Applications/Xcode_11.app/Contents/Developer unset BOOST_ROOT brew install openblas armadillo boost From 6bf725e04bb278ae153adb60fcde6c1cc90710ce Mon Sep 17 00:00:00 2001 From: Marcus Edel Date: Tue, 6 Oct 2020 13:47:45 +0200 Subject: [PATCH 2/8] Let's see if this is a RegSVD issue. --- src/mlpack/tests/cf_test.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mlpack/tests/cf_test.cpp b/src/mlpack/tests/cf_test.cpp index c114268e75..25677c03fe 100644 --- a/src/mlpack/tests/cf_test.cpp +++ b/src/mlpack/tests/cf_test.cpp @@ -522,7 +522,7 @@ BOOST_AUTO_TEST_CASE(CFGetRecommendationsAllUsersRandSVDTest) */ BOOST_AUTO_TEST_CASE(CFGetRecommendationsAllUsersRegSVDTest) { - GetRecommendationsAllUsers(); + //GetRecommendationsAllUsers(); } /** From 0d715d5027557ec6b1794dd6104ecb91d91219d9 Mon Sep 17 00:00:00 2001 From: Marcus Edel Date: Tue, 6 Oct 2020 19:58:11 +0200 Subject: [PATCH 3/8] Let's see if this is a BatchSVD issue. --- src/mlpack/tests/cf_test.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mlpack/tests/cf_test.cpp b/src/mlpack/tests/cf_test.cpp index 25677c03fe..e32dfee657 100644 --- a/src/mlpack/tests/cf_test.cpp +++ b/src/mlpack/tests/cf_test.cpp @@ -532,7 +532,7 @@ BOOST_AUTO_TEST_CASE(CFGetRecommendationsAllUsersRegSVDTest) BOOST_AUTO_TEST_CASE(CFGetRecommendationsAllUsersBatchSVDTest) { - GetRecommendationsAllUsers(); + //GetRecommendationsAllUsers(); } /** From d25c8031e87029a6a17b0d38e23a2cda9a9c3eac Mon Sep 17 00:00:00 2001 From: Marcus Edel Date: Fri, 9 Oct 2020 17:56:15 +0200 Subject: [PATCH 4/8] Use latest XCode. --- .ci/macos-steps.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.ci/macos-steps.yaml b/.ci/macos-steps.yaml index 6fc5f64b17..16bd4d289d 100644 --- a/.ci/macos-steps.yaml +++ b/.ci/macos-steps.yaml @@ -12,7 +12,7 @@ steps: # Install Build Dependencies - script: | set -e - sudo xcode-select --switch /Applications/Xcode_11.app/Contents/Developer + sudo xcode-select --switch /Applications/Xcode_12.app/Contents/Developer unset BOOST_ROOT brew install openblas armadillo boost From 807dfacce8f5c05a278967c1a95cf5776690f42f Mon Sep 17 00:00:00 2001 From: Marcus Edel Date: Sat, 10 Oct 2020 21:27:52 +0200 Subject: [PATCH 5/8] Update XCode. --- .ci/macos-steps.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.ci/macos-steps.yaml b/.ci/macos-steps.yaml index 16bd4d289d..993f819cfd 100644 --- a/.ci/macos-steps.yaml +++ b/.ci/macos-steps.yaml @@ -12,7 +12,7 @@ steps: # Install Build Dependencies - script: | set -e - sudo xcode-select --switch /Applications/Xcode_12.app/Contents/Developer + sudo xcode-select --switch /Applications/Xcode_12.2.app/Contents/Developer unset BOOST_ROOT brew install openblas armadillo boost From 90a5573c60ed1e355c33d0a2a4257901ca86e4cb Mon Sep 17 00:00:00 2001 From: Marcus Edel Date: Sun, 11 Oct 2020 18:35:39 +0200 Subject: [PATCH 6/8] Build with debug symbols. --- .ci/ci.yaml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.ci/ci.yaml b/.ci/ci.yaml index 687a2e1b4f..3b4e181e08 100644 --- a/.ci/ci.yaml +++ b/.ci/ci.yaml @@ -49,21 +49,21 @@ jobs: Python: binding: 'python' python.version: '3.7' - CMakeArgs: '-DDEBUG=OFF -DPROFILE=OFF -DBUILD_PYTHON_BINDINGS=ON -DBUILD_JULIA_BINDINGS=OFF -DBUILD_GO_BINDINGS=OFF -DBUILD_R_BINDINGS=OFF' + CMakeArgs: '-DDEBUG=ON -DPROFILE=OFF -DBUILD_PYTHON_BINDINGS=ON -DBUILD_JULIA_BINDINGS=OFF -DBUILD_GO_BINDINGS=OFF -DBUILD_R_BINDINGS=OFF' Julia: python.version: '2.7' julia.version: '1.3.0' - CMakeArgs: '-DDEBUG=OFF -DPROFILE=OFF -DBUILD_JULIA_BINDINGS=ON -DBUILD_PYTHON_BINDINGS=OFF -DBUILD_GO_BINDINGS=OFF -DBUILD_R_BINDINGS=OFF' + CMakeArgs: '-DDEBUG=ON -DPROFILE=OFF -DBUILD_JULIA_BINDINGS=ON -DBUILD_PYTHON_BINDINGS=OFF -DBUILD_GO_BINDINGS=OFF -DBUILD_R_BINDINGS=OFF' Go: binding: 'go' python.version: '2.7' go.version: '1.11.0' - CMakeArgs: '-DDEBUG=OFF -DPROFILE=OFF -DBUILD_PYTHON_BINDINGS=OFF -DBUILD_JULIA_BINDINGS=OFF -DBUILD_GO_BINDINGS=ON -DBUILD_R_BINDINGS=OFF' + CMakeArgs: '-DDEBUG=ON -DPROFILE=OFF -DBUILD_PYTHON_BINDINGS=OFF -DBUILD_JULIA_BINDINGS=OFF -DBUILD_GO_BINDINGS=ON -DBUILD_R_BINDINGS=OFF' R: binding: 'R' python.version: '2.7' R.version: '4.0.0' - CMakeArgs: '-DDEBUG=OFF -DPROFILE=OFF -DBUILD_PYTHON_BINDINGS=OFF -DBUILD_JULIA_BINDINGS=OFF -DBUILD_GO_BINDINGS=OFF -DBUILD_R_BINDINGS=ON' + CMakeArgs: '-DDEBUG=ON -DPROFILE=OFF -DBUILD_PYTHON_BINDINGS=OFF -DBUILD_JULIA_BINDINGS=OFF -DBUILD_GO_BINDINGS=OFF -DBUILD_R_BINDINGS=ON' steps: - template: macos-steps.yaml From c991f3b8ea299b1352798cd1f10456c8658ebaa8 Mon Sep 17 00:00:00 2001 From: Marcus Edel Date: Sun, 11 Oct 2020 22:29:19 +0200 Subject: [PATCH 7/8] Build Go bindings with DEBUG=ON. --- .ci/ci.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.ci/ci.yaml b/.ci/ci.yaml index f614220dbf..92753206c8 100644 --- a/.ci/ci.yaml +++ b/.ci/ci.yaml @@ -54,7 +54,7 @@ jobs: binding: 'go' python.version: '2.7' go.version: '1.11.0' - CMakeArgs: '-DDEBUG=OFF -DPROFILE=OFF -DBUILD_PYTHON_BINDINGS=OFF -DBUILD_JULIA_BINDINGS=OFF -DBUILD_GO_BINDINGS=ON -DBUILD_R_BINDINGS=OFF' + CMakeArgs: '-DDEBUG=ON -DPROFILE=OFF -DBUILD_PYTHON_BINDINGS=OFF -DBUILD_JULIA_BINDINGS=OFF -DBUILD_GO_BINDINGS=ON -DBUILD_R_BINDINGS=OFF' steps: - template: macos-steps.yaml From e5e0d35e368d74746cc0b7aeb50f845151f8a41b Mon Sep 17 00:00:00 2001 From: Marcus Edel Date: Mon, 12 Oct 2020 21:01:56 +0200 Subject: [PATCH 8/8] Reinclude tests (debugging). --- src/mlpack/tests/cf_test.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mlpack/tests/cf_test.cpp b/src/mlpack/tests/cf_test.cpp index e32dfee657..c114268e75 100644 --- a/src/mlpack/tests/cf_test.cpp +++ b/src/mlpack/tests/cf_test.cpp @@ -522,7 +522,7 @@ BOOST_AUTO_TEST_CASE(CFGetRecommendationsAllUsersRandSVDTest) */ BOOST_AUTO_TEST_CASE(CFGetRecommendationsAllUsersRegSVDTest) { - //GetRecommendationsAllUsers(); + GetRecommendationsAllUsers(); } /** @@ -532,7 +532,7 @@ BOOST_AUTO_TEST_CASE(CFGetRecommendationsAllUsersRegSVDTest) BOOST_AUTO_TEST_CASE(CFGetRecommendationsAllUsersBatchSVDTest) { - //GetRecommendationsAllUsers(); + GetRecommendationsAllUsers(); } /**