From 3db79052c14e155ea74a66c2b25c8ef68a5b80df Mon Sep 17 00:00:00 2001 From: Konstantin Sidorov Date: Tue, 25 Jul 2017 16:29:57 +0300 Subject: [PATCH] Fixing issues from @zoq's review --- src/mlpack/core/optimizers/sgd/sgd.hpp | 2 +- src/mlpack/methods/ann/layer/cross_entropy_error_impl.hpp | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/mlpack/core/optimizers/sgd/sgd.hpp b/src/mlpack/core/optimizers/sgd/sgd.hpp index 17e909ec05..c21517861a 100644 --- a/src/mlpack/core/optimizers/sgd/sgd.hpp +++ b/src/mlpack/core/optimizers/sgd/sgd.hpp @@ -146,7 +146,7 @@ class SGD bool& ResetPolicy() { return resetPolicy; } //! Get the update policy. - UpdatePolicyType UpdatePolicy() const { return updatePolicy; } + const UpdatePolicyType& UpdatePolicy() const { return updatePolicy; } //! Modify the update policy. UpdatePolicyType& UpdatePolicy() { return updatePolicy; } diff --git a/src/mlpack/methods/ann/layer/cross_entropy_error_impl.hpp b/src/mlpack/methods/ann/layer/cross_entropy_error_impl.hpp index f9ce79f738..1aa4b754e6 100644 --- a/src/mlpack/methods/ann/layer/cross_entropy_error_impl.hpp +++ b/src/mlpack/methods/ann/layer/cross_entropy_error_impl.hpp @@ -47,10 +47,10 @@ void CrossEntropyError::Backward( template template void CrossEntropyError::Serialize( - Archive& /* ar */, + Archive& ar, const unsigned int /* version */) { - // Nothing to do here. + ar & data::CreateNVP(eps, "eps"); } } // namespace ann