From b0961500db11c0534dfc45cd22464e30959ac791 Mon Sep 17 00:00:00 2001 From: Ryan Curtin Date: Sun, 22 May 2022 21:44:31 -0400 Subject: [PATCH 1/2] Properly initialize the gradient matrix. --- src/mlpack/tests/convolutional_network_test.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mlpack/tests/convolutional_network_test.cpp b/src/mlpack/tests/convolutional_network_test.cpp index 91994e6b8c..3d1bf0acbf 100644 --- a/src/mlpack/tests/convolutional_network_test.cpp +++ b/src/mlpack/tests/convolutional_network_test.cpp @@ -320,7 +320,7 @@ TEST_CASE("VanillaNetworkBatchSizeTest", "[ConvolutionalNetworkTest]") // Now compute results with a batch size of 1. arma::mat singleResults(results.n_rows, results.n_cols); - arma::mat singleGradient(gradient.n_rows, gradient.n_cols); + arma::mat singleGradient(gradient.n_rows, gradient.n_cols, arma::fill::zeros); double singleObj = 0.0; for (size_t i = 0; i < batchSize; ++i) From 1fe6452d13c77a7f45b3c5d3cab1277bc72b9169 Mon Sep 17 00:00:00 2001 From: Ryan Curtin Date: Tue, 24 May 2022 18:11:40 -0400 Subject: [PATCH 2/2] Remove accidental debugging output. --- src/mlpack/tests/convolutional_network_test.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mlpack/tests/convolutional_network_test.cpp b/src/mlpack/tests/convolutional_network_test.cpp index 3d1bf0acbf..e1263044c3 100644 --- a/src/mlpack/tests/convolutional_network_test.cpp +++ b/src/mlpack/tests/convolutional_network_test.cpp @@ -224,7 +224,7 @@ TEST_CASE("VanillaNetworkTest", "[ConvolutionalNetworkTest]") // Train for only 8 epochs. ens::RMSProp opt(0.001, 1, 0.88, 1e-8, 8 * nPoints, -1); - double objVal = model.Train(X, Y, opt, ens::PrintLoss()); + double objVal = model.Train(X, Y, opt); // Test that objective value returned by FFN::Train() is finite. REQUIRE(std::isfinite(objVal) == true);