From 6d280d2d1d8a36c005c2152cb0ac0aafcb116a5e Mon Sep 17 00:00:00 2001 From: Yashwant Singh Parihar Date: Tue, 3 Nov 2020 14:09:24 +0530 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Marcus Edel --- .github/workflows/update-catch.yaml | 10 +++++----- .github/workflows/update-cli11.yaml | 8 ++++---- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/.github/workflows/update-catch.yaml b/.github/workflows/update-catch.yaml index 6ae6be1b75..af133ac853 100644 --- a/.github/workflows/update-catch.yaml +++ b/.github/workflows/update-catch.yaml @@ -11,17 +11,17 @@ jobs: - name: Get Latest Catch Tagged Release id: catch-header run: | - # Ping version information upstream + # Ping version information upstream. CATCH_RELEASE_JSON=$(curl -sL https://api.github.com/repos/catchorg/Catch2/releases/latest) CATCH_RELEASE_VERSION=$(jq -r ".tag_name" <<< "$CATCH_RELEASE_JSON" | tr -d v) echo ::set-output name=release_tag::$(echo $CATCH_RELEASE_VERSION) - # Extract out version information from git repository + # Extract out version information from git repository. CATCH_VERSION_MAJOR=$(grep -i ".*#define CATCH_VERSION_MAJOR.*" src/mlpack/tests/catch.hpp | grep -o "[0-9]*") CATCH_VERSION_MINOR=$(grep -i ".*#define CATCH_VERSION_MINOR.*" src/mlpack/tests/catch.hpp | grep -o "[0-9]*") CATCH_VERSION_PATCH=$(grep -i ".*#define CATCH_VERSION_PATCH.*" src/mlpack/tests/catch.hpp | grep -o "[0-9]*") - # Combine values to match release tag information + # Combine values to match release tag information. CATCH_VERSION_VALUE=${CATCH_VERSION_MAJOR}.${CATCH_VERSION_MINOR}.${CATCH_VERSION_PATCH} - # Set the current release tag + # Set the current release tag. echo ::set-output name=current_tag::$(echo $CATCH_VERSION_VALUE) - name: Update Catch @@ -32,7 +32,7 @@ jobs: run: | # Delete the catch.hpp. rm -f src/mlpack/tests/catch.hpp - # Download the release + # Download the release. curl -sL https://github.com/catchorg/Catch2/releases/latest/download/catch.hpp -o src/mlpack/tests/catch.hpp - name: Create Pull Request For Catch diff --git a/.github/workflows/update-cli11.yaml b/.github/workflows/update-cli11.yaml index 571d7b0e8c..6bca961098 100644 --- a/.github/workflows/update-cli11.yaml +++ b/.github/workflows/update-cli11.yaml @@ -11,13 +11,13 @@ jobs: - name: Get Latest CLI11 Tagged Release id: cli11-header run: | - # Ping version information upstream + # Ping version information upstream. CLI11_RELEASE_JSON=$(curl -sL https://api.github.com/repos/CLIUtils/CLI11/releases/latest) CLI11_RELEASE_VERSION=$(jq -r ".tag_name" <<< "$CLI11_RELEASE_JSON" | tr -d v) echo ::set-output name=release_tag::$(echo $CLI11_RELEASE_VERSION) - # Extract out version information from git repository + # Extract out version information from git repository. CLI11_VERSION_VALUE=$(grep -i ".*#define CLI11_VERSION.*" src/mlpack/bindings/cli/third_party/CLI/CLI11.hpp | grep -Po "(\d+\.)+\d+") - # Set the current release tag + # Set the current release tag. echo ::set-output name=current_tag::$(echo $CLI11_VERSION_VALUE) - name: Update CLI11 @@ -28,7 +28,7 @@ jobs: run: | # Delete the CLI11.hpp. rm -f src/mlpack/bindings/cli/third_party/CLI/CLI11.hpp - # Download the release + # Download the release. curl -sL https://github.com/CLIUtils/CLI11/releases/latest/download/CLI11.hpp -o src/mlpack/bindings/cli/third_party/CLI/CLI11.hpp - name: Create Pull Request For CLI11