From 6d5231408bd540da559bcc16cf4a4e8fdb688a8d Mon Sep 17 00:00:00 2001
From: Martin Lambertsen <github@lambertsen.one>
Date: Tue, 15 Oct 2024 07:25:16 +0200
Subject: [PATCH] Remove includes in `_impl` header if main header contains
 include

Note that we consider the wider include to `core` as being sufficient.
---
 src/mlpack/methods/ann/ffn_impl.hpp       | 2 --
 src/mlpack/methods/det/dt_utils_impl.hpp  | 1 -
 src/mlpack/methods/det/dtree_impl.hpp     | 2 --
 src/mlpack/methods/emst/dtb_impl.hpp      | 2 --
 src/mlpack/methods/kmeans/kmeans_impl.hpp | 1 -
 5 files changed, 8 deletions(-)

diff --git a/src/mlpack/methods/ann/ffn_impl.hpp b/src/mlpack/methods/ann/ffn_impl.hpp
index a312a2625d..8e1bfdbb5f 100644
--- a/src/mlpack/methods/ann/ffn_impl.hpp
+++ b/src/mlpack/methods/ann/ffn_impl.hpp
@@ -15,8 +15,6 @@
 // In case it hasn't been included yet.
 #include "ffn.hpp"
 
-#include <mlpack/core/util/log.hpp>
-
 namespace mlpack {
 
 template<typename OutputLayerType,
diff --git a/src/mlpack/methods/det/dt_utils_impl.hpp b/src/mlpack/methods/det/dt_utils_impl.hpp
index 83efa8dd53..cf1e88c8db 100644
--- a/src/mlpack/methods/det/dt_utils_impl.hpp
+++ b/src/mlpack/methods/det/dt_utils_impl.hpp
@@ -15,7 +15,6 @@
 
 #include "dt_utils.hpp"
 #include <mlpack/core/tree/enumerate_tree.hpp>
-#include <mlpack/core/util/log.hpp>
 
 namespace mlpack {
 
diff --git a/src/mlpack/methods/det/dtree_impl.hpp b/src/mlpack/methods/det/dtree_impl.hpp
index 6be200b2a0..fe1100b178 100644
--- a/src/mlpack/methods/det/dtree_impl.hpp
+++ b/src/mlpack/methods/det/dtree_impl.hpp
@@ -15,8 +15,6 @@
 #include <stack>
 #include <vector>
 
-#include <mlpack/core/util/log.hpp>
-
 namespace mlpack {
 
 /**
diff --git a/src/mlpack/methods/emst/dtb_impl.hpp b/src/mlpack/methods/emst/dtb_impl.hpp
index 82412b7cb1..7c40c9fb30 100644
--- a/src/mlpack/methods/emst/dtb_impl.hpp
+++ b/src/mlpack/methods/emst/dtb_impl.hpp
@@ -14,8 +14,6 @@
 
 #include "dtb_rules.hpp"
 
-#include <mlpack/core/util/log.hpp>
-
 namespace mlpack {
 
 /**
diff --git a/src/mlpack/methods/kmeans/kmeans_impl.hpp b/src/mlpack/methods/kmeans/kmeans_impl.hpp
index 59af88fc03..6093b3ca7d 100644
--- a/src/mlpack/methods/kmeans/kmeans_impl.hpp
+++ b/src/mlpack/methods/kmeans/kmeans_impl.hpp
@@ -13,7 +13,6 @@
 #include "kmeans.hpp"
 
 #include <mlpack/core/distances/lmetric.hpp>
-#include <mlpack/core/util/log.hpp>
 #include <mlpack/core/util/sfinae_utility.hpp>
 #include <mlpack/core/util/size_checks.hpp>