From 83128ddfccbfd5380606eedcbaf2ec9a508ea59e Mon Sep 17 00:00:00 2001 From: Ryan Curtin Date: Wed, 20 Dec 2017 10:41:51 -0500 Subject: [PATCH] The tolerance can also be 0. --- .../methods/logistic_regression/logistic_regression_main.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mlpack/methods/logistic_regression/logistic_regression_main.cpp b/src/mlpack/methods/logistic_regression/logistic_regression_main.cpp index 8f6dc937aa..425e89504e 100644 --- a/src/mlpack/methods/logistic_regression/logistic_regression_main.cpp +++ b/src/mlpack/methods/logistic_regression/logistic_regression_main.cpp @@ -162,8 +162,8 @@ void mlpackMain() ReportIgnoredParam({{ "test", false }}, "output_probabilities"); // Tolerance needs to be positive. - RequireParamValue("tolerance", [](double x) { return x > 0.0; }, - true, "tolerance must be positive"); + RequireParamValue("tolerance", [](double x) { return x >= 0.0; }, + true, "tolerance must be positive or zero"); // Optimizer has to be L-BFGS or SGD. RequireParamInSet("optimizer", { "lbfgs", "sgd" },