From 835b4945dfc631c54ffa18afcd80da4811c7dc9f Mon Sep 17 00:00:00 2001
From: Alex Nguyen <alexvn.edu@gmail.com>
Date: Tue, 24 Nov 2020 00:01:44 -0500
Subject: [PATCH] remove unreasonable set to nullptr and other unnecessaries

---
 src/mlpack/methods/ann/layer/noisylinear_impl.hpp | 14 ++++----------
 1 file changed, 4 insertions(+), 10 deletions(-)

diff --git a/src/mlpack/methods/ann/layer/noisylinear_impl.hpp b/src/mlpack/methods/ann/layer/noisylinear_impl.hpp
index f1ae97ffd6..62e6a8c84c 100644
--- a/src/mlpack/methods/ann/layer/noisylinear_impl.hpp
+++ b/src/mlpack/methods/ann/layer/noisylinear_impl.hpp
@@ -51,13 +51,10 @@ NoisyLinear<InputDataType, OutputDataType>::NoisyLinear(
 template<typename InputDataType, typename OutputDataType>
 NoisyLinear<InputDataType, OutputDataType>::NoisyLinear(
     NoisyLinear&& layer) :
-    inSize(std::move(layer.inSize)),
-    outSize(std::move(layer.outSize)),
+    inSize(layer.inSize),
+    outSize(layer.outSize),
     weights(std::move(layer.weights))
 {
-  layer.inSize = 0;
-  layer.outSize = 0;
-  layer.weights = nullptr;
   Reset();
 }
 
@@ -81,12 +78,9 @@ NoisyLinear<InputDataType, OutputDataType>::operator=(NoisyLinear&& layer)
 {
   if (this != &layer)
   {
-    inSize = std::move(layer.inSize);
-    layer.inSize = 0;
-    outSize = std::move(layer.outSize);
-    layer.outSize = 0;
+    inSize = layer.inSize;
+    outSize = layer.outSize;
     weights = std::move(layer.weights);
-    layer.weights = nullptr;
     Reset();
   }
   return *this;