From 4c6ca23d3a90dc6320612b740ccbd59719ef3437 Mon Sep 17 00:00:00 2001 From: Ryan Curtin Date: Mon, 2 Jul 2018 09:44:11 -0400 Subject: [PATCH 1/2] Remove check that makes LCC unusable in some cases. This check would mean that the user must pass either 'initial_dictionary' or 'input_model' to any call of the program. This makes it impossible to run LCC with a random initial dictionary. --- .../local_coordinate_coding/local_coordinate_coding_main.cpp | 1 - 1 file changed, 1 deletion(-) diff --git a/src/mlpack/methods/local_coordinate_coding/local_coordinate_coding_main.cpp b/src/mlpack/methods/local_coordinate_coding/local_coordinate_coding_main.cpp index f0ee7e6dc5..e0b8c29646 100644 --- a/src/mlpack/methods/local_coordinate_coding/local_coordinate_coding_main.cpp +++ b/src/mlpack/methods/local_coordinate_coding/local_coordinate_coding_main.cpp @@ -101,7 +101,6 @@ static void mlpackMain() RandomSeed((size_t) std::time(NULL)); // Check for parameter validity. - RequireOnlyOnePassed({ "input_model", "initial_dictionary" }, true); RequireOnlyOnePassed({ "training", "input_model" }, true); if (CLI::HasParam("training")) From 8d99b258ed3d0d28f3d9abe1322f82dccb10a38f Mon Sep 17 00:00:00 2001 From: Ryan Curtin Date: Mon, 2 Jul 2018 09:45:58 -0400 Subject: [PATCH 2/2] Document the fix. --- HISTORY.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/HISTORY.md b/HISTORY.md index fc580bf68f..1b75266808 100644 --- a/HISTORY.md +++ b/HISTORY.md @@ -2,6 +2,9 @@ ###### ????-??-?? * Fix Visual Studio compilation issue (#1443). + * Allow running local_coordinate_coding binding with no initial_dictionary + parameter when input_model is not specified (#1457). + ### mlpack 3.0.2 ###### 2018-06-08 * Documentation generation fixes for Python bindings (#1421).