From 2f3916c8d7c5e4d18ef89e3c8f490c4197859ccb Mon Sep 17 00:00:00 2001 From: Adarsh Santoria <108261986+AdarshSantoria@users.noreply.github.com> Date: Mon, 6 Feb 2023 16:11:37 +0530 Subject: [PATCH 1/4] fixing codes in approx_kfn doc --- doc/tutorials/approx_kfn.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/tutorials/approx_kfn.md b/doc/tutorials/approx_kfn.md index 33a4237d98..ce422f7cbd 100644 --- a/doc/tutorials/approx_kfn.md +++ b/doc/tutorials/approx_kfn.md @@ -812,7 +812,7 @@ extern arma::mat dataset; QDAFN<> qdafn(dataset, 10, 5); // Print the fifth point of the candidate set. -std::cout << ds.CandidateSet(2).col(4).t(); +std::cout << qdafn.CandidateSet(2).col(4).t(); ``` ### Retraining on a new reference set @@ -896,7 +896,7 @@ extern arma::mat querySet; // Construct the object, performing the default dual-tree search with // approximation level epsilon = 0.05. -KFN kfn(dataset, KFN::DUAL_TREE_MODE, 0.05); +KFN kfn(dataset, DUAL_TREE_MODE, 0.05); // Search for approximate furthest neighbors. arma::Mat neighbors; From f1ed74ee94445b445814b6b62db1f37cfc1ffd12 Mon Sep 17 00:00:00 2001 From: Adarsh Santoria <108261986+AdarshSantoria@users.noreply.github.com> Date: Mon, 6 Feb 2023 21:15:31 +0530 Subject: [PATCH 2/4] improve doc --- doc/tutorials/fastmks.md | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/doc/tutorials/fastmks.md b/doc/tutorials/fastmks.md index e25fe766fd..21a0d4afb8 100644 --- a/doc/tutorials/fastmks.md +++ b/doc/tutorials/fastmks.md @@ -257,6 +257,9 @@ manually specified. Choices that mlpack provides include: - `HyperbolicTangentKernel` - `LaplacianKernel` - `PSpectrumStringKernel` + - `CauchyKernal` + - `ExampleKernal` + - `SphericalKernal` The following examples use kernels from that list. Writing your own kernel is detailed in the next section. Remember that when you are using the C++ @@ -293,7 +296,7 @@ f.Search(5, indices, products); In this setting we have both a query and reference dataset. We search for 10 maximum kernels. -``` +```c++ #include using namespace mlpack::fastmks; From 18fb167df6e18ec98ea96305ae8e1a7eb13ce50d Mon Sep 17 00:00:00 2001 From: Adarsh Santoria <108261986+AdarshSantoria@users.noreply.github.com> Date: Sat, 11 Feb 2023 22:57:27 +0530 Subject: [PATCH 3/4] Update HISTORY.md --- HISTORY.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/HISTORY.md b/HISTORY.md index 5abe54ee22..83fcf18805 100644 --- a/HISTORY.md +++ b/HISTORY.md @@ -1,5 +1,8 @@ ### mlpack ?.?.? ###### ????-??-?? + + * Fix code in tutorials (#3401). + * Bugfix for non-square convolution kernels (#3376). * Fix a few missing includes in `` (#3374). From 24c04612086f08c691b541cd9cda2186b1beba33 Mon Sep 17 00:00:00 2001 From: Adarsh Santoria <108261986+AdarshSantoria@users.noreply.github.com> Date: Sun, 12 Feb 2023 13:35:07 +0530 Subject: [PATCH 4/4] Revert Changes --- HISTORY.md | 3 --- 1 file changed, 3 deletions(-) diff --git a/HISTORY.md b/HISTORY.md index 83fcf18805..5abe54ee22 100644 --- a/HISTORY.md +++ b/HISTORY.md @@ -1,8 +1,5 @@ ### mlpack ?.?.? ###### ????-??-?? - - * Fix code in tutorials (#3401). - * Bugfix for non-square convolution kernels (#3376). * Fix a few missing includes in `` (#3374).