From ba1f7d227b84efa088302faa474a6e6e2e5a06fc Mon Sep 17 00:00:00 2001 From: himanshupathak21061998 Date: Thu, 23 Apr 2020 00:06:08 +0530 Subject: [PATCH] Adding input output as parameter. --- src/mlpack/core/util/to_lower.hpp | 15 ++++++--------- .../methods/ann/layer/atrous_convolution_impl.hpp | 3 ++- src/mlpack/methods/ann/layer/convolution_impl.hpp | 3 ++- .../ann/layer/transposed_convolution_impl.hpp | 3 ++- 4 files changed, 12 insertions(+), 12 deletions(-) diff --git a/src/mlpack/core/util/to_lower.hpp b/src/mlpack/core/util/to_lower.hpp index deda02fc46..89a15c7efc 100644 --- a/src/mlpack/core/util/to_lower.hpp +++ b/src/mlpack/core/util/to_lower.hpp @@ -2,7 +2,7 @@ * @file to_lower.hpp * @author Himanshu Pathak * - * Convert a string to lower-case. + * Convert a string to lowercase. * * mlpack is free software; you may redistribute it and/or modify it under the * terms of the 3-clause BSD license. You should have received a copy of the @@ -16,18 +16,15 @@ namespace mlpack { namespace util { /** - * ToLower convert a string into a string of lower case characters - * only. + * Convert a string to lowercase letters.  * - * @param str String to convert string. + * @param input The string to convert. + * @param output The string to be converted.  */ -inline std::string ToLower(const std::string& str) +inline void ToLower(const std::string& input, std::string& output) { - std::string out = str; - - std::transform(str.begin(), str.end(), out.begin(), + std::transform(input.begin(), input.end(), output.begin(), [](unsigned char c){ return std::tolower(c); }); - return out; } } // namespace util diff --git a/src/mlpack/methods/ann/layer/atrous_convolution_impl.hpp b/src/mlpack/methods/ann/layer/atrous_convolution_impl.hpp index 9285a35ec2..39ddf035e2 100644 --- a/src/mlpack/methods/ann/layer/atrous_convolution_impl.hpp +++ b/src/mlpack/methods/ann/layer/atrous_convolution_impl.hpp @@ -126,7 +126,8 @@ AtrousConvolution< 1); // Transform paddingType to lowercase. - std::string paddingTypeLow = util::ToLower(paddingType); + std::string paddingTypeLow = paddingType; + util::ToLower(paddingType, paddingTypeLow); size_t padWLeft = std::get<0>(padW); size_t padWRight = std::get<1>(padW); diff --git a/src/mlpack/methods/ann/layer/convolution_impl.hpp b/src/mlpack/methods/ann/layer/convolution_impl.hpp index 47737e995f..5fe1699016 100644 --- a/src/mlpack/methods/ann/layer/convolution_impl.hpp +++ b/src/mlpack/methods/ann/layer/convolution_impl.hpp @@ -121,7 +121,8 @@ Convolution< 1); // Transform paddingType to lowercase. - std::string paddingTypeLow = util::ToLower(paddingType); + std::string paddingTypeLow = paddingType; + util::ToLower(paddingType, paddingTypeLow); if (paddingTypeLow == "valid") { diff --git a/src/mlpack/methods/ann/layer/transposed_convolution_impl.hpp b/src/mlpack/methods/ann/layer/transposed_convolution_impl.hpp index 80bf9c7216..bf66216ea9 100644 --- a/src/mlpack/methods/ann/layer/transposed_convolution_impl.hpp +++ b/src/mlpack/methods/ann/layer/transposed_convolution_impl.hpp @@ -127,7 +127,8 @@ TransposedConvolution< weights.set_size((outSize * inSize * kernelWidth * kernelHeight) + outSize, 1); // Transform paddingType to lowercase. - std::string paddingTypeLow = util::ToLower(paddingType); + std::string paddingTypeLow = paddingType; + util::ToLower(paddingType, paddingTypeLow); if (paddingTypeLow == "valid") {