From 5cef31880eae9e937afd04ba16b5c67679826eff Mon Sep 17 00:00:00 2001 From: SuvarshaChennareddy Date: Mon, 1 Nov 2021 00:03:13 +0530 Subject: [PATCH 1/2] fix comment --- .../methods/pca/decomposition_policies/exact_svd_method.hpp | 2 +- .../methods/pca/decomposition_policies/quic_svd_method.hpp | 2 +- .../decomposition_policies/randomized_block_krylov_method.hpp | 2 +- .../pca/decomposition_policies/randomized_svd_method.hpp | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/mlpack/methods/pca/decomposition_policies/exact_svd_method.hpp b/src/mlpack/methods/pca/decomposition_policies/exact_svd_method.hpp index f583d02a1a..1e98f97392 100644 --- a/src/mlpack/methods/pca/decomposition_policies/exact_svd_method.hpp +++ b/src/mlpack/methods/pca/decomposition_policies/exact_svd_method.hpp @@ -45,7 +45,7 @@ class ExactSVDPolicy arma::mat& eigvec, const size_t /* rank */) { - // This matrix will store the right singular values; we do not need them. + // This matrix will store the right singular vectors; we do not need them. arma::mat v; // Do singular value decomposition. Use the economical singular value diff --git a/src/mlpack/methods/pca/decomposition_policies/quic_svd_method.hpp b/src/mlpack/methods/pca/decomposition_policies/quic_svd_method.hpp index a30e478468..a2807ff025 100644 --- a/src/mlpack/methods/pca/decomposition_policies/quic_svd_method.hpp +++ b/src/mlpack/methods/pca/decomposition_policies/quic_svd_method.hpp @@ -57,7 +57,7 @@ class QUICSVDPolicy arma::mat& eigvec, const size_t /* rank */) { - // This matrix will store the right singular values; we do not need them. + // This matrix will store the right singular vectors; we do not need them. arma::mat v, sigma; // Do singular value decomposition using the QUIC-SVD algorithm. diff --git a/src/mlpack/methods/pca/decomposition_policies/randomized_block_krylov_method.hpp b/src/mlpack/methods/pca/decomposition_policies/randomized_block_krylov_method.hpp index e585df5b20..4485130bc6 100644 --- a/src/mlpack/methods/pca/decomposition_policies/randomized_block_krylov_method.hpp +++ b/src/mlpack/methods/pca/decomposition_policies/randomized_block_krylov_method.hpp @@ -60,7 +60,7 @@ class RandomizedBlockKrylovSVDPolicy arma::mat& eigvec, const size_t rank) { - // This matrix will store the right singular values; we do not need them. + // This matrix will store the right singular vectors; we do not need them. arma::mat v; // Do singular value decomposition using the randomized block krylov SVD diff --git a/src/mlpack/methods/pca/decomposition_policies/randomized_svd_method.hpp b/src/mlpack/methods/pca/decomposition_policies/randomized_svd_method.hpp index 80603dfd17..34f7de60c7 100644 --- a/src/mlpack/methods/pca/decomposition_policies/randomized_svd_method.hpp +++ b/src/mlpack/methods/pca/decomposition_policies/randomized_svd_method.hpp @@ -61,7 +61,7 @@ class RandomizedSVDPolicy arma::mat& eigvec, const size_t rank) { - // This matrix will store the right singular values; we do not need them. + // This matrix will store the right singular vectors; we do not need them. arma::mat v; // Do singular value decomposition using the randomized SVD algorithm. From 753af64f3dba902453f962b1f8b8299552489fe6 Mon Sep 17 00:00:00 2001 From: SuvarshaChennareddy Date: Mon, 1 Nov 2021 19:01:22 +0530 Subject: [PATCH 2/2] adding myself to contributer list --- COPYRIGHT.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/COPYRIGHT.txt b/COPYRIGHT.txt index a578b4747e..4ab00dfb7a 100644 --- a/COPYRIGHT.txt +++ b/COPYRIGHT.txt @@ -145,6 +145,7 @@ Copyright: Copyright 2021, Mark Fischinger Copyright 2021, Muhammad Fawwaz Mayda Copyright 2021, Roshan Nrusing Swain + Copyright 2021, Suvarsha Chennareddy License: BSD-3-clause All rights reserved.