From c1ef30fed5cd152bddecbeb1132378ba9c69db34 Mon Sep 17 00:00:00 2001 From: jeffinsam Date: Sat, 11 May 2019 09:25:31 +0530 Subject: [PATCH] wrapped up lines and some minor corrections --- src/mlpack/core/data/load_arff_impl.hpp | 4 ---- src/mlpack/core/data/one_hot_encoding.hpp | 4 +--- src/mlpack/tests/load_save_test.cpp | 2 +- 3 files changed, 2 insertions(+), 8 deletions(-) diff --git a/src/mlpack/core/data/load_arff_impl.hpp b/src/mlpack/core/data/load_arff_impl.hpp index 2af4dbb01e..195a49e19e 100644 --- a/src/mlpack/core/data/load_arff_impl.hpp +++ b/src/mlpack/core/data/load_arff_impl.hpp @@ -29,10 +29,6 @@ void LoadARFF(const std::string& filename, // First, open the file. std::ifstream ifs; ifs.open(filename, std::ios::in | std::ios::binary); - if (!ifs.is_open()) - { - Log::Fatal << "Cannot open file '" << filename << "'. " << std::endl; - } // if file is not open throw an error (file not found). if (!ifs.is_open()) diff --git a/src/mlpack/core/data/one_hot_encoding.hpp b/src/mlpack/core/data/one_hot_encoding.hpp index 96c1526e73..218d9cb515 100644 --- a/src/mlpack/core/data/one_hot_encoding.hpp +++ b/src/mlpack/core/data/one_hot_encoding.hpp @@ -2,8 +2,7 @@ * @file one_hot_encoding.hpp * @author Jeffin Sam * - * One hot encoding functions - * The purpose of this function is to convert + * One hot encoding functions .The purpose of this function is to convert * categorical variables as binary vectors. * * mlpack is free software; you may redistribute it and/or modify it under the @@ -33,7 +32,6 @@ template void OneHotEncoding(const RowType& labelsIn, arma::Mat& output); - } // namespace data } // namespace mlpack diff --git a/src/mlpack/tests/load_save_test.cpp b/src/mlpack/tests/load_save_test.cpp index 7efebbc8cc..3d4514f6db 100644 --- a/src/mlpack/tests/load_save_test.cpp +++ b/src/mlpack/tests/load_save_test.cpp @@ -920,7 +920,7 @@ BOOST_AUTO_TEST_CASE(OneHotEncodingTest) "1 0;" "0 1;" "1 0;"; -// output matrix +// Output matrix to save onehotencoding results. arma::Mat output; arma::irowvec labels("-1 1 -1 -1 -1 -1 1 -1"); data::OneHotEncoding(labels, output);