From cd4c1b0ba236cc86c3ef216547714cae6ea2c66a Mon Sep 17 00:00:00 2001 From: Ayush Date: Thu, 28 Feb 2019 22:17:43 +0530 Subject: [PATCH] refactored reviewed syntax issues. --- .../linear_svm/linear_svm_function.hpp | 1 + .../linear_svm/linear_svm_function_impl.hpp | 27 ++++++++++--------- .../methods/linear_svm/linear_svm_impl.hpp | 10 +++---- 3 files changed, 20 insertions(+), 18 deletions(-) diff --git a/src/mlpack/methods/linear_svm/linear_svm_function.hpp b/src/mlpack/methods/linear_svm/linear_svm_function.hpp index bd7e568dcc..72df7f4444 100644 --- a/src/mlpack/methods/linear_svm/linear_svm_function.hpp +++ b/src/mlpack/methods/linear_svm/linear_svm_function.hpp @@ -18,6 +18,7 @@ namespace mlpack { namespace svm { + /** * The hinge loss function for the linear SVM objective function. * This is used by various ensmallen optimizers to train the linear diff --git a/src/mlpack/methods/linear_svm/linear_svm_function_impl.hpp b/src/mlpack/methods/linear_svm/linear_svm_function_impl.hpp index 82de6dea33..a1b6ce6466 100644 --- a/src/mlpack/methods/linear_svm/linear_svm_function_impl.hpp +++ b/src/mlpack/methods/linear_svm/linear_svm_function_impl.hpp @@ -25,13 +25,13 @@ namespace svm { template LinearSVMFunction::LinearSVMFunction( - const MatType& dataset, - const arma::Row& labels, - const size_t numClasses, - const double lambda) : - dataset(math::MakeAlias(const_cast(dataset), false)), - numClasses(numClasses), - lambda(lambda) + const MatType& dataset, + const arma::Row& labels, + const size_t numClasses, + const double lambda) : + dataset(math::MakeAlias(const_cast(dataset), false)), + numClasses(numClasses), + lambda(lambda) { // Initialize the parameters to suitable values. initialPoint = InitializeWeights(); @@ -53,8 +53,8 @@ const arma::mat LinearSVMFunction::InitializeWeights() template const arma::mat LinearSVMFunction::InitializeWeights( - const size_t featureSize, - const size_t numClasses) + const size_t featureSize, + const size_t numClasses) { arma::mat parameters; InitializeWeights(parameters, featureSize, numClasses); @@ -63,9 +63,9 @@ const arma::mat LinearSVMFunction::InitializeWeights( template void LinearSVMFunction::InitializeWeights( - arma::mat &weights, - const size_t featureSize, - const size_t numClasses) + arma::mat &weights, + const size_t featureSize, + const size_t numClasses) { // Initialize values to 0.005 * r. 'r' is a matrix of random values taken from // a Gaussian distribution with mean zero and variance one. @@ -80,7 +80,8 @@ void LinearSVMFunction::InitializeWeights( */ template void LinearSVMFunction::GetGroundTruthMatrix( - const arma::Row& labels, arma::sp_mat& groundTruth) + const arma::Row& labels, + arma::sp_mat& groundTruth) { // Calculate the ground truth matrix according to the labels passed. The // ground truth matrix is a matrix of dimensions 'numClasses * numExamples', diff --git a/src/mlpack/methods/linear_svm/linear_svm_impl.hpp b/src/mlpack/methods/linear_svm/linear_svm_impl.hpp index 40f693417f..42816eaf7e 100644 --- a/src/mlpack/methods/linear_svm/linear_svm_impl.hpp +++ b/src/mlpack/methods/linear_svm/linear_svm_impl.hpp @@ -79,9 +79,9 @@ const template void LinearSVM::Classify( - const MatType& data, - arma::Row& labels, - arma::mat& scores) + const MatType& data, + arma::Row& labels, + arma::mat& scores) const { Classify(data, scores); @@ -111,8 +111,8 @@ const template void LinearSVM::Classify( - const MatType& data, - arma::mat& scores) + const MatType& data, + arma::mat& scores) const { if (data.n_rows != FeatureSize())