From f6c8e1b3eb79da0b03af8b6afbbdb4afad6710f2 Mon Sep 17 00:00:00 2001
From: Rishabh Garg <56191449+RishabhGarg108@users.noreply.github.com>
Date: Sat, 10 Jul 2021 08:15:59 +0530
Subject: [PATCH] Add static keyword to function... Doesn't compile yet.

---
 .../decision_tree/best_binary_numeric_split.hpp    | 14 +++++++++++---
 .../best_binary_numeric_split_impl.hpp             | 12 ++++++++++--
 2 files changed, 21 insertions(+), 5 deletions(-)

diff --git a/src/mlpack/methods/decision_tree/best_binary_numeric_split.hpp b/src/mlpack/methods/decision_tree/best_binary_numeric_split.hpp
index 3f5cd27e65..6114b7e1b9 100644
--- a/src/mlpack/methods/decision_tree/best_binary_numeric_split.hpp
+++ b/src/mlpack/methods/decision_tree/best_binary_numeric_split.hpp
@@ -101,7 +101,15 @@ class BestBinaryNumericSplit
    */
   template<bool UseWeights, typename VecType, typename ResponsesType,
            typename WeightVecType>
-  static double SplitIfBetter(
+  static typename std::enable_if<
+      !HasBinaryScanInitialize<FitnessFunction, void(FitnessFunction::*)
+          (const ResponsesType&, const WeightVecType&, const size_t)>::value &&
+      !HasBinaryStep<FitnessFunction, void(FitnessFunction::*)
+          (const ResponsesType&, const WeightVecType&, const size_t)>::value &&
+      !HasBinaryGains<FitnessFunction,
+          std::tuple<double, double>(FitnessFunction::*)(void)>::value,
+      double>::type
+  SplitIfBetter(
       const double bestGain,
       const VecType& data,
       const ResponsesType& responses,
@@ -134,13 +142,13 @@ class BestBinaryNumericSplit
    */
   template<bool UseWeights, typename VecType, typename ResponsesType,
           typename WeightVecType>
-  typename std::enable_if<
+  static typename std::enable_if<
       HasBinaryScanInitialize<FitnessFunction, void(FitnessFunction::*)
           (const ResponsesType&, const WeightVecType&, const size_t)>::value &&
       HasBinaryStep<FitnessFunction, void(FitnessFunction::*)
           (const ResponsesType&, const WeightVecType&, const size_t)>::value &&
       HasBinaryGains<FitnessFunction,
-          std::tuple<double, double>(FitnessFunction::*)()>::value,
+          std::tuple<double, double>(FitnessFunction::*)(void)>::value,
       double>::type
   SplitIfBetter(
       const double bestGain,
diff --git a/src/mlpack/methods/decision_tree/best_binary_numeric_split_impl.hpp b/src/mlpack/methods/decision_tree/best_binary_numeric_split_impl.hpp
index 3d0ebdc078..76fb90df95 100644
--- a/src/mlpack/methods/decision_tree/best_binary_numeric_split_impl.hpp
+++ b/src/mlpack/methods/decision_tree/best_binary_numeric_split_impl.hpp
@@ -189,7 +189,15 @@ double BestBinaryNumericSplit<FitnessFunction>::SplitIfBetter(
 template<typename FitnessFunction>
 template<bool UseWeights, typename VecType, typename ResponsesType,
          typename WeightVecType>
-double BestBinaryNumericSplit<FitnessFunction>::SplitIfBetter(
+typename std::enable_if<
+    !HasBinaryScanInitialize<FitnessFunction, void(FitnessFunction::*)
+        (const ResponsesType&, const WeightVecType&, const size_t)>::value &&
+    !HasBinaryStep<FitnessFunction, void(FitnessFunction::*)
+        (const ResponsesType&, const WeightVecType&, const size_t)>::value &&
+    !HasBinaryGains<FitnessFunction,
+        std::tuple<double, double>(FitnessFunction::*)(void)>::value,
+    double>::type
+BestBinaryNumericSplit<FitnessFunction>::SplitIfBetter(
     const double bestGain,
     const VecType& data,
     const ResponsesType& responses,
@@ -329,7 +337,7 @@ typename std::enable_if<
     HasBinaryStep<FitnessFunction, void(FitnessFunction::*)
         (const ResponsesType&, const WeightVecType&, const size_t)>::value &&
     HasBinaryGains<FitnessFunction,
-        std::tuple<double, double>(FitnessFunction::*)()>::value,
+        std::tuple<double, double>(FitnessFunction::*)(void)>::value,
     double>::type
 BestBinaryNumericSplit<FitnessFunction>::SplitIfBetter(
     const double bestGain,