* Drop pytest-runner and "setup.py test" support
This does not affect running the tests with `pytest`.
Add a `test` extra to represent test dependencies.
* Remove spurious more-itertools test dependency
* Add HISTORY.md entry
* Add Benjamin A. Beasley to COPYRIGHT.txt
* Fix#3912 by computing the product of input dimensions.
* Update HISTORY.
* Try to fix cross-compilation failure (part 1).
* Now actually copy the cat over and the test should pass.
* Adding the crop function implementation
Signed-off-by: Omar Shrit <omar@avontech.fr>
* Remove debugging symbols
Signed-off-by: Omar Shrit <omar@avontech.fr>
* Add another two sheeps photos
Signed-off-by: Omar Shrit <omar@avontech.fr>
* Adding tests for cropping the images
Signed-off-by: Omar Shrit <omar@avontech.fr>
* Adding documentation of CropResize
Signed-off-by: Omar Shrit <omar@avontech.fr>
* Improve the imeplementation according to what is mentioned
Signed-off-by: Omar Shrit <omar@avontech.fr>
* Adding images to make it easier to understand
Signed-off-by: Omar Shrit <omar@avontech.fr>
* Update src/mlpack/core/data/image_resize_crop.hpp
Co-authored-by: Ryan Curtin <ryan@ratml.org>
* Update doc/user/load_save.md
Co-authored-by: Ryan Curtin <ryan@ratml.org>
* Update src/mlpack/core/data/image_resize_crop.hpp
Co-authored-by: Ryan Curtin <ryan@ratml.org>
* Update src/mlpack/core/data/image_resize_crop.hpp
Co-authored-by: Ryan Curtin <ryan@ratml.org>
* Update src/mlpack/core/data/image_resize_crop.hpp
Co-authored-by: Ryan Curtin <ryan@ratml.org>
* Fix Ryan proposal
Signed-off-by: Omar Shrit <omar@avontech.fr>
* Fix the docs
Signed-off-by: Omar Shrit <omar@avontech.fr>
* Remove the test regarding checking of the dimension are identical
Signed-off-by: Omar Shrit <omar@avontech.fr>
* Add a pixel-level sanity check test.
* Update documentation; slight wording cleanup, add a clear example.
* Add a test for the case where we upscale.
* Use different filenames.
* Prevent resize if the user did not ask for it
Signed-off-by: Omar Shrit <omar@avontech.fr>
* Remove unused variables.
* Change && to ||
Signed-off-by: Omar Shrit <omar@avontech.fr>
* Fix style, and function name
Signed-off-by: Omar Shrit <omar@avontech.fr>
* Fix the other style issues
Signed-off-by: Omar Shrit <omar@avontech.fr>
* Add a note to HISTORY.md.
---------
Signed-off-by: Omar Shrit <omar@avontech.fr>
Co-authored-by: Ryan Curtin <ryan@ratml.org>
* Add Findmlack.cmake
I opened this PR, because it was so difficult to revive the old one.
Signed-off-by: Omar Shrit <omar@avontech.fr>
* Adding the comments from the previous PR
Signed-off-by: Omar Shrit <omar@avontech.fr>
* Add the docs again
Signed-off-by: Omar Shrit <omar@avontech.fr>
* Add depedencies functions
Signed-off-by: Omar Shrit <omar@avontech.fr>
* Make the filename compatible with the standard
Signed-off-by: Omar Shrit <omar@avontech.fr>
* Move the dependencies search from CMakeLists
Signed-off-by: Omar Shrit <omar@avontech.fr>
* Remove MATHJAX
Signed-off-by: Omar Shrit <omar@avontech.fr>
* Refactor the CMake into dependencies
Signed-off-by: Omar Shrit <omar@avontech.fr>
* Remove Findarmadillo since it exist in CMake
Signed-off-by: Omar Shrit <omar@avontech.fr>
* Remove Arpack as well, already in the main stream
Signed-off-by: Omar Shrit <omar@avontech.fr>
* This needs to go, tooo old
Signed-off-by: Omar Shrit <omar@avontech.fr>
* Move cereal and ensmallen to mlpack
Signed-off-by: Omar Shrit <omar@avontech.fr>
* Get rid of the empty files
Signed-off-by: Omar Shrit <omar@avontech.fr>
* Remove Doxygen generation file
Signed-off-by: Omar Shrit <omar@avontech.fr>
* Finish Findmlpack.cmake file
Signed-off-by: Omar Shrit <omar@avontech.fr>
* Increase Cmake version to 3.11 to avoid the warning
Signed-off-by: Omar Shrit <omar@avontech.fr>
* Add POST_BUILD to get rid of the warning
Signed-off-by: Omar Shrit <omar@avontech.fr>
* Remove really old support for MACOS 11 and 9
This is more like 15 years old already
Signed-off-by: Omar Shrit <omar@avontech.fr>
* Already specified no need to do it again
Signed-off-by: Omar Shrit <omar@avontech.fr>
* Fix according to comments from @rcurtin
Signed-off-by: Omar Shrit <omar@avontech.fr>
* add message for armadillo
Signed-off-by: Omar Shrit <omar@avontech.fr>
* Try to fix windows and cross CI at the same time
Signed-off-by: Omar Shrit <omar@avontech.fr>
* Let us add brutally STB and Armadillo
Signed-off-by: Omar Shrit <omar@avontech.fr>
* Remove STB image independant file from here
Signed-off-by: Omar Shrit <omar@avontech.fr>
* Adding more into findmlpack
Signed-off-by: Omar Shrit <omar@avontech.fr>
* Move things from CMake as they are not directly relevant
Signed-off-by: Omar Shrit <omar@avontech.fr>
* Move the autdownloader to findmlpack
Signed-off-by: Omar Shrit <omar@avontech.fr>
* remove the autodownload
Signed-off-by: Omar Shrit <omar@avontech.fr>
* Remove cmakeextras, added for obsure reasons
Signed-off-by: Omar Shrit <omar@avontech.fr>
* Remove license for really old stuff
Signed-off-by: Omar Shrit <omar@avontech.fr>
* Re-order the file how it should be
Signed-off-by: Omar Shrit <omar@avontech.fr>
* Move out of dependency
Signed-off-by: Omar Shrit <omar@avontech.fr>
* Remove Dependencies, as it is no longer used
Signed-off-by: Omar Shrit <omar@avontech.fr>
* Add stb to this file again
Signed-off-by: Omar Shrit <omar@avontech.fr>
* reorganize functions
Signed-off-by: Omar Shrit <omar@avontech.fr>
* Add find armadillo
Signed-off-by: Omar Shrit <omar@avontech.fr>
* Remove Dependencies files and autdownload
Signed-off-by: Omar Shrit <omar@avontech.fr>
* Make it use the internal functions
Signed-off-by: Omar Shrit <omar@avontech.fr>
* Finishing most of the cmake modifications
Signed-off-by: Omar Shrit <omar@avontech.fr>
* Fix a couple of last things
Signed-off-by: Omar Shrit <omar@avontech.fr>
* Change the name and remove old file
Signed-off-by: Omar Shrit <omar@avontech.fr>
* Fix all comments left by @rcurtin
Signed-off-by: Omar Shrit <omar@avontech.fr>
* Fix the docs for each of the function
Signed-off-by: Omar Shrit <omar@avontech.fr>
* Move the cross compilation to inside fetch and make it as an auto detect
Signed-off-by: Omar Shrit <omar@avontech.fr>
* Cut the parts that are refactored
Signed-off-by: Omar Shrit <omar@avontech.fr>
* Fix function name
Signed-off-by: Omar Shrit <omar@avontech.fr>
* Remove the ""
Signed-off-by: Omar Shrit <omar@avontech.fr>
* Update doc/embedded/crosscompile_example.md
Co-authored-by: Ryan Curtin <ryan@ratml.org>
* Update CMake/mlpack.cmake
Co-authored-by: Ryan Curtin <ryan@ratml.org>
* Update CMake/mlpack.cmake
Co-authored-by: Ryan Curtin <ryan@ratml.org>
* Update CMake/mlpack.cmake
Co-authored-by: Ryan Curtin <ryan@ratml.org>
* Update CMake/mlpack.cmake
Co-authored-by: Ryan Curtin <ryan@ratml.org>
* Update CMake/mlpack.cmake
Co-authored-by: Ryan Curtin <ryan@ratml.org>
* Update CMake/mlpack.cmake
Co-authored-by: Ryan Curtin <ryan@ratml.org>
* Update doc/embedded/crosscompile_example.md
Co-authored-by: Ryan Curtin <ryan@ratml.org>
* Update doc/embedded/crosscompile_example.md
Co-authored-by: Ryan Curtin <ryan@ratml.org>
* Update doc/embedded/crosscompile_example.md
Co-authored-by: Ryan Curtin <ryan@ratml.org>
* Update doc/embedded/crosscompile_example.md
Co-authored-by: Ryan Curtin <ryan@ratml.org>
* Update doc/embedded/crosscompile_example.md
Co-authored-by: Ryan Curtin <ryan@ratml.org>
* Update doc/embedded/crosscompile_example.md
Co-authored-by: Ryan Curtin <ryan@ratml.org>
* Update doc/embedded/crosscompile_example.md
Co-authored-by: Ryan Curtin <ryan@ratml.org>
* Update doc/embedded/crosscompile_example.md
Co-authored-by: Ryan Curtin <ryan@ratml.org>
* Update doc/embedded/crosscompile_example.md
Co-authored-by: Ryan Curtin <ryan@ratml.org>
* Update doc/embedded/crosscompile_example.md
Co-authored-by: Ryan Curtin <ryan@ratml.org>
* Update doc/embedded/crosscompile_example.md
Co-authored-by: Ryan Curtin <ryan@ratml.org>
* Update doc/embedded/crosscompile_example.md
Co-authored-by: Ryan Curtin <ryan@ratml.org>
* Update doc/embedded/crosscompile_example.md
Co-authored-by: Ryan Curtin <ryan@ratml.org>
* Update doc/embedded/crosscompile_example.md
Co-authored-by: Ryan Curtin <ryan@ratml.org>
* Fix text and code
Signed-off-by: Omar Shrit <omar@avontech.fr>
* Apply comments from @rcurtin
Signed-off-by: Omar Shrit <omar@avontech.fr>
* modify CMakeLists accordingly
Signed-off-by: Omar Shrit <omar@avontech.fr>
* Add PR in the history
Signed-off-by: Omar Shrit <omar@avontech.fr>
* Update CMake/mlpack.cmake
Co-authored-by: Ryan Curtin <ryan@ratml.org>
* Update CMake/mlpack.cmake
Co-authored-by: Ryan Curtin <ryan@ratml.org>
* Update doc/embedded/crosscompile_example.md
Co-authored-by: Ryan Curtin <ryan@ratml.org>
* Update HISTORY.md
Co-authored-by: Ryan Curtin <ryan@ratml.org>
* Update doc/embedded/crosscompile_example.md
Co-authored-by: Ryan Curtin <ryan@ratml.org>
---------
Signed-off-by: Omar Shrit <omar@avontech.fr>
Co-authored-by: Ryan Curtin <ryan@ratml.org>
* Move STB internally, comment functions if not
Signed-off-by: Omar Shrit <omar@avontech.fr>
* Comment for now STB including macros
Signed-off-by: Omar Shrit <omar@avontech.fr>
* Modify CMake and tests accordingly
Signed-off-by: Omar Shrit <omar@avontech.fr>
* Fix the license and update the date.
Signed-off-by: Omar Shrit <omar@avontech.fr>
* Move STB to its own directory
Signed-off-by: Omar Shrit <omar@avontech.fr>
* Adding the functrions of image resize and crop
Signed-off-by: Omar Shrit <omar@avontech.fr>
* Update the API not finished yet
Signed-off-by: Omar Shrit <omar@avontech.fr>
* Start adding tests
Signed-off-by: Omar Shrit <omar@avontech.fr>
* Add flowers images for test
Signed-off-by: Omar Shrit <omar@avontech.fr>
* Bring image from the coco dataset
Signed-off-by: Omar Shrit <omar@avontech.fr>
* Include all of STB header in this file
Signed-off-by: Omar Shrit <omar@avontech.fr>
* Fix STB configs
Signed-off-by: Omar Shrit <omar@avontech.fr>
* Clean CMakeLists and look for stb_resize
Signed-off-by: Omar Shrit <omar@avontech.fr>
* Make it compile with STB integrated
Signed-off-by: Omar Shrit <omar@avontech.fr>
* Fix stb path
Signed-off-by: Omar Shrit <omar@avontech.fr>
* Fix the endif at the end of the file
Signed-off-by: Omar Shrit <omar@avontech.fr>
* Update LICENSE.txt
Co-authored-by: Ryan Curtin <ryan@ratml.org>
* Update CMakeLists.txt
Co-authored-by: Ryan Curtin <ryan@ratml.org>
* Update src/mlpack/config.hpp
Co-authored-by: Ryan Curtin <ryan@ratml.org>
* Adding the function and test, not finished
Signed-off-by: Omar Shrit <omar@avontech.fr>
* Remove crop from this PR, and add tests
Signed-off-by: Omar Shrit <omar@avontech.fr>
* Update LICENSE.txt
Co-authored-by: Dirk Eddelbuettel <edd@debian.org>
* Update CMakeLists.txt
Co-authored-by: Dirk Eddelbuettel <edd@debian.org>
* merge master
Signed-off-by: Omar Shrit <omar@avontech.fr>
* Add @rcutin suggestion for stb
Signed-off-by: Omar Shrit <omar@avontech.fr>
* Improve the logic to include edge cases
Signed-off-by: Omar Shrit <omar@avontech.fr>
* Fix the bundle that if we are using system stb
Signed-off-by: Omar Shrit <omar@avontech.fr>
* Make it possible to disable the entire build with STB
Signed-off-by: Omar Shrit <omar@avontech.fr>
* Fix the else if condition
Signed-off-by: Omar Shrit <omar@avontech.fr>
* Fix the else condition
Signed-off-by: Omar Shrit <omar@avontech.fr>
* Fix the tests accordindly
Signed-off-by: Omar Shrit <omar@avontech.fr>
* Add dummpy functions and complete the Resize function
Signed-off-by: Omar Shrit <omar@avontech.fr>
* Reorder to see if this fix the problem
Signed-off-by: Omar Shrit <omar@avontech.fr>
* Fix the resize for a set of images
Signed-off-by: Omar Shrit <omar@avontech.fr>
* Add STATIC for resize and write
Signed-off-by: Omar Shrit <omar@avontech.fr>
* Fix all the problem with this function
Signed-off-by: Omar Shrit <omar@avontech.fr>
* Be able to resize N images easily
Signed-off-by: Omar Shrit <omar@shrit.fr>
* Add the tests, already passing
Signed-off-by: Omar Shrit <omar@shrit.fr>
* Use sheep instead of Umbrella
Signed-off-by: Omar Shrit <omar@shrit.fr>
* Fix STB directory
Signed-off-by: Omar Shrit <omar@shrit.fr>
* Fix Cmake and docs
Signed-off-by: Omar Shrit <omar@shrit.fr>
* Apply comments from @rcurtin
Signed-off-by: Omar Shrit <omar@shrit.fr>
* Integrate @rcurtin comments
Signed-off-by: Omar Shrit <omar@shrit.fr>
* Fix tests and remove generated images
Signed-off-by: Omar Shrit <omar@shrit.fr>
* Add docs
Signed-off-by: Omar Shrit <omar@shrit.fr>
* Update the API with new resize version
Signed-off-by: Omar Shrit <omar@shrit.fr>
* Fix to resize2
Signed-off-by: Omar Shrit <omar@shrit.fr>
* Adding resize2
Signed-off-by: Omar Shrit <omar@shrit.fr>
* Add the necessary fix to avoid linker errors
Signed-off-by: Omar Shrit <omar@avontech.fr>
* Add configs to allow correct repacking
Signed-off-by: Omar Shrit <omar@shrit.fr>
* Redo the ResizeImages function
Signed-off-by: Omar Shrit <omar@shrit.fr>
* Pack the images as tzr.bz2
Signed-off-by: Omar Shrit <omar@shrit.fr>
* Fix the function calls and create an internal one
Signed-off-by: Omar Shrit <omar@avontech.fr>
* Make the message shorter to have under 80 chars
Signed-off-by: Omar Shrit <omar@avontech.fr>
* Solve linter errors
Signed-off-by: Omar Shrit <omar@avontech.fr>
* Solve linter error
Signed-off-by: Omar Shrit <omar@avontech.fr>
* Fix linter issues
Signed-off-by: Omar Shrit <omar@avontech.fr>
* Update doc/user/load_save.md
Co-authored-by: Ryan Curtin <ryan@ratml.org>
* Update src/mlpack/tests/image_test.cpp
Co-authored-by: Ryan Curtin <ryan@ratml.org>
* Update src/mlpack/core/data/image_resize_crop.hpp
Co-authored-by: Ryan Curtin <ryan@ratml.org>
* Update src/mlpack/core/data/image_resize_crop.hpp
Co-authored-by: Ryan Curtin <ryan@ratml.org>
* Update doc/user/load_save.md
Co-authored-by: Ryan Curtin <ryan@ratml.org>
* Update doc/user/load_save.md
Co-authored-by: Ryan Curtin <ryan@ratml.org>
* Update src/mlpack/tests/image_test.cpp
Co-authored-by: Ryan Curtin <ryan@ratml.org>
* Update src/mlpack/tests/image_test.cpp
Co-authored-by: Ryan Curtin <ryan@ratml.org>
* Update src/mlpack/tests/image_test.cpp
Co-authored-by: Ryan Curtin <ryan@ratml.org>
* Update src/mlpack/tests/image_test.cpp
Co-authored-by: Ryan Curtin <ryan@ratml.org>
* Update src/mlpack/core/data/image_resize_crop.hpp
Co-authored-by: Ryan Curtin <ryan@ratml.org>
* Apply @rcurtin comments
Signed-off-by: Omar Shrit <omar@avontech.fr>
* Add an example usage of these two functions
Signed-off-by: Omar Shrit <omar@avontech.fr>
* Apply @rcurtin comments
Signed-off-by: Omar Shrit <omar@avontech.fr>
* Re-organize directories for STB
Signed-off-by: Omar Shrit <omar@avontech.fr>
* Apply rcurtin comments
Signed-off-by: Omar Shrit <omar@avontech.fr>
* Merge two resize functions into one
Signed-off-by: Omar Shrit <omar@avontech.fr>
* Get rid of MLPACK_DISABLE_STB
Signed-off-by: Omar Shrit <omar@avontech.fr>
* Fix forgetting docs
Signed-off-by: Omar Shrit <omar@avontech.fr>
* Update CMake/FindStbImage.cmake
Co-authored-by: Ryan Curtin <ryan@ratml.org>
* Update CMake/FindStbImage.cmake
Co-authored-by: Ryan Curtin <ryan@ratml.org>
* Update doc/user/install.md
Co-authored-by: Ryan Curtin <ryan@ratml.org>
* Update doc/user/compile.md
Co-authored-by: Ryan Curtin <ryan@ratml.org>
* Update src/mlpack/core/data/image_resize_crop.hpp
Co-authored-by: Ryan Curtin <ryan@ratml.org>
* Update doc/user/load_save.md
Co-authored-by: Ryan Curtin <ryan@ratml.org>
* Update doc/user/load_save.md
Co-authored-by: Ryan Curtin <ryan@ratml.org>
* Update doc/user/load_save.md
Co-authored-by: Ryan Curtin <ryan@ratml.org>
* Update doc/user/load_save.md
Co-authored-by: Ryan Curtin <ryan@ratml.org>
* Update src/mlpack/core/data/image_resize_crop.hpp
Co-authored-by: Ryan Curtin <ryan@ratml.org>
* Update src/mlpack/core/data/image_resize_crop.hpp
Co-authored-by: Ryan Curtin <ryan@ratml.org>
* Update src/mlpack/core/data/image_resize_crop.hpp
Co-authored-by: Ryan Curtin <ryan@ratml.org>
* Update doc/user/load_save.md
Co-authored-by: Ryan Curtin <ryan@ratml.org>
* Apply comments from @rcurtin
Signed-off-by: Omar Shrit <omar@avontech.fr>
* Adding the test to test if it is identical
Signed-off-by: Omar Shrit <omar@avontech.fr>
* Fix image tests
Signed-off-by: Omar Shrit <omar@avontech.fr>
* Fix the example
Signed-off-by: Omar Shrit <omar@avontech.fr>
* Add the link and the patch to download the images
Signed-off-by: Omar Shrit <omar@avontech.fr>
* Fix the script and make all of them green
Signed-off-by: Omar Shrit <omar@avontech.fr>
* Remove wget not needed
Signed-off-by: Omar Shrit <omar@avontech.fr>
* Minor style fixes.
* Avoid temporary matrices, and test with multiple different types.
* Update src/mlpack/config.hpp
Co-authored-by: Ryan Curtin <ryan@ratml.org>
* Update HISTORY.md
Co-authored-by: Ryan Curtin <ryan@ratml.org>
* Fix R build by including bundled STB headers in package.
---------
Signed-off-by: Omar Shrit <omar@avontech.fr>
Signed-off-by: Omar Shrit <omar@shrit.fr>
Co-authored-by: Ryan Curtin <ryan@ratml.org>
Co-authored-by: Dirk Eddelbuettel <edd@debian.org>
* Add LinearRecurrent layer and tests.
* Update RecurrentLayer for correct BPTT and document API changes.
* Reimplement BPTT---correctly, this time.
* Fix RNN implementation and add tests.
* Fix and test LSTM.
* Fix BPTT implementation to use all time steps and add some more tests.
* Fix and tune recurrent sine tests.
* Fix serialization for LinearRecurrent.
* Fix compilation warning when serialization is not enabled.
* When I use the MSE I expect the mean squared error, not the squared error. These reductions will need to be revisited at some point.
* Restore Reber grammar tests, revamp them, and tune other tests.
* Fix a few tests.
* Update HISTORY.
* Fix style issues.
* Fix one small behavioral change.
* Handle review comments.
Although more files are touched in order to improve "include what you
use", the message focuses on the behavioral change that can be detected
by users for sure.
The new compiler version seems to perform more exhaustive checks on
templates, even if they are not initiated. As the code was malformed
also before, it is likely that it is dead code. However, this commit is
mainly to ensure users using clang 19 can include the header without
compilation error.
Note that this commit does not guarantee that currently other code might
not compile with clang 19, it just fixes some code which was used
transitevily and caused problems.
Ben Beasley