Commit Graph
11486 Commits
Author SHA1 Message Date
Omar Shrit a7c9635575 Disable copy constructor for the array_wrapper
Signed-off-by: Omar Shrit <omar@shrit.me>
2020-07-09 13:53:50 +02:00
Omar Shrit 1d52b1699e Comment all tests and keep binary tree test
Signed-off-by: Omar Shrit <omar@shrit.me>
2020-07-07 17:00:52 +02:00
Omar Shrit 7ef10acef2 Use pointer wrapper in binary_space_tree
This will serialize raw pointers using pointer wrapper

Signed-off-by: Omar Shrit <omar@shrit.me>
2020-07-07 16:57:15 +02:00
Omar Shrit 94f07daca0 Replace boost::serialization by cereal in Test
Signed-off-by: Omar Shrit <omar@shrit.me>
2020-07-07 16:53:46 +02:00
Omar Shrit e62e339422 Replace boost serialization headers with cereal headers
Signed-off-by: Omar Shrit <omar@shrit.me>
2020-07-07 16:27:59 +02:00
Omar Shrit 1b7a70bb4f Add a pointer wrapper header in prereqs header file
Signed-off-by: Omar Shrit <omar@shrit.me>
2020-07-07 16:12:22 +02:00
Omar Shrit 8e035fea12 Adding a local make_unique since it is not available in C++11
This is a small hack until the mlpack uses C++14 as the defaults

Signed-off-by: Omar Shrit <omar@shrit.me>
2020-07-07 16:09:44 +02:00
Omar Shrit 9a4ef61e06 Add a pointer wrapper to make cereal serialize raw pointer
This is a local implmentation since cereal does not support
the serialization of raw pointers

Signed-off-by: Omar Shrit <omar@shrit.me>
2020-07-07 15:12:47 +02:00
Omar Shrit b0a468c02f Remove pointer wrapper test
Signed-off-by: Omar Shrit <omar@shrit.me>
2020-07-07 12:34:29 +02:00
Omar Shrit 52efa3075a Merge branch 'cereal' of https://github.com/shrit/mlpack into cereal 2020-07-07 12:29:28 +02:00
Omar Shrit 987dee5bf3 macro for pointer wrapper, not finished yet
Signed-off-by: Omar Shrit <omar@shrit.me>
2020-07-07 12:15:15 +02:00
shritandRyan Curtin 097063fe4f Adding missing reference in the wrapper
Co-authored-by: Ryan Curtin <ryan@ratml.org>
2020-07-07 10:35:23 +02:00
shritandRyan Curtin 4cf63a0c01 return the class directly instead of object of it
Co-authored-by: Ryan Curtin <ryan@ratml.org>
2020-07-07 10:33:16 +02:00
Omar Shrit 6aa48d6bfa Replace BOOST_SERIALZIATION by CEREAL
Apply the modification on the new added files after
merging this branch with the master branch

Signed-off-by: Omar Shrit <omar@shrit.me>
2020-07-05 23:28:51 +02:00
Omar Shrit 2ad94c5480 Updated main, shows how to use pointer wrapper
Since we are releasing a unique ptr we need to delete
the pointer at the end otherwise we will lose this memeory

Signed-off-by: Omar Shrit <omar@shrit.me>
2020-07-05 23:06:00 +02:00
Omar Shrit 10c3db3ee9 Adding a small test main function
Signed-off-by: Omar Shrit <omar@shrit.me>
2020-07-05 23:05:43 +02:00
Omar Shrit e4ecc87090 Pointer wrapper to serialize raw pointer with cereal
Signed-off-by: Omar Shrit <omar@shrit.me>
2020-07-05 23:04:05 +02:00
Omar Shrit 9ff99799ea Another tests that I have done by changing the pointer_wrapper
Only you have to change name to do tests

Signed-off-by: Omar Shrit <omar@shrit.me>
2020-07-05 23:03:52 +02:00
Omar Shrit 11e7f1e6ee Adding a pointer wrapper.
Signed-off-by: Omar Shrit <omar@shrit.me>
2020-07-05 23:03:00 +02:00
Omar Shrit 88f2be8538 Merge branch 'master' into cereal 2020-07-05 22:57:10 +02:00
Ryan Curtin 4eb47775fe Merge pull request #2489 from rcurtin/cli-fatal-cleanup
Remove unnecessary Log::Fatal `ignoreInput` settings
2020-07-05 14:01:21 -04:00
Ryan Birmingham 148e89761d Merge pull request #2502 from rcurtin/update-soversion
Update to soversion libmlpack.so.3.3
2020-07-05 09:28:08 -04:00
Ryan Curtin 5a0c0a2a10 Update to soversion libmlpack.so.3.3 (this should have happened earlier, sorry). 2020-07-04 17:00:14 -04:00
Mrityunjay Tripathi 661bcfd3eb change variable name reduction to mean 2020-07-03 22:47:34 +05:30
Mrityunjay Tripathi 9c496efae3 Merge branch 'master' of https://github.com/mlpack/mlpack into poisson_nll_loss 2020-07-02 21:13:48 +05:30
Ryan Birmingham 7adc6fb89e Merge pull request #2491 from kartikdutt18/StyleFixes
Cellbound Tree Style Fixes.
2020-07-02 09:26:27 -04:00
Ryan Birmingham 77da33b6d1 Merge pull request #2486 from rcurtin/arff-fixes
Some fixes for the ARFF loader
2020-07-02 01:18:21 -04:00
kartikdutt18 ae35793e7b Style Fixes 2020-07-01 23:11:21 +05:30
Mrityunjay Tripathi 62f9e3ef7d Merge branch 'master' of github.com:mrityunjay-tripathi/mlpack into poisson_nll_loss 2020-07-01 22:27:04 +05:30
Ryan Curtin 75b2fd6b74 Fix little style issues. 2020-07-01 09:34:14 -04:00
Mrityunjay Tripathi 6638cf72bf remove check from Backward 2020-07-01 11:35:55 +05:30
Ryan Curtin 08d107a225 Fix equation definition. 2020-06-30 18:22:09 -04:00
Ryan Curtin 2b726e02c9 Remove unnecessary Log::Fatal input ignores. 2020-06-30 18:08:11 -04:00
Mrityunjay Tripathi a547d43145 adding tests for logInput = false 2020-06-30 23:50:23 +05:30
Mrityunjay Tripathi 71eb4eda69 check if probs are in range [0, 1] 2020-06-30 23:20:29 +05:30
Mrityunjay Tripathi 4b944c5a39 adding more tests 2020-06-30 22:52:21 +05:30
Omar Shrit c4810b16c0 Remove included cereal header during testing
Signed-off-by: Omar Shrit <omar@shrit.me>
2020-06-30 19:13:30 +02:00
Omar Shrit cca27dc4c4 Remove cereal header from this methode
Already included no need to re-include them

Signed-off-by: Omar Shrit <omar@shrit.me>
2020-06-30 19:13:30 +02:00
Omar Shrit 769a702a5d Include boost variant support for cereal
Signed-off-by: Omar Shrit <omar@shrit.me>
2020-06-30 19:13:30 +02:00
Omar Shrit 7dfe2cb8d8 It seems that cereal does not like const qualifier
This is the first type I was able to compile cereal::make_array
Not tested, only compiling.
The implementation is based on boost serialization

Signed-off-by: Omar Shrit <omar@shrit.me>
2020-06-30 19:13:30 +02:00
Omar Shrit 39802814e0 Change format from text to json
Signed-off-by: Omar Shrit <omar@shrit.me>
2020-06-30 19:13:30 +02:00
Omar Shrit 9154418594 Move from boost serialize to cereal in Armadillo
Signed-off-by: Omar Shrit <omar@shrit.me>
2020-06-30 19:13:30 +02:00
Omar Shrit b60c27d281 Adding core/cereal
Signed-off-by: Omar Shrit <omar@shrit.me>
2020-06-30 19:13:30 +02:00
Omar Shrit 3a8702cf22 Replace boost serialization headers by cereal
Signed-off-by: Omar Shrit <omar@shrit.me>
2020-06-30 19:13:30 +02:00
Omar Shrit a3a19e1e5a Adding an array wrapper for cereal to have make_array
Signed-off-by: Omar Shrit <omar@shrit.me>
2020-06-30 19:13:30 +02:00
Omar Shrit 9c3f824eab The last one boost::serialization --> cereal
Signed-off-by: Omar Shrit <omar@shrit.me>
2020-06-30 19:13:30 +02:00
Omar Shrit c73ff38557 boost::serialization --> cereal tests/
Signed-off-by: Omar Shrit <omar@shrit.me>
2020-06-30 19:13:30 +02:00
Omar Shrit 5bd3cd74d1 boost::serialization --> cereal bindings/
Signed-off-by: Omar Shrit <omar@shrit.me>
2020-06-30 19:13:30 +02:00
Omar Shrit d9f50304f4 boost::serialization --> cereal core/data core/util
Signed-off-by: Omar Shrit <omar@shrit.me>
2020-06-30 19:13:17 +02:00
Omar Shrit ce2a8b27c7 boost::serialization --> cereal core/tree
Signed-off-by: Omar Shrit <omar@shrit.me>
2020-06-30 19:11:44 +02:00