Yue ChangandClaude Fable 5
ede136ee4e
The optional NaN checks performed by LAPACKE front-ends computed array offsets and lengths in 32-bit lapack_int arithmetic, which overflows for large matrices (e.g. LAPACKE_dpotrf with n = lda >= 46341 overflows j*lda in LAPACKE_dtr_nancheck, leading to out-of-bounds reads and crashes). Several nancheck helpers (ge, gb, tp, tf) already cast to size_t; this applies the same treatment to the ones that were missed: - ?tr_nancheck: cast a[i+j*lda] index to size_t (also covers po/sy/he checks, i.e. the POTRF/Cholesky path) - ?_nancheck (vector): iterate by element count instead of n*inc, with size_t indexing - ?sp/?pp/?pf/?hp/?tp/?tf_nancheck: compute n*(n+1)/2 length in size_t - ?tz_nancheck: widen the part offsets to int64_t (keeping the -1 sentinel) and compute them with a widening cast Verified with UBSan: LAPACKE_str_nancheck at n = lda = 47000 previously reported signed integer overflow and crashed with SEGV at -O0; it now passes and still detects the NaN. Old and new code produce identical results across 1907 enumerated small-size cases (all layouts, uplo, diag, shapes and NaN positions for tr/tz/vector/packed variants). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
85 lines
3.6 KiB
C
85 lines
3.6 KiB
C
/*****************************************************************************
|
|
Copyright (c) 2014, Intel Corp.
|
|
All rights reserved.
|
|
|
|
Redistribution and use in source and binary forms, with or without
|
|
modification, are permitted provided that the following conditions are met:
|
|
|
|
* Redistributions of source code must retain the above copyright notice,
|
|
this list of conditions and the following disclaimer.
|
|
* Redistributions in binary form must reproduce the above copyright
|
|
notice, this list of conditions and the following disclaimer in the
|
|
documentation and/or other materials provided with the distribution.
|
|
* Neither the name of Intel Corporation nor the names of its contributors
|
|
may be used to endorse or promote products derived from this software
|
|
without specific prior written permission.
|
|
|
|
THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
|
|
AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
|
|
IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
|
|
ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE
|
|
LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
|
|
CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
|
|
SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
|
|
INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
|
|
CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
|
|
ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
|
|
THE POSSIBILITY OF SUCH DAMAGE.
|
|
******************************************************************************
|
|
* Contents: Native C interface to LAPACK utility function
|
|
* Author: Intel Corporation
|
|
*****************************************************************************/
|
|
#include "lapacke_utils.h"
|
|
|
|
/* Check a matrix for NaN entries. */
|
|
|
|
lapack_logical LAPACKE_ctr_nancheck( int matrix_layout, char uplo, char diag,
|
|
lapack_int n,
|
|
const lapack_complex_float *a,
|
|
lapack_int lda )
|
|
{
|
|
lapack_int i, j, st;
|
|
lapack_logical colmaj, lower, unit;
|
|
|
|
if( a == NULL ) return (lapack_logical) 0;
|
|
|
|
colmaj = ( matrix_layout == LAPACK_COL_MAJOR );
|
|
lower = LAPACKE_lsame( uplo, 'l' );
|
|
unit = LAPACKE_lsame( diag, 'u' );
|
|
|
|
if( ( !colmaj && ( matrix_layout != LAPACK_ROW_MAJOR ) ) ||
|
|
( !lower && !LAPACKE_lsame( uplo, 'u' ) ) ||
|
|
( !unit && !LAPACKE_lsame( diag, 'n' ) ) ) {
|
|
/* Just exit if any of input parameters are wrong */
|
|
return (lapack_logical) 0;
|
|
}
|
|
if( unit ) {
|
|
/* If unit, then don't touch diagonal, start from 1st column or row */
|
|
st = 1;
|
|
} else {
|
|
/* If non-unit, then check diagonal also, starting from [0,0] */
|
|
st = 0;
|
|
}
|
|
|
|
/* Since col_major upper and row_major lower are equal,
|
|
* and col_major lower and row_major upper are equals too -
|
|
* using one code for equal cases. XOR( colmaj, upper )
|
|
*/
|
|
if( ( colmaj || lower ) && !( colmaj && lower ) ) {
|
|
for( j = st; j < n; j++ ) {
|
|
for( i = 0; i < MIN( j+1-st, lda ); i++ ) {
|
|
if( LAPACK_CISNAN( a[i+(size_t)j*lda] ) )
|
|
return (lapack_logical) 1;
|
|
}
|
|
}
|
|
} else {
|
|
for( j = 0; j < n-st; j++ ) {
|
|
for( i = j+st; i < MIN( n, lda ); i++ ) {
|
|
if( LAPACK_CISNAN( a[i+(size_t)j*lda] ) )
|
|
return (lapack_logical) 1;
|
|
}
|
|
}
|
|
}
|
|
return (lapack_logical) 0;
|
|
}
|