From 9fcd2f3449345ea13f3c1d95daff00420a123b2d Mon Sep 17 00:00:00 2001 From: conrad Date: Thu, 17 Jul 2025 17:06:22 +1000 Subject: [PATCH] add TODOs --- include/armadillo_bits/op_pinv_meat.hpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/armadillo_bits/op_pinv_meat.hpp b/include/armadillo_bits/op_pinv_meat.hpp index 23c5fa08..8a84394f 100644 --- a/include/armadillo_bits/op_pinv_meat.hpp +++ b/include/armadillo_bits/op_pinv_meat.hpp @@ -192,6 +192,7 @@ op_pinv::apply_sym(Mat& out, const Mat& A, typename get_pod_type::re Col< T> eigval; Mat eigvec; + // TODO: refactor to avoid dc if matrix size too large const bool status = ((method_id == uword(0)) || (method_id == uword(2))) ? auxlib::eig_sym_dc(eigval, eigvec, A) : auxlib::eig_sym(eigval, eigvec, A); if(status == false) { return false; } @@ -256,6 +257,7 @@ op_pinv::apply_gen(Mat& out, Mat& A, typename get_pod_type::result t if(n_cols > n_rows) { A = trans(A); } + // TODO: refactor to avoid dc if matrix size too large const bool status = ((method_id == uword(0)) || (method_id == uword(2))) ? auxlib::svd_dc_econ(U, s, V, A) : auxlib::svd_econ(U, s, V, A, 'b'); if(status == false) { return false; }