From cc7de6b5f0965168f3ecbe968f06e50f2f1a6eec Mon Sep 17 00:00:00 2001
From: conrad <conrad@localhost.localdomain>
Date: Thu, 23 Dec 2021 14:48:10 +1000
Subject: [PATCH] enusre only cx hermitian matrices are optimised

---
 include/armadillo_bits/op_pinv_meat.hpp | 3 ++-
 include/armadillo_bits/op_rank_meat.hpp | 2 +-
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/include/armadillo_bits/op_pinv_meat.hpp b/include/armadillo_bits/op_pinv_meat.hpp
index a781e56f..e2a96c97 100644
--- a/include/armadillo_bits/op_pinv_meat.hpp
+++ b/include/armadillo_bits/op_pinv_meat.hpp
@@ -86,7 +86,7 @@ op_pinv::apply_direct(Mat<typename T1::elem_type>& out, const Base<typename T1::
       
       sympd_helper::analyse_matrix(is_approx_sym, is_approx_sympd, A);
       
-      do_sym   = is_approx_sym;
+      do_sym   = (is_cx<eT>::no) ? (is_approx_sym) : (is_approx_sym && is_approx_sympd);
       do_sympd = is_approx_sympd && (tol == T(0)) && (method_id == uword(0));
       }
   #else
@@ -114,6 +114,7 @@ op_pinv::apply_direct(Mat<typename T1::elem_type>& out, const Base<typename T1::
     {
     arma_extra_debug_print("op_pinv: detected symmetric matrix");
     
+    
     return op_pinv::apply_sym(out, A, tol, method_id);
     }
   
diff --git a/include/armadillo_bits/op_rank_meat.hpp b/include/armadillo_bits/op_rank_meat.hpp
index 8f18709a..74ad922d 100644
--- a/include/armadillo_bits/op_rank_meat.hpp
+++ b/include/armadillo_bits/op_rank_meat.hpp
@@ -52,7 +52,7 @@ op_rank::apply(uword& out, const Base<typename T1::elem_type,T1>& expr, const ty
       
       sympd_helper::analyse_matrix(is_approx_sym, is_approx_sympd, A);
       
-      do_sym = is_approx_sym;
+      do_sym = (is_cx<eT>::no) ? (is_approx_sym) : (is_approx_sym && is_approx_sympd);
       }
   #else
     const bool do_sym = false;