From edb8c9baa6b6b9dfd16e25d0efce92489bbcb33c Mon Sep 17 00:00:00 2001 From: conrad Date: Fri, 19 Nov 2021 11:42:19 +1000 Subject: [PATCH] add TODO --- include/armadillo_bits/op_inv_meat.hpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/armadillo_bits/op_inv_meat.hpp b/include/armadillo_bits/op_inv_meat.hpp index e8af684c..5edd6644 100644 --- a/include/armadillo_bits/op_inv_meat.hpp +++ b/include/armadillo_bits/op_inv_meat.hpp @@ -318,6 +318,9 @@ op_inv_sympd::apply_direct(Mat& out, const Base::yes) { arma_debug_warn_level(1, "inv_sympd(): given matrix is not hermitian"); } } + // TODO: for complex matrices, warn if imaginary components of diagonal are greater than eps? + // TODO: however, this may be inconsistent with the check in Base::is_sympd(), which uses data derived threshold + if((out.n_rows <= 4) && is_cx::no) { Mat tmp(out.n_rows, out.n_rows, arma_nozeros_indicator());