diff --git a/.github/workflows/jobs.yml b/.github/workflows/jobs.yml index dd2d4d4..c3683e4 100644 --- a/.github/workflows/jobs.yml +++ b/.github/workflows/jobs.yml @@ -176,7 +176,7 @@ jobs: - name: Install brew dependencies run: | brew reinstall gcc # brings gfortran on path - brew install cmake mpich eigen + brew install cmake open-mpi eigen - name: Run job run: | mkdir -p build @@ -242,7 +242,7 @@ jobs: - name: Install brew dependencies run: | brew reinstall gcc # brings gfortran on path - brew install autoconf automake libtool pkg-config mpich eigen + brew install autoconf automake libtool pkgconfig open-mpi eigen - name: Run job run: | ./bootstrap diff --git a/CHANGES b/CHANGES index e5727bd..f884df6 100644 --- a/CHANGES +++ b/CHANGES @@ -1,5 +1,9 @@ arpack-ng - next +[ Evan Biederstedt ] +* Fix warnings for "Warning: Obsolescent feature: Old-style character length at (1)", compiled with `gfortran-16 -fpic -g -O2 -Wall -pedantic -mtune=native` +* Changed GitHub CI workflows for Mac OS to use 'brew install open-mpi', as `mpich` fails. + [ Theodore Chang ] * CMake: Improve dependency linking, bump up minimum C++ standard version. diff --git a/PARPACK/UTIL/BLACS/pdmout.f b/PARPACK/UTIL/BLACS/pdmout.f index d06995e..822ee4d 100644 --- a/PARPACK/UTIL/BLACS/pdmout.f +++ b/PARPACK/UTIL/BLACS/pdmout.f @@ -34,7 +34,7 @@ * ... * ... SPECIFICATIONS FOR LOCAL VARIABLES * .. Scalar Arguments .. - CHARACTER*( * ) IFMT + CHARACTER IFMT*( * ) INTEGER IDIGIT, LDA, LOUT, M, N * .. * .. Array Arguments .. diff --git a/PARPACK/UTIL/BLACS/pdvout.f b/PARPACK/UTIL/BLACS/pdvout.f index d69668a..131b068 100644 --- a/PARPACK/UTIL/BLACS/pdvout.f +++ b/PARPACK/UTIL/BLACS/pdvout.f @@ -31,7 +31,7 @@ * ... * ... SPECIFICATIONS FOR LOCAL VARIABLES * .. Scalar Arguments .. - CHARACTER*( * ) IFMT + CHARACTER IFMT*( * ) INTEGER IDIGIT, LOUT, N * .. * .. Array Arguments .. diff --git a/PARPACK/UTIL/BLACS/psmout.f b/PARPACK/UTIL/BLACS/psmout.f index 2ed1377..c87d148 100644 --- a/PARPACK/UTIL/BLACS/psmout.f +++ b/PARPACK/UTIL/BLACS/psmout.f @@ -34,7 +34,7 @@ * ... * ... SPECIFICATIONS FOR LOCAL VARIABLES * .. Scalar Arguments .. - CHARACTER*( * ) IFMT + CHARACTER IFMT*( * ) INTEGER IDIGIT, LDA, LOUT, M, N * .. * .. Array Arguments .. diff --git a/PARPACK/UTIL/BLACS/psvout.f b/PARPACK/UTIL/BLACS/psvout.f index efc3171..24eb474 100644 --- a/PARPACK/UTIL/BLACS/psvout.f +++ b/PARPACK/UTIL/BLACS/psvout.f @@ -31,7 +31,7 @@ * ... * ... SPECIFICATIONS FOR LOCAL VARIABLES * .. Scalar Arguments .. - CHARACTER*( * ) IFMT + CHARACTER IFMT*( * ) INTEGER IDIGIT, LOUT, N * .. * .. Array Arguments .. diff --git a/PARPACK/UTIL/MPI/pdmout.f b/PARPACK/UTIL/MPI/pdmout.f index 8785f6c..570b266 100644 --- a/PARPACK/UTIL/MPI/pdmout.f +++ b/PARPACK/UTIL/MPI/pdmout.f @@ -33,7 +33,7 @@ * ... * ... SPECIFICATIONS FOR LOCAL VARIABLES * .. Scalar Arguments .. - CHARACTER*( * ) IFMT + CHARACTER IFMT*( * ) INTEGER IDIGIT, LDA, LOUT, M, N * .. * .. Array Arguments .. diff --git a/PARPACK/UTIL/MPI/pdvout.f b/PARPACK/UTIL/MPI/pdvout.f index 355e5ce..ca867a2 100644 --- a/PARPACK/UTIL/MPI/pdvout.f +++ b/PARPACK/UTIL/MPI/pdvout.f @@ -30,7 +30,7 @@ * ... * ... SPECIFICATIONS FOR LOCAL VARIABLES * .. Scalar Arguments .. - CHARACTER*( * ) IFMT + CHARACTER IFMT*( * ) INTEGER IDIGIT, LOUT, N * .. * .. Array Arguments .. diff --git a/PARPACK/UTIL/MPI/psmout.f b/PARPACK/UTIL/MPI/psmout.f index 08dd49c..ee7fedc 100644 --- a/PARPACK/UTIL/MPI/psmout.f +++ b/PARPACK/UTIL/MPI/psmout.f @@ -33,7 +33,7 @@ * ... * ... SPECIFICATIONS FOR LOCAL VARIABLES * .. Scalar Arguments .. - CHARACTER*( * ) IFMT + CHARACTER IFMT*( * ) INTEGER IDIGIT, LDA, LOUT, M, N * .. * .. Array Arguments .. diff --git a/PARPACK/UTIL/MPI/psvout.f b/PARPACK/UTIL/MPI/psvout.f index d6e7bfc..377e283 100644 --- a/PARPACK/UTIL/MPI/psvout.f +++ b/PARPACK/UTIL/MPI/psvout.f @@ -30,7 +30,7 @@ * ... * ... SPECIFICATIONS FOR LOCAL VARIABLES * .. Scalar Arguments .. - CHARACTER*( * ) IFMT + CHARACTER IFMT*( * ) INTEGER IDIGIT, LOUT, N * .. * .. Array Arguments .. diff --git a/TESTS/mmio.f b/TESTS/mmio.f index 1be49f4..135ba86 100644 --- a/TESTS/mmio.f +++ b/TESTS/mmio.f @@ -641,7 +641,7 @@ c integer indx(*) integer jndx(*) integer i, rows, cols, nnz, nnzreq, ounit - character*(*)rep,field,symm + character rep*(*),field*(*),symm*(*) c c Test input qualifiers: c @@ -753,7 +753,7 @@ c Convert uppercase letters to lowercase letters in string with c starting position pos and length len. cccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccc integer pos, len - character*(*) string + character string*(*) character lcase*26, ucase*26 save lcase,ucase @@ -780,8 +780,8 @@ c c 30-Oct-96 Bug fix: fixed non-ansi zero stringlength cccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccc integer slen, start, next, begin, space, wlen - character*(*) word - character*(*) string + character word*(*) + character string*(*) begin = start do 5 i=start,slen @@ -809,7 +809,7 @@ c Countwd counts the number of words in string starting c at position start. On return, count is the number of words. c 30-Oct-96 Routine added cccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccccc - character*(*) string + character string*(*) integer slen, start, next, wordlength, count character tmp2*2 diff --git a/UTIL/dmout.f b/UTIL/dmout.f index 9955ba5..4713b29 100644 --- a/UTIL/dmout.f +++ b/UTIL/dmout.f @@ -24,7 +24,7 @@ * ... * ... SPECIFICATIONS FOR LOCAL VARIABLES * .. Scalar Arguments .. - CHARACTER*( * ) IFMT + CHARACTER IFMT*( * ) INTEGER IDIGIT, LDA, LOUT, M, N * .. * .. Array Arguments .. diff --git a/UTIL/dvout.f b/UTIL/dvout.f index 76c46b2..c6d7110 100644 --- a/UTIL/dvout.f +++ b/UTIL/dvout.f @@ -21,7 +21,7 @@ * ... * ... SPECIFICATIONS FOR LOCAL VARIABLES * .. Scalar Arguments .. - CHARACTER*( * ) IFMT + CHARACTER IFMT*( * ) INTEGER IDIGIT, LOUT, N * .. * .. Array Arguments ..