Laurent Rineau
d33d71a4e0
Merge pull request #7125 from MaelRL/PMP-flip_criterion-GF
...
Modify flipping criteria in PMP::isotropic_remeshing and PMP::refine
2023-02-10 15:40:49 +01:00
Sébastien Loriot
7e38151479
add documentation for remeshing functions + update API
...
code has not been updated yet
2023-02-09 16:31:00 +01:00
Andreas Fabri
3d379c3988
Use CGAL_USE()
2023-02-09 10:29:08 +00:00
Andreas Fabri
ff61b977af
Add fix in PMP::snap()
2023-02-09 10:01:06 +00:00
Sébastien Loriot
9242a810c4
Merge remote-tracking branch 'cgal/master' into Region_growing-revision-soesau
2023-02-07 11:31:55 +01:00
Sébastien Loriot
dbccebf7df
clean up doc and API of new property maps
2023-02-06 18:32:41 +01:00
hoskillua
ec4312695a
remove unused var + minor change
2023-02-02 12:23:50 +02:00
hoskillua
fcbc89b503
added comments for clarity
2023-02-02 12:07:20 +02:00
Laurent Rineau
1e4165f1db
Merge pull request #7184 from afabri/PMP-longest_border-GF
...
PMP: Make longest_border() extract_boundary_cycles() coherent
2023-02-02 10:58:25 +01:00
hoskillua
e71fcd899a
removed unused enum
2023-02-02 02:15:34 +02:00
Sébastien Loriot
9e137bca24
Merge 'cgal/master'
2023-01-31 12:26:55 +01:00
Sébastien Loriot
6a7e7d267e
fix link
2023-01-31 11:56:48 +01:00
hoskillua
bd5d9df950
fix
...
some functions were passing x to interpolated_corrected_gaussian_curvature_measure_face() when it was not needed (and causes a compilation error for 1 vertex)
2023-01-31 11:57:00 +02:00
hoskillua
eef0f5fd80
removed unused parameter
2023-01-31 11:23:46 +02:00
hoskillua
2ccabc9289
renaming files
2023-01-29 09:39:39 +02:00
hoskillua
4e669b79a7
conversion warnings
2023-01-29 06:26:16 +02:00
hoskillua
8d2043d0aa
renaming
...
mostly to pass the max path error
2023-01-28 15:54:35 +02:00
Laurent Rineau
5f8930db8c
Merge branch '5.5.x-branch'
...
# Conflicts:
# Convex_hull_2/test/Convex_hull_2/ch_test_CH.cpp
# Convex_hull_2/test/Convex_hull_2/ch_test_SC.cpp
# Convex_hull_2/test/Convex_hull_2/ch_test_SH.cpp
# Convex_hull_2/test/Convex_hull_2/ch_test_SS.cpp
# Straight_skeleton_2/include/CGAL/constructions/Straight_skeleton_cons_ftC2.h
# Straight_skeleton_2/include/CGAL/predicates/Straight_skeleton_pred_ftC2.h
2023-01-27 21:16:14 +01:00
Laurent Rineau
122141dda6
Merge pull request #7076 from MaelRL/PMP-Improve_normal_doc-GF
...
Improve documentation of PMP::compute_vertex_normal()
2023-01-27 21:02:24 +01:00
Laurent Rineau
36bc3d1154
Merge pull request #7126 from sloriot/PMP-repair_si_no_smooth_by_default
...
Make smooth an option that is OFF by default
2023-01-27 20:52:29 +01:00
Laurent Rineau
119cea4add
Merge pull request #7127 from sloriot/PMP-cond_assert
...
Conditional assertions
2023-01-27 20:52:27 +01:00
Sébastien Loriot
ee246c87c5
fix function name and add missing constructor
2023-01-25 17:08:27 +01:00
hoskillua
6f2f912c4d
minor fix
2023-01-24 18:41:25 +02:00
hoskillua
7303c7401e
move function + minor func doc fix
2023-01-24 14:42:39 +02:00
hoskillua
864eb9be4e
Merge remote-tracking branch 'cgal-fork/gsoc2022' into gsoc2022-ICC-hoskillua
2023-01-24 14:38:02 +02:00
hoskillua
999b475e4c
tests (incomplete) + minor typename fix
...
still not passing single vertex on polyhedron due to a problem with vertex normal map
2023-01-24 14:08:02 +02:00
Andreas Fabri
35ffe120e1
fix merge conflict
2023-01-24 10:41:22 +00:00
Sébastien Loriot
69c21bccc3
Merge 'master'
2023-01-24 11:29:48 +01:00
Sébastien Loriot
69610f6958
move function
2023-01-24 11:15:04 +01:00
Sébastien Loriot
50ba18725c
fix typename usage
2023-01-24 11:10:29 +01:00
hoskillua
483e8b8e50
User manual + add example file for 1 vertex curvature
2023-01-24 08:44:09 +02:00
hoskillua
8af5c620fa
reference documentation + minor fix
...
+ added documentation for the at_vertext curvature functions
- removed dynamically allocated pointers for storing the curvature on vertex
2023-01-23 13:49:34 +02:00
Mael
86ec9ce186
Fix indentation
2023-01-20 22:28:05 +01:00
Sébastien Loriot
cd76994056
rename property map and deprecated old name
2023-01-18 13:45:37 +01:00
Mael
d67d7cd4b6
Remove extra to_double
2023-01-18 11:15:17 +01:00
Sebastien Loriot
343735b9d7
missing return
2023-01-17 09:58:38 +01:00
Sébastien Loriot
6a7bd8b0e3
fix angle return type
2023-01-16 19:47:25 +01:00
albert-github
9c2f8ff60e
Spelling correction in respect to function / variable names
...
As indicated in #7041 (Spelling corrections) theer were still some open corrections in respect to variables / functions, these have been addressed heer.
2023-01-13 18:51:28 +01:00
Andreas Fabri
7305e1bb38
Fix typo (thank you Albert)
2023-01-12 17:29:30 +00:00
Andreas Fabri
c8b8792275
PMP: Guarantee that the longest_border() halfedge is among extract_boundary_cycles()
2023-01-12 17:01:19 +00:00
Mael
4d22c90474
Merge branch 'master' into feature/bug_documentation_spell_20221113
2023-01-04 10:06:45 +01:00
hoskillua
f6855fef22
single vertex computation
...
implemented single vertex curvature computation
compared against the whole mesh computation on both cases of no radius and with radius on some vertices
still need to add tests, documentation and an example file
2023-01-03 12:13:26 +02:00
Mael Rouxel-Labbé
5e101566fb
Remove obsolete typedefs
2023-01-02 10:34:27 +01:00
Sébastien Loriot
6e7eda918c
remove PCA version
2022-12-23 16:12:33 +01:00
Sébastien Loriot
898142d739
wrong type
2022-12-22 09:49:35 +01:00
Sébastien Loriot
f993ad50c9
conditions of inconsistenit_classification() also apply to assertions
2022-12-19 17:43:12 +01:00
Sébastien Loriot
f372bbe7c2
make smooth an option that is OFF by default
2022-12-19 14:35:16 +01:00
Mael Rouxel-Labbé
70efea3bcb
Tiny code modernization
2022-12-16 16:28:53 +01:00
Mael Rouxel-Labbé
92bd00f612
Change PMP::refine() is_flippable criterion
...
The current criterion is some kind of Delaunay ball, which might work OK
for flat regions, but can produce super thin wedges (see issue:
https://github.com/CGAL/cgal/issues/6982 ) when the mesh is not flat.
The criterion used instead is the one used in PMP::isotropic_remeshing
and PMP::remove_almost_degenerate_faces(), which is the typical angle-based
surface Delaunay criterion.
2022-12-16 16:26:43 +01:00
Mael Rouxel-Labbé
52fc2ffdd4
Change criterion used in "should_flip"
...
The criterion that takes the scalar_product of the cross products
is maybe adapted to minimize the curvature when triangulating faces,
but should_flip() is used in PMP::isotropic_remeshing, (soon) PMP::refine(),
and PMP::remove_almost_degenerate_faces(). These algorithms aim to
produce well-shaped elements. The criterion is not adapted to these
algorithms: for example, on a flat mesh the scalar product is meaningless
so it will pick the diagonal which maximizes the product of the lengths
and product of sines, but this might create very anisotropic elements
since the sine of obtuse angles is still positive.
The "new" criterion is simply the criterion used in mesh smoothing
and the typical Delaunay criterion for surfaces.
2022-12-16 16:21:46 +01:00
Laurent Rineau