Mael Rouxel-Labbé
52fc2ffdd4
Change criterion used in "should_flip"
...
The criterion that takes the scalar_product of the cross products
is maybe adapted to minimize the curvature when triangulating faces,
but should_flip() is used in PMP::isotropic_remeshing, (soon) PMP::refine(),
and PMP::remove_almost_degenerate_faces(). These algorithms aim to
produce well-shaped elements. The criterion is not adapted to these
algorithms: for example, on a flat mesh the scalar product is meaningless
so it will pick the diagonal which maximizes the product of the lengths
and product of sines, but this might create very anisotropic elements
since the sine of obtuse angles is still positive.
The "new" criterion is simply the criterion used in mesh smoothing
and the typical Delaunay criterion for surfaces.
2022-12-16 16:21:46 +01:00
Laurent Rineau
f1e1878b8d
Merge pull request #7094 from afabri/PMP_named_parameters-GF
...
PMP: Replace parameter with named parameter
2022-12-16 10:52:17 +01:00
Laurent Rineau
c419f52799
Merge pull request #7103 from sloriot/PMP-repair_si_conditional_smoothing
...
Do not apply smoothing if the CC has some degenerate faces
2022-12-14 10:39:48 +01:00
Laurent Rineau
f3e0f45054
Merge pull request #7108 from afabri/PMP-Envelope_warning-GF
...
PMP: Fix for a -Wmaybe-uninitialized
2022-12-14 10:39:45 +01:00
Andreas Fabri
39ebebdb5b
merge master
2022-12-08 16:49:09 +00:00
Sebastien Loriot
f5c41bd712
Merge pull request #7022 from MaelRL/Weights-v2.0-GF-master
...
Weights fixes (master)
2022-12-08 15:22:19 +01:00
Andreas Fabri
9159816fb4
PMP: Fix for a -Wmaybe-uninitialized
2022-12-07 08:02:35 +00:00
Andreas Fabri
1adb13edc8
Do not use deprecated functions
2022-12-06 12:34:26 +00:00
Laurent Rineau
90f6546d77
Merge pull request #7069 from sloriot/PMP-split_repair_5.5
...
Split repair
2022-12-05 13:50:25 +01:00
Laurent Rineau
42c8c4f9e1
Merge pull request #7070 from sloriot/PMP-split_repair
...
Split repair (master version)
2022-12-05 12:23:19 +01:00
Laurent Rineau
041df61a70
Merge pull request #7074 from sloriot/PMP-compatible_orientation_missing_option
...
CGAL::PMP::compatible_orientations: add missing option
2022-12-05 12:22:09 +01:00
Laurent Rineau
17fd74e432
Merge pull request #7090 from afabri/PMP-assertion_bug-GF
...
Polygon Mesh Processing: Fix CGAL_assertion_msg
2022-12-05 12:21:51 +01:00
Laurent Rineau
33cffd9c26
Merge pull request #7074 from sloriot/PMP-compatible_orientation_missing_option
...
CGAL::PMP::compatible_orientations: add missing option
2022-12-05 11:57:16 +01:00
Laurent Rineau
ead1795d85
Merge pull request #7090 from afabri/PMP-assertion_bug-GF
...
Polygon Mesh Processing: Fix CGAL_assertion_msg
2022-12-05 11:57:06 +01:00
Sébastien Loriot
ffc20ffbd1
do not apply smoothing if the CC has some degenerate faces
2022-12-01 04:33:53 +01:00
Andreas Fabri
2b26b8dd31
Don't use deprecated code in examples
2022-11-30 07:58:02 +00:00
Andreas Fabri
a2e599b23d
Fix typos
2022-11-29 16:55:43 +00:00
Andreas Fabri
63ffb5e82f
Do the same for the other hole filling functions
2022-11-29 14:49:59 +00:00
Sébastien Loriot
352860ffa4
one solution for the return type
2022-11-29 14:24:11 +01:00
Sébastien Loriot
8708d348dd
remove extra _t
2022-11-29 13:58:40 +01:00
Andreas Fabri
7babddf443
PMP: Replace parameter with named parameter
2022-11-29 12:45:47 +00:00
Sébastien Loriot
128cc719fe
missing }
2022-11-29 11:14:22 +01:00
Andreas Fabri
6572a8fb58
It's a warning not an assertion
2022-11-28 14:39:20 +00:00
Andreas Fabri
0b56297ea2
Polygon Mesh Processing: Fix CGAL_assertion_msg
2022-11-28 14:05:59 +00:00
Laurent Rineau
33a7ae51d4
Merge pull request #7068 from sloriot/PMP-repair_si_fix_include
...
Fix include
2022-11-25 10:14:57 +01:00
Sébastien Loriot
75e08a9736
typo
2022-11-23 18:36:43 +01:00
Sébastien Loriot
876e69aeb4
add missing option that make the function almost useless if not present
2022-11-23 18:18:09 +01:00
Sébastien Loriot
550d86cc0d
update doc
2022-11-22 10:48:27 +01:00
Sébastien Loriot
1520ac93e4
Merge branch 'sloriot/PMP-split_repair_5.5' into master
2022-11-22 10:38:00 +01:00
Sébastien Loriot
5a992f60a4
split repair
2022-11-22 10:31:34 +01:00
Sébastien Loriot
718214bf4f
fix include
2022-11-21 19:26:35 +01:00
Laurent Rineau
04c51a1034
Merge pull request #7034 from sloriot/PMP-coref_open_mesh_case_fix
...
Fix inconsistency check
2022-11-15 17:01:26 +01:00
Laurent Rineau
868793754b
Merge pull request #7034 from sloriot/PMP-coref_open_mesh_case_fix
...
Fix inconsistency check
2022-11-15 17:00:45 +01:00
Laurent Rineau
48811a4622
Merge pull request #7034 from sloriot/PMP-coref_open_mesh_case_fix
...
Fix inconsistency check
2022-11-15 16:59:27 +01:00
Sébastien Loriot
cd4de51a40
fix inconsistency check
2022-11-09 18:17:31 +01:00
Mael Rouxel-Labbé
83b0b0bdef
Merge branch 'Weights-v2.0-GF-5.5.x' into Weights-v2.0-GF-master
2022-11-07 14:23:29 +01:00
Mael Rouxel-Labbé
7564b761ac
Merge branch 'Weights-v2.0-GF' into Weights-v2.0-GF-5.5.x
2022-11-07 14:11:10 +01:00
Laurent Rineau
987391d8ee
Merge pull request #6930 from MaelRL/BGL-Use_is_valid_descriptor-GF
...
BGL graph validity improvements
2022-11-07 10:08:34 +01:00
Laurent Rineau
5239daab19
Merge pull request #7010 from afabri/PMP-BGL-shrunk-GF
2022-11-04 10:27:19 +01:00
Andreas Fabri
f605c347ae
Fixed typo: shrinked -> shrunk
2022-11-04 10:01:53 +01:00
Laurent Rineau
8e8153c0ac
Merge pull request #6871 from afabri/CGAL_assertions-GF
...
CGAL: No longer per package assertions
2022-11-03 09:44:48 +01:00
Laurent Rineau
56453b7e9f
Merge pull request #6953 from afabri/CGAL-Wunused-but-set-variable-GF
...
Address -Wunused-but-set-variable
2022-11-03 09:44:45 +01:00
Mael Rouxel-Labbé
91336eb213
Use modern C++
2022-10-20 17:28:00 +02:00
Mael Rouxel-Labbé
19f847a74b
Fix API of cotan functor in shape smoothing
2022-10-20 17:27:39 +02:00
Mael Rouxel-Labbé
6cd5c24f70
Pass traits to the secure Vor-weighted cotan functor
2022-10-20 17:27:26 +02:00
Mael Rouxel-Labbé
9ab7e1ed7f
Misc minor code cleaning
2022-10-20 17:21:43 +02:00
Andreas Fabri
c04dceb71d
Merge master
2022-10-14 14:40:58 +01:00
Laurent Rineau
90e2a876e2
Merge pull request #6931 from MaelRL/PMP-remove_degen_fix_bad_removal-GF
...
Purge to-be-border halfedges from edges-to-collapse sets
2022-10-13 15:17:41 +02:00
Laurent Rineau
b232f4bcfd
Merge pull request #6942 from sloriot/CGAL-header_clean_up
...
Clean up in headers
2022-10-13 15:17:39 +02:00
Laurent Rineau
2b5b4be5d4
Merge pull request #6931 from MaelRL/PMP-remove_degen_fix_bad_removal-GF
...
Purge to-be-border halfedges from edges-to-collapse sets
2022-10-13 15:15:19 +02:00