## Summary of Changes
While trying to remove caps, `PMP::remove_almost_degenerate_faces()`
does a Delaunay-like check before allowing the edge flip. Unfortunately,
the current criterion (see https://github.com/CGAL/cgal/pull/7125) can
prevent some edge flips that would resolve a cap because sometimes this
Delaunay-like criterion can prefer a cap if it is balanced by a very
small angle on the other side. Then you have alpha + beta < 180 and
you're stuck with the cap, but maybe you would have liked to flip still
because the largest angles created by a flip would be e.g. 120 and 120,
which is not that bad.
However in this function, we are maybe not so interested in having
nicely shaped elements as much as we are trying to remove the worst
elements. So this PR tries to improve the worst cap angle instead, by
checking only (and greedily) if we do not create a worse cap angle when
we flip.
This produces better results for the cases that were problematic with
alpha + beta < 180
## 1
## 2
## 3
## Release Management
* Affected package(s): `PMP`
* Issue(s) solved (if any):
* Feature/Small Feature (if any): -
* License and copyright ownership: no change
## Summary of Changes
This PR fixes various typos across multiple packages. The changes
include:
* **Variable Names:** Corrected local variable names (e.g.,
`list_lenght` → `list_length`, `inital_nb_pts` → `initial_nb_pts`) in
CMake scripts and C++ headers.
* **Header Guards:** Fixed a typo in the header guard for
`Edge_length_cost.h` to match the filename.
* **Documentation & Comments:** Fixed spelling errors in comments,
string literals, and documentation files (e.g., `dimensionnal` →
`dimensional`, `explicitelty` → `explicitly`).
## Release Management
* Affected package(s): Installation, Point_set_3,
Polygon_mesh_processing, Surface_mesh_simplification, SMDS_3,
STL_Extension, Stream_support, TDS_2, Triangulation_2, Triangulation_3
* Issue(s) solved (if any):
* Feature/Small Feature (if any):
* Link to compiled documentation (obligatory for small feature):
* License and copyright ownership:
This PR fixes multiple instances of the doubled word "the" (e.g., "the
the") found in various header files, documentation, and comments.
No code logic is changed; this is purely a documentation and comment
cleanup to improve readability.
## Summary of Changes
Avoid computing them when they are known.
* Normals are only used for estimating the angle between neighbor faces.
PCA is used to estimate the plane.
* sorting should be reusing the triangulation of faces that is already
done in regions (pass the internal map to `sort()` for exemple). PCA is
also used here to estimate the flatness score of a face in its
neighborhood
* About sorting: I'm not sure it wouldn't be a better idea to simply
sort using the area of the faces and ignore flatness of the
neighborhood.
## Release Management
* Affected package(s): `Shape_detection`
* small feature:
[Pass_face_normals_for_region_growing](https://cgalwiki.geometryfactory.com/CGAL/Members/wiki/Features/Small_Features/Pass_face_normals_for_region_growing)
* Issue(s) solved (if any):
## Summary of Changes
Tests for triangulate_hole_Polyhedron_3_no_delaunay_test and
triangulate_hole_Polyhedron_3_test were also added in absence of Eigen3
causing the testsuite to abort
## Release Management
* Affected package(s): PMP
Fix case of non triangular faces having vertices tangent to the
clip/refine plane
+ clip volume with coplanar faces
## TODO:
- [x] clean up and rebase
- [x] add test cases
- [x] add comments in the code
checking with num_halfedges(tm) means this only applies
to something like union of triangular connected components.
And if we change to counting the number of border halfedges,
then we might as well just rely on the O(1) dynamic property map.
Sébastien Loriot