Commit Graph
2086 Commits
Author SHA1 Message Date
Laurent Rineau cd032f05fc Do not store const& to the function/functor by copy by value
However, one cannot store a function type directly, but only *pointers* to
function types. So I used Boost MPL to discriminate between function types
and other callable (such as lambdas or functors, that can be copied).
2018-05-15 15:13:05 +02:00
Laurent Rineau 301181ca53 Fix compilation bug with CGAL_MESH_3_PROTECTION_DEBUG 2018-05-15 15:13:05 +02:00
Laurent Rineau c616f66811 Use static_evaluate 2018-05-15 15:13:05 +02:00
Laurent Rineau ae0b45b79f Fix a compilation bug if Mesh_3 and Mesh_2 are both used
The conflict is withing the Boost parameters defined for Lloyd 2D and
Lloyd 3D.
2018-05-15 15:13:05 +02:00
Laurent Rineau a140ed004c Remove the const bool = true from the function wrappers 2018-05-15 15:13:04 +02:00
Laurent Rineau 30ff350986 Deprecate Implicit_mesh_domain_3 as well 2018-05-15 15:13:04 +02:00
Laurent Rineau f0233cfbf7 Remove the domain classes deprecated since CGAL-4.5.
Mael talked about that in his review.
2018-05-15 15:13:04 +02:00
Laurent Rineau ae255e248f Remove trivial, useless, buggy documentation comments 2018-05-15 14:56:24 +02:00
Laurent Rineau b61cef82dd Wording
See Mael's comment:
https://github.com/CGAL/cgal/pull/2739#discussion_r175448829
2018-05-15 14:56:24 +02:00
Laurent Rineau 0cacf1a1bb Document where the geometric objects come from (from BGT)
See Mael's comment:
https://github.com/CGAL/cgal/pull/2739#discussion_r175414307
2018-05-15 14:56:23 +02:00
Laurent Rineau a40cad5291 Remove an unused template parameter 2018-05-15 14:56:23 +02:00
Laurent Rineau 5a38837588 fixup! Force nodes on the edges of the cube to be terminal nodes 2018-05-15 14:56:23 +02:00
Laurent Rineau d91929a539 Force nodes on the edges of the cube to be terminal nodes 2018-05-15 14:56:23 +02:00
Laurent Rineau f362ecd516 Support image offsets in polylines_to_protect 2018-05-15 14:56:23 +02:00
Laurent Rineau a09757b775 Fix compilation in C++03 2018-05-15 14:56:23 +02:00
Laurent Rineau c20f0bc843 result_type is used by polylines_to_protect() 2018-05-15 14:56:23 +02:00
Laurent Rineau a76e43de94 Handle the image offset 2018-05-15 14:56:23 +02:00
Laurent Rineau 82f900bcb6 Add Labeled_mesh_domain_3<K>::create_labeled_image_mesh_domain
... and deprecate `CGAL::Labeled_image_mesh_domain_3`.
2018-05-15 14:56:22 +02:00
Laurent Rineau 9126b7aa65 Use boost/shared_ptr.hpp to re-enable move semantic 2018-05-15 14:56:22 +02:00
Laurent Rineau db224d2998 Fix the code when Surface_patch_index is not std::pair<int,int> 2018-05-15 14:56:22 +02:00
Laurent Rineau 1dfbb84bf0 Add Labeled_mesh_domain_3<K>::create_gray_image_mesh_domain
... and deprecate `CGAL::Gray_image_mesh_domain_3`.
2018-05-15 14:56:22 +02:00
Laurent Rineau f0ad9b4872 Correct use of CGAL_NO_DEPRECATED_CODE 2018-05-15 14:56:22 +02:00
Laurent Rineau e687db7b61 Missing #include 2018-05-15 14:56:22 +02:00
Laurent Rineau c3de61a1d9 Use <boost/noncopyable.hpp> instead of our home-made solution 2018-05-15 14:56:22 +02:00
Laurent Rineau 87066b93a1 Rename a function for readability 2018-05-15 14:56:22 +02:00
Laurent Rineau a2a5c6ed6a Cleaning of impl. details in <CGAL/Mesh_3/Image_to_labeled_function_wrapper.h>
Now that wrapper class:
 - uses `std::function`,
 - is not longer templated by the kernel,
 - or by the image type.
2018-05-15 14:56:22 +02:00
Laurent Rineau 0d839ce60a Correct usage of Boost Parameters 2018-05-15 14:56:21 +02:00
Laurent Rineau 8b25761094 Add a constructor using Boost Parameters 2018-05-15 14:56:21 +02:00
Laurent Rineau 0400eb6c4b Cleanup included header for Boost Parameters 2018-05-15 14:56:21 +02:00
Laurent Rineau fd1a788851 Replace Default by the real type default 2018-05-15 14:56:21 +02:00
Laurent Rineau 85d9e02cc3 Call iso_cuboid in the Impl_details base class 2018-05-15 14:56:21 +02:00
Laurent Rineau 91b6dc3b13 Add Construct_surface_patch_index to the Impl_details 2018-05-15 14:56:21 +02:00
Laurent Rineau 7e9165d78a WIP: Change the template parameters of Labeled_image_mesh_domain_3 (TODO)
TODO: document the changes, once that is over.
2018-05-15 14:56:21 +02:00
Laurent Rineau cbcad49920 Use CGAL::cpp11::function to store functors
and at the same time the constructors logic is factorized in the
constructor of a base class.
2018-05-15 14:56:21 +02:00
Laurent Rineau 1a3c4436ae WIP: allow to change the Surface_patch_index type 2018-05-15 14:56:21 +02:00
Laurent Rineau 79829ffb99 Move Index_generator to another header 2018-05-15 14:56:21 +02:00
Laurent Rineau c751c1fc39 Rename the file 2018-05-15 14:56:21 +02:00
Laurent Rineau 9655043e69 Add debug instructions 2018-05-15 14:56:21 +02:00
Laurent Rineau c19c84a022 Fix a line of code that was never tested 2018-05-15 14:56:21 +02:00
Laurent Rineau 2a66790614 Fix a bug
and add assertions. The assertions use lambda expression to display useful
information.
2018-05-15 14:56:21 +02:00
Laurent Rineau 569b823cd5 Protection of triple lines of the bbox for scalar images
Now that work. I have to work a bit on the precision of the approximation.
2018-05-15 14:56:20 +02:00
Laurent Rineau 1d5e9e9150 WIP: implementation for scalar image
... tested only on segmented images!
2018-05-15 14:56:20 +02:00
Mael Rouxel-Labbé c238d7822d Moved functions's bodies 2018-05-03 14:52:52 +02:00
Mael Rouxel-Labbé d629406451 Fixed bad auto merge 2018-05-03 14:22:26 +02:00
Mael Rouxel-Labbé 7630458123 Added some safety nets on find() calls 2018-05-03 14:22:07 +02:00
Mael Rouxel-Labbé eda93364be Made register_corner() public (but undocumented) 2018-05-03 14:19:23 +02:00
Mael Rouxel-Labbé 1f9655f935 Add 'add_corner_with_context' 2018-05-03 12:53:30 +02:00
Mael Rouxel-Labbé f2171b799e Get rid of 'corners_incidence_map_'
'corners_incidence_map_' was a map<point, surface_patch_index>.
'corners_indidences_'    is a  map<Corner_index, surface_patch_index>.

The first map was only used in Lipschitz_sizing, at a place where
we are given a point and a MeshDomain::Index.

The first map was filled in 'insert_edge()', which calls
'compute_corners_incidences()' (which fills 'corners_incidences').
Thus, we can simply grab the Corner_index and use the second map
immediately.
2018-05-03 12:52:06 +02:00
Mael Rouxel-Labbé e1ffe36e7c Added 'add_corner(s)'
Allows to add 0-dimensional features which are not necessarily incident to
a 1-dimensional feature.
2018-05-03 12:51:39 +02:00
Mael Rouxel-Labbé 18c68c3047 Add 'add_corner_with_context'
and change the return type of 'register_corner()' to return the Corner_index
(no used, but just for symmetry)
2018-04-27 16:15:44 +02:00