phynexis-deps/cgal
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
114,734 Commits 3 Branches 0 Tags
ca07d1c5537b8dfd920f2feb9f77156ba7dce8dc
Commit Graph
5190 Commits
Author SHA1 Message Date
Sebastien Loriot 237f7500e9 Fix various typos in comments, documentation, and internal variables (#9230) 
## Summary of Changes

This PR fixes various typos across multiple packages. The changes
include:
* **Variable Names:** Corrected local variable names (e.g.,
`list_lenght` → `list_length`, `inital_nb_pts` → `initial_nb_pts`) in
CMake scripts and C++ headers.
* **Header Guards:** Fixed a typo in the header guard for
`Edge_length_cost.h` to match the filename.
* **Documentation & Comments:** Fixed spelling errors in comments,
string literals, and documentation files (e.g., `dimensionnal` →
`dimensional`, `explicitelty` → `explicitly`).

## Release Management

* Affected package(s): Installation, Point_set_3,
Polygon_mesh_processing, Surface_mesh_simplification, SMDS_3,
STL_Extension, Stream_support, TDS_2, Triangulation_2, Triangulation_3
* Issue(s) solved (if any):
* Feature/Small Feature (if any):
* Link to compiled documentation (obligatory for small feature):
* License and copyright ownership:
 2026-01-09 15:39:35 +01:00
Laurent Rineau 67b80065e7 Fix 'the the' typos in documentation and comments (#9221) 
This PR fixes multiple instances of the doubled word "the" (e.g., "the
the") found in various header files, documentation, and comments.

No code logic is changed; this is purely a documentation and comment
cleanup to improve readability.
 2026-01-06 15:04:35 +01:00
Attaullah Ansari f5a7fc02f6 Refactor: Fix typos in variable names and CMake variables 2026-01-04 18:04:25 +05:30
ST3-NET 5bc9483b0d Fix 'the the' doubled word typos 2026-01-01 11:17:31 +05:30
SOUHARDYA TOLA f103593626 Fix doubled word typos in documentation and comments 2025-12-31 15:40:29 +00:00
Sébastien Loriot 5b771b794f Merge remote-tracking branch 'cgal/6.1.x-branch' into 'cgal/main' 2025-12-26 12:13:31 +01:00
Sébastien Loriot d12f5ef05f restore std::array as valid triangle 2025-12-23 15:32:44 +01:00
Sébastien Loriot 69d6cdd151 Merge remote-tracking branch 'cgal/6.1.x-branch' into 'cgal/main' 2025-12-19 17:37:15 +01:00
Sébastien Loriot f5c550ef44 Merge remote-tracking branch 'cgal/6.0.x-branch' into 'cgal/6.1.x-branch' 2025-12-19 17:34:39 +01:00
Sebastien Loriot f2341c8c1b Add missing NPs documentation in split/clip (#9184) 
## Summary of Changes

Coref doesn't actually use NP::geom_traits so nothing to add.

## Release Management

* Affected package(s): `Polygon_mesh_processing`
* Issue(s) solved (if any): fix #8808
* Feature/Small Feature (if any): -
* License and copyright ownership: no change
 2025-12-19 17:29:09 +01:00
Sebastien Loriot 9d82aad77a Fix tangency of the cut plane with the vertices of the faces (#9142) 
Fix case of non triangular faces having vertices tangent to the
clip/refine plane
+ clip volume with coplanar faces



## TODO:
- [x] clean up and rebase
- [x] add test cases
- [x] add comments in the code
 2025-12-19 17:27:19 +01:00
Mael 89229ae2de Fix unused variable warning 2025-12-18 17:34:04 +01:00
Mael Rouxel-Labbé 75244517cc Be more robust to possible non-manifold configurations 2025-12-18 17:34:04 +01:00
Mael Rouxel-Labbé 6b514c1901 Better snap debug code 2025-12-18 17:34:04 +01:00
Mael Rouxel-Labbé fb259cbbd3 Better debug file name 2025-12-18 17:34:04 +01:00
Mael Rouxel-Labbé 12d71ca738 Get rid of useless general case 
checking with num_halfedges(tm) means this only applies
to something like union of triangular connected components.
And if we change to counting the number of border halfedges,
then we might as well just rely on the O(1) dynamic property map.
 2025-12-18 17:34:04 +01:00
Mael Rouxel-Labbé 17c0072f92 Fix comment 2025-12-18 17:34:04 +01:00
Mael Rouxel-Labbé f285490e33 Fix losing in_range markers when opoh is a border edge 2025-12-18 17:34:04 +01:00
Mael Rouxel-Labbé 5badbdc7d7 Make it easier to copy-paste points 2025-12-18 17:34:04 +01:00
Mael Rouxel-Labbé 171b13cfa9 Fix compilation error in debug code 2025-12-18 17:34:03 +01:00
Sébastien Loriot 47ef182fa2 Merge remote-tracking branch 'cgal/6.1.x-branch' into cgal/main 2025-12-12 17:49:36 +01:00
Sébastien Loriot 061bc2dc29 Merge remote-tracking branch 'cgal/6.0.x-branch' into cgal/6.1.x-branch 2025-12-12 17:48:59 +01:00
Mael Rouxel-Labbé 02a7da9ed3 Remove some extra space 2025-12-11 16:55:51 +01:00
Mael Rouxel-Labbé cdcf9cb8ff Complete old sentence with new NP 2025-12-11 16:55:40 +01:00
Mael Rouxel-Labbé 7b9b6160d6 Add missing NPs doc in split/clip 2025-12-11 16:55:25 +01:00
Sébastien Loriot 117dbb7af9 add one more test and fix handling of faces in the cut plane 2025-12-11 14:52:48 +01:00
Sébastien Loriot fe45084fb4 fix handling of faces inside the clip plane 2025-12-10 16:19:54 +01:00
Sébastien Loriot 20d2ce53fc skip vertices "interior" to a sequence of on the plane vertices 2025-12-10 16:19:12 +01:00
Mael Rouxel-Labbé f4c3ef092a Misc PMP doc fixes 2025-12-05 22:08:45 +01:00
Sébastien Loriot 9f2fcb5e28 Merge remote-tracking branch 'cgal/6.1.x-branch' into 'cgal/main' 2025-11-21 17:41:27 +01:00
Sebastien Loriot 85ef57ffa1 CDT_3 bug-fix: throw exceptions instead of raw crashs (like segfaults) (#9089) 
## Summary of Changes

Bug-fix for `CGAL::Conforming_constrained_Delaunay_triangulation_3` in
CGAL-6.1.

## Release Management

* Affected package(s): Constrained_triangulation_3
* License and copyright ownership: GeometryFactory
 2025-11-21 17:40:00 +01:00
Sébastien Loriot 69d17c28bb add comments 2025-11-21 11:24:12 +01:00
Sébastien Loriot 342fc2b18f one more tangency fix 2025-11-21 11:16:23 +01:00
Sébastien Loriot 583a8364c9 Merge remote-tracking branch 'cgal/6.1.x-branch' into 'cgal/main' 2025-11-20 10:29:11 +01:00
Sebastien Loriot 3ebe9203a7 Fix PMP on i386/i686 (32 bits, with the x87 FPU) (#8911) 
## Summary of Changes

Fix PMP on i386/i686 (32 bits, with the x87 FPU).

## Release Management

* Affected package(s): PMP, Number_types
 2025-11-20 10:28:31 +01:00
Sébastien Loriot 8c39b972e0 Fix tangency of the cut plane with the vertices of the faces 2025-11-19 14:16:55 +01:00
Andreas Fabri 4b89f17b42 CGAL: An Halfedge 2025-11-03 14:37:50 +00:00
Sebastien Loriot d13510bdee Add missing function doc links (#9074) 
## Summary of Changes

Fix missing links in doc.

tentative TODO:
- [ ] Check all \`.+\(.+\).*\` --> stopped at BGL
- [ ] Plenty of wrong links for the overloaded functions like <em>A
shortcut to `CGAL::draw(vd2,
Graphics_scene_options_voronoi_diagram_2{})`.</em>, which points to
`CGAL::draw(T2)`.

## Release Management

* Affected package(s): Various
* Issue(s) solved (if any): https://github.com/CGAL/cgal/issues/7839
* Feature/Small Feature (if any): -
* License and copyright ownership: no change
 2025-10-17 15:29:09 +02:00
Sébastien Loriot a84ae55fd7 Merge remote-tracking branch 'cgal/6.1.x-branch' into 'cgal/main' 2025-10-17 11:45:35 +02:00
Sébastien Loriot 3bfc5f32f5 Merge remote-tracking branch 'cgal/6.0.x-branch' into 'cgal/6.1.x-branch' 2025-10-17 11:44:39 +02:00
Sébastien Loriot 42068f6009 handle case of identical projected points 2025-10-15 11:03:16 +02:00
Sven Oesau 46ba009009 another std::size_t to int conversion 2025-10-07 10:12:03 +02:00
Sven Oesau 1a07d25cc3 fixing some conversion warnings 2025-10-06 16:06:42 +02:00
Laurent Rineau d309bc89ce fix typo "and and" 2025-09-30 17:11:15 +02:00
Sébastien Loriot 70baa7f940 Merge remote-tracking branch 'cgal/6.1.x-branch' into 'cgal/main' 2025-09-28 17:11:10 +02:00
Laurent Rineau 88f9f00922 fix warning -Wstringop-overflow 
Fix that warning, due to a copy of `tuple<Point, int, int>` in compare operators for `std::sort` and `std::unique`, in `CGAL::Polygon_mesh_processing::autorefine_impl::collect_intersections`.

```
In member function ‘std::__atomic_base<_IntTp>::__int_type std::__atomic_base<_IntTp>::fetch_add(__int_type, std::memory_order) [with _ITp = int]’,
    inlined from ‘void CGAL::Handle::incref() const’ at /mnt/testsuite/include/CGAL/Handle.h:87:29,
    inlined from ‘CGAL::Handle::Handle(const CGAL::Handle&)’ at /mnt/testsuite/include/CGAL/Handle.h:55:13,
    inlined from ‘CGAL::Lazy<CGAL::Point_3<CGAL::Simple_cartesian<CGAL::Interval_nt<false> > >, CGAL::Point_3<CGAL::Simple_cartesian<__gmp_expr<__mpq_struct [1], __mpq_struct [1]> > >, CGAL::Cartesian_converter<CGAL::Simple_cartesian<__gmp_expr<__mpq_struct [1], __mpq_struct [1]> >, CGAL::Simple_cartesian<CGAL::Interval_nt<false> >, CGAL::NT_converter<__gmp_expr<__mpq_struct [1], __mpq_struct [1]>, CGAL::Interval_nt<false> > > >::Lazy(const CGAL::Lazy<CGAL::Point_3<CGAL::Simple_cartesian<CGAL::Interval_nt<false> > >, CGAL::Point_3<CGAL::Simple_cartesian<__gmp_expr<__mpq_struct [1], __mpq_struct [1]> > >, CGAL::Cartesian_converter<CGAL::Simple_cartesian<__gmp_expr<__mpq_struct [1], __mpq_struct [1]> >, CGAL::Simple_cartesian<CGAL::Interval_nt<false> >, CGAL::NT_converter<__gmp_expr<__mpq_struct [1], __mpq_struct [1]>, CGAL::Interval_nt<false> > > >&)’ at /mnt/testsuite/include/CGAL/Lazy.h:877:7,
    inlined from ‘CGAL::Point_3<CGAL::Epeck>::Point_3(const CGAL::Point_3<CGAL::Epeck>&)’ at /mnt/testsuite/include/CGAL/Point_3.h:30:7,
    inlined from ‘std::_Head_base<_Idx, _Head, false>::_Head_base(const std::_Head_base<_Idx, _Head, false>&) [with long unsigned int _Idx = 0; _Head = CGAL::Point_3<CGAL::Epeck>]’ at /usr/include/c++/15/tuple:208:17,
    inlined from ‘std::_Tuple_impl<_Idx, _Head, _Tail ...>::_Tuple_impl(const std::_Tuple_impl<_Idx, _Head, _Tail ...>&) [with long unsigned int _Idx = 0; _Head = CGAL::Point_3<CGAL::Epeck>; _Tail = {int, int}]’ at /usr/include/c++/15/tuple:318:17,
    inlined from ‘std::tuple< <template-parameter-1-1> >::tuple(const std::tuple< <template-parameter-1-1> >&) [with _Elements = {CGAL::Point_3<CGAL::Epeck>, int, int}]’ at /usr/include/c++/15/tuple:1502:17,
    inlined from ‘bool __gnu_cxx::__ops::_Val_comp_iter<_Compare>::operator()(_Value&, _Iterator) [with _Value = std::tuple<CGAL::Point_3<CGAL::Epeck>, int, int>; _Iterator = __gnu_cxx::__normal_iterator<std::tuple<CGAL::Point_3<CGAL::Epeck>, int, int>*, std::vector<std::tuple<CGAL::Point_3<CGAL::Epeck>, int, int> > >; _Compare = CGAL::Polygon_mesh_processing::autorefine_impl::collect_intersections<CGAL::Epeck>(const std::array<CGAL::Point_3<CGAL::Epeck>, 3>&, const std::array<CGAL::Point_3<CGAL::Epeck>, 3>&, std::vector<std::tuple<CGAL::Point_3<CGAL::Epeck>, int, int> >&)::<lambda(auto:82, auto:83)>]’ at /usr/include/c++/15/bits/predefined_ops.h:240:23,
    inlined from ‘void std::__unguarded_linear_insert(_RandomAccessIterator, _Compare) [with _RandomAccessIterator = __gnu_cxx::__normal_iterator<tuple<CGAL::Point_3<CGAL::Epeck>, int, int>*, vector<tuple<CGAL::Point_3<CGAL::Epeck>, int, int> > >; _Compare = __gnu_cxx::__ops::_Val_comp_iter<CGAL::Polygon_mesh_processing::autorefine_impl::collect_intersections<CGAL::Epeck>(const std::array<CGAL::Point_3<CGAL::Epeck>, 3>&, const std::array<CGAL::Point_3<CGAL::Epeck>, 3>&, std::vector<std::tuple<CGAL::Point_3<CGAL::Epeck>, int, int> >&)::<lambda(auto:82, auto:83)> >]’ at /usr/include/c++/15/bits/stl_algo.h:1758:20:
/usr/include/c++/15/bits/atomic_base.h:631:34: warning: ‘unsigned int __atomic_fetch_add_4(volatile void*, unsigned int, int)’ writing 4 bytes into a region of size 0 overflows the destination [-Wstringop-overflow=]
  631 |       { return __atomic_fetch_add(&_M_i, __i, int(__m)); }
      |                ~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~
```

See for example https://cgal.geometryfactory.com/CGAL/testsuite/CGAL-6.2-Ic-6/Constrained_triangulation_3_Examples/TestReport_cgaltest_Fedora-rawhide-Release.gz
 2025-09-25 16:25:37 +02:00
Mael Rouxel-Labbé 0721be1a58 Use \link / \ref to add missing links of functions with parameters 2025-09-19 00:26:17 +02:00
Sébastien Loriot 72cfcc4156 Merge remote-tracking branch 'cgal/6.1.x-branch' into 'cgal/main' 2025-09-03 16:57:03 +02:00
Sébastien Loriot 12f6041f5a Merge remote-tracking branch 'cgal/6.0.x-branch' into cgal/master 2025-09-03 16:56:24 +02:00
Sébastien Loriot 8c25c60052 Merge remote-tracking branch 'cgal/5.6.x-branch' into 'cgal/6.0.x-branch' 2025-09-03 16:55:14 +02:00