Commit Graph
488 Commits
Author SHA1 Message Date
Sven Oesau a01838d9f7 adding check for collinear segments in case of strict parameters 2025-12-10 14:56:12 +01:00
Sven Oesau ec4c1f04ef added check for degenerate segments 2025-12-10 13:56:45 +01:00
Sven Oesau 68dda50cd1 fix warnings
resolve ambiguity
2025-12-09 15:07:18 +01:00
Sven Oesau d91e1bc253 doc fix 2025-12-07 18:02:42 +01:00
Sven Oesau 44d49298f2 adding parameter to detect_corners_of_regions and region_growing_of_planes_on_faces to choose between least squares primitives and the new plane/segment based primitives 2025-12-07 11:29:07 +01:00
Sven Oesau 4ac3147ac5 integrating reviews 2025-12-05 20:22:07 +01:00
Sven OesauandSebastien Loriot 37bfd82b56 Apply suggestions from code review
Co-authored-by: Sebastien Loriot <sloriot.ml@gmail.com>
2025-12-05 16:15:40 +01:00
Sven Oesau 3f9d9608da integrating review 2025-11-19 15:50:02 +01:00
Sébastien Loriot 71f8c78493 add missing typenames 2025-11-13 10:36:02 +01:00
Sven OesauandMael 7f84fbc131 Apply suggestions from code review
Co-authored-by: Mael <mael.rouxel.labbe@geometryfactory.com>
2025-11-12 16:05:13 +01:00
Sven Oesau b4fa97c745 integrating review 2025-11-12 16:03:46 +01:00
Sven Oesau 249d7d65d3 bugfix 2025-10-21 18:00:53 +02:00
Sven Oesau 7b5d988ddb integrating review 2025-10-17 17:58:39 +02:00
898da8af41 Apply suggestions from code review
Co-authored-by: Mael <mael.rouxel.labbe@geometryfactory.com>
Co-authored-by: Sebastien Loriot <sloriot.ml@gmail.com>
2025-10-17 14:34:11 +02:00
Sven Oesau c7826b20ab Merge branch 'master' into SD_RG_face_normal_map 2025-08-04 16:37:27 +02:00
Sven Oesau 8afff8b17f doc fix 2025-08-04 16:35:37 +02:00
Sven Oesau dc2ed8c923 added examples to show a difference between Line_segment_region and Plane_face_region versus their linear least squares counterparts 2025-08-04 15:45:36 +02:00
Jane Tournois 0ab9d3eebf Merge remote-tracking branch 'cgal/master' into Triangulation_3-CDT_3-lrineau
# Conflicts:
#	Installation/CHANGES.md
2025-06-10 11:18:38 +02:00
Mael Rouxel-Labbé b2db06f845 Add 'Line_segment_region' and 'Segment_length_sorting'
2D equivalents of Face_area_sorting and Plane_face_region
2025-05-22 11:09:33 +02:00
Andreas Fabri e2058c01c6 Remove some hyphens 2025-05-15 07:28:31 +01:00
Laurent Rineau 4b029e69bd Merge branch 'CGAL:master' into Triangulation_3-CDT_3-lrineau 2025-05-13 17:14:39 +02:00
Laurent Rineau 3409d4c974 fix warnings 2025-05-11 23:00:33 +02:00
Jane Tournois 977348fa4c move ++idx outside the for loop 2025-04-15 16:08:26 +02:00
Sven Oesau 1ff234482d fix order of initialization 2025-04-11 10:44:17 +02:00
Sven Oesau 737c0502f7 extend example to cover Plane_face_region and Face_area_sorting 2025-04-09 14:51:08 +02:00
Sven Oesau 0f19011bd7 removing forward declaration
reusing include guards instead of forward declaration
2025-04-02 10:32:19 +02:00
Sven Oesau 765a9d0939 adding default value for template parameter in Point_set_3 forward declaration 2025-04-02 09:14:29 +02:00
Sven Oesau ae1a157c64 replacing Point_set_3.h include with forward declaration 2025-04-02 08:44:33 +02:00
Sven Oesau 4682171fcc added missing includes 2025-04-01 09:59:37 +02:00
Sven Oesau 019c0a5f78 integrating reviews 2025-04-01 09:44:13 +02:00
Sven Oesau 29cc26f6ec added a check for presence of normals (if Point_set_3 is used) 2025-03-31 15:58:54 +02:00
Sven Oesau 18f4e24150 modified CHANGES.md
added missing named parameter
2025-03-27 12:39:50 +01:00
Sven Oesau 51e4b9add2 pass on doc 2025-03-27 12:16:39 +01:00
Sébastien Loriot e538d5e103 keep on the certified version 2025-03-26 14:15:16 +01:00
Sébastien Loriot e817be7057 fix bugs + add a robust version of the inside region predicate 2025-01-20 20:07:16 +01:00
Sébastien Loriot a2b77a2e20 tmp commit so that we can easily test in the demo 2024-12-04 10:20:33 +01:00
Sébastien Loriot a82629dc6f add a new region type and sorting type meant to be used to expend from the largest face 2024-12-04 10:20:05 +01:00
Sébastien Loriot aaf81af292 correctly use the variable 2024-12-04 09:28:48 +01:00
Sébastien Loriot 1fb933ef63 add a way to pass input normal to faces 2024-12-02 17:08:35 +01:00
Sebastien Loriot a43efbfdb3 Fix warning 2024-09-24 16:22:53 +02:00
Sven Oesau 40581dd252 bug fixes 2024-09-12 16:04:10 +02:00
Sven Oesau 830d13734d copy from siggraph24 branch
added parameter estimation
2024-08-30 16:29:43 +02:00
Sébastien Loriot ce678a62b9 Merge remote-tracking branch 'cgal/5.6.x-branch' 2024-08-19 11:23:25 +02:00
Sebastien Loriot 8730ff5d55 Shape_detection: using proper triangulated polygonal faces for linear_least_squares (#8314)
## Summary of Changes

Polygonal faces are now triangulated and face normals are calculated
using PMP::compute_face_normal.

The calculated face normals and triangulations are buffered in
Least_squares_plane_fit_region. However, Least_squares_plane_fit_sorting
is independent and does not benefit from that buffered data.

## Release Management

* Affected package(s): Shape_detection
* Issue(s) solved (if any): fix #7992
2024-08-19 11:22:41 +02:00
Sébastien Loriot 6e5f37474f bad type 2024-08-14 17:20:06 +02:00
Sébastien Loriot e931d1258b add missing include 2024-08-14 16:52:42 +02:00
Sébastien Loriot 7d0969d15f use dynamic property maps 2024-08-14 16:10:53 +02:00
Sébastien Loriot 8c70d6120f hide PMP usage behind a macro 2024-08-14 15:26:33 +02:00
Sébastien Loriot 630e58f484 Merge remote-tracking branch 'cgal/5.6.x-branch' 2024-07-23 17:18:09 +02:00
Sven Oesau 05ba6a2644 fixed warnings
handling of degenerate faces
2024-07-03 10:12:07 +02:00