Commit Graph
5152 Commits
Author SHA1 Message Date
Sébastien Loriot 69c21bccc3 Merge 'master' 2023-01-24 11:29:48 +01:00
Sébastien Loriot 69610f6958 move function 2023-01-24 11:15:04 +01:00
Sébastien Loriot 50ba18725c fix typename usage 2023-01-24 11:10:29 +01:00
hoskillua 483e8b8e50 User manual + add example file for 1 vertex curvature 2023-01-24 08:44:09 +02:00
hoskillua 8af5c620fa reference documentation + minor fix
+ added documentation for the at_vertext curvature functions
- removed dynamically allocated pointers for storing the curvature on vertex
2023-01-23 13:49:34 +02:00
Mael 86ec9ce186 Fix indentation 2023-01-20 22:28:05 +01:00
Mael Rouxel-Labbé 558bace5b7 Fix typo
(PR stowaway!)
2023-01-19 12:48:17 +01:00
Sébastien Loriot cd76994056 rename property map and deprecated old name 2023-01-18 13:45:37 +01:00
Mael d67d7cd4b6 Remove extra to_double 2023-01-18 11:15:17 +01:00
Sebastien Loriot 343735b9d7 missing return 2023-01-17 09:58:38 +01:00
Sébastien Loriot 6a7bd8b0e3 fix angle return type 2023-01-16 19:47:25 +01:00
albert-github 9c2f8ff60e Spelling correction in respect to function / variable names
As indicated in #7041 (Spelling corrections) theer were still some open corrections in respect to variables / functions, these have been addressed heer.
2023-01-13 18:51:28 +01:00
Andreas Fabri 7305e1bb38 Fix typo (thank you Albert) 2023-01-12 17:29:30 +00:00
Andreas Fabri c8b8792275 PMP: Guarantee that the longest_border() halfedge is among extract_boundary_cycles() 2023-01-12 17:01:19 +00:00
Mael 4d22c90474 Merge branch 'master' into feature/bug_documentation_spell_20221113 2023-01-04 10:06:45 +01:00
hoskillua f6855fef22 single vertex computation
implemented single vertex curvature computation
compared against the whole mesh computation on both cases of no radius and with radius on some vertices
still need to add tests, documentation and an example file
2023-01-03 12:13:26 +02:00
Mael Rouxel-Labbé 5e101566fb Remove obsolete typedefs 2023-01-02 10:34:27 +01:00
Sébastien Loriot 6e7eda918c remove PCA version 2022-12-23 16:12:33 +01:00
Sébastien Loriot 898142d739 wrong type 2022-12-22 09:49:35 +01:00
Sébastien Loriot f993ad50c9 conditions of inconsistenit_classification() also apply to assertions 2022-12-19 17:43:12 +01:00
Sébastien Loriot f372bbe7c2 make smooth an option that is OFF by default 2022-12-19 14:35:16 +01:00
Mael Rouxel-Labbé 70efea3bcb Tiny code modernization 2022-12-16 16:28:53 +01:00
Mael Rouxel-Labbé 92bd00f612 Change PMP::refine() is_flippable criterion
The current criterion is some kind of Delaunay ball, which might work OK
for flat regions, but can produce super thin wedges (see issue:
https://github.com/CGAL/cgal/issues/6982) when the mesh is not flat.

The criterion used instead is the one used in PMP::isotropic_remeshing
and PMP::remove_almost_degenerate_faces(), which is the typical angle-based
surface Delaunay criterion.
2022-12-16 16:26:43 +01:00
Mael Rouxel-Labbé 52fc2ffdd4 Change criterion used in "should_flip"
The criterion that takes the scalar_product of the cross products
is maybe adapted to minimize the curvature when triangulating faces,
but should_flip() is used in PMP::isotropic_remeshing, (soon) PMP::refine(),
and PMP::remove_almost_degenerate_faces(). These algorithms aim to
produce well-shaped elements. The criterion is not adapted to these
algorithms: for example, on a flat mesh the scalar product is meaningless
so it will pick the diagonal which maximizes the product of the lengths
and product of sines, but this might create very anisotropic elements
since the sine of obtuse angles is still positive.

The "new" criterion is simply the criterion used in mesh smoothing
and the typical Delaunay criterion for surfaces.
2022-12-16 16:21:46 +01:00
Laurent Rineau f1e1878b8d Merge pull request #7094 from afabri/PMP_named_parameters-GF
PMP: Replace parameter with named parameter
2022-12-16 10:52:17 +01:00
Laurent Rineau c419f52799 Merge pull request #7103 from sloriot/PMP-repair_si_conditional_smoothing
Do not apply smoothing if the CC has some degenerate faces
2022-12-14 10:39:48 +01:00
Laurent Rineau f3e0f45054 Merge pull request #7108 from afabri/PMP-Envelope_warning-GF
PMP: Fix for a -Wmaybe-uninitialized
2022-12-14 10:39:45 +01:00
Laurent Rineau 46b1d230f5 Merge pull request #7103 from sloriot/PMP-repair_si_conditional_smoothing
Do not apply smoothing if the CC has some degenerate faces
2022-12-14 10:18:21 +01:00
Laurent Rineau 2b71438c04 Merge pull request #7108 from afabri/PMP-Envelope_warning-GF
PMP: Fix for a -Wmaybe-uninitialized
2022-12-14 10:18:19 +01:00
Andreas Fabri 39ebebdb5b merge master 2022-12-08 16:49:09 +00:00
Sebastien Loriot f5c41bd712 Merge pull request #7022 from MaelRL/Weights-v2.0-GF-master
Weights fixes (master)
2022-12-08 15:22:19 +01:00
Sebastien Loriot b9a87af07e Merge pull request #7023 from MaelRL/Weights-v2.0-GF-5.5.x
Weights fixes (5.5.x)
2022-12-08 15:21:58 +01:00
Sebastien Loriot fa72ad2ad0 Merge pull request #6977 from MaelRL/Weights-v2.0-GF
Weights fixes (5.4.x)
2022-12-08 15:21:43 +01:00
Mael Rouxel-Labbé a2316e3f21 Minor improvements 2022-12-08 14:38:36 +01:00
Mael Rouxel-Labbé 28663265c6 Merge remote-tracking branch 'cgal/master' into PMP-snap_no_deg_faces_created 2022-12-08 14:35:48 +01:00
Andreas Fabri 9159816fb4 PMP: Fix for a -Wmaybe-uninitialized 2022-12-07 08:02:35 +00:00
Mael 0ff7882997 Merge branch 'master' into feature/bug_documentation_spell_20221113 2022-12-06 22:21:06 +01:00
Mael db81e4a3fb Further clarify doc 2022-12-06 22:13:05 +01:00
Andreas Fabri 1adb13edc8 Do not use deprecated functions 2022-12-06 12:34:26 +00:00
Laurent Rineau 90f6546d77 Merge pull request #7069 from sloriot/PMP-split_repair_5.5
Split repair
2022-12-05 13:50:25 +01:00
Laurent Rineau 42c8c4f9e1 Merge pull request #7070 from sloriot/PMP-split_repair
Split repair (master version)
2022-12-05 12:23:19 +01:00
Laurent Rineau 041df61a70 Merge pull request #7074 from sloriot/PMP-compatible_orientation_missing_option
CGAL::PMP::compatible_orientations: add missing option
2022-12-05 12:22:09 +01:00
Laurent Rineau 17fd74e432 Merge pull request #7090 from afabri/PMP-assertion_bug-GF
Polygon Mesh Processing:  Fix CGAL_assertion_msg
2022-12-05 12:21:51 +01:00
Laurent Rineau 33cffd9c26 Merge pull request #7074 from sloriot/PMP-compatible_orientation_missing_option
CGAL::PMP::compatible_orientations: add missing option
2022-12-05 11:57:16 +01:00
Laurent Rineau ead1795d85 Merge pull request #7090 from afabri/PMP-assertion_bug-GF
Polygon Mesh Processing:  Fix CGAL_assertion_msg
2022-12-05 11:57:06 +01:00
Sébastien Loriot ffc20ffbd1 do not apply smoothing if the CC has some degenerate faces 2022-12-01 04:33:53 +01:00
albert-github f79d8bb542 Spelling corrections
After review
2022-11-30 10:31:13 +01:00
Andreas Fabri 2b26b8dd31 Don't use deprecated code in examples 2022-11-30 07:58:02 +00:00
Andreas Fabri a2e599b23d Fix typos 2022-11-29 16:55:43 +00:00
Andreas Fabri 63ffb5e82f Do the same for the other hole filling functions 2022-11-29 14:49:59 +00:00