diff --git a/.travis.yml b/.travis.yml index 1cae0b5ab..f4b160cbf 100644 --- a/.travis.yml +++ b/.travis.yml @@ -22,7 +22,7 @@ matrix: - python3-setuptools - libpython3-dev env: - - MATRIX_EVAL="export CONFIG=Debug && CHECK_UNDEFINED=ON && PYTHON=python3" + - MATRIX_EVAL="export CONFIG=Debug && PYTHON=python3" - os: linux compiler: gcc-7 addons: @@ -43,11 +43,11 @@ matrix: - python3-setuptools - libpython3-dev env: - - MATRIX_EVAL="export CC=gcc-7 && CXX=g++-7 && CONFIG=Debug && CHECK_UNDEFINED=ON && PYTHON=python3" + - MATRIX_EVAL="export CC=gcc-7 && CXX=g++-7 && CONFIG=Debug && PYTHON=python3" - os: osx compiler: clang env: - - MATRIX_EVAL="export CONFIG=Debug && CHECK_UNDEFINED=ON && PYTHON=python3" + - MATRIX_EVAL="export CONFIG=Debug && PYTHON=python3" install: - if [[ "$TRAVIS_OS_NAME" == "osx" ]]; then brew install ccache; fi @@ -60,7 +60,14 @@ script: # Tutorials and tests - mkdir build - cd build -- cmake -DCMAKE_BUILD_TYPE=$CONFIG -DLIBIGL_WITH_PYTHON=OFF -DLIBIGL_WITH_CGAL=ON -DEMBREE_ISA_AVX=OFF -DEMBREE_ISA_AVX2=OFF -DEMBREE_ISA_AVX512SKX=OFF ../ +- cmake -DCMAKE_BUILD_TYPE=$CONFIG\ + -DLIBIGL_CHECK_UNDEFINED=ON\ + -DLIBIGL_WITH_PYTHON=OFF\ + -DLIBIGL_WITH_CGAL=ON\ + -DEMBREE_ISA_AVX=OFF\ + -DEMBREE_ISA_AVX2=OFF\ + -DEMBREE_ISA_AVX512SKX=OFF\ + ../ - make -j 2 - ctest --verbose - ccache --show-stats diff --git a/include/igl/compute_frame_field_bisectors.cpp b/include/igl/compute_frame_field_bisectors.cpp index e3c47c608..74b284d48 100644 --- a/include/igl/compute_frame_field_bisectors.cpp +++ b/include/igl/compute_frame_field_bisectors.cpp @@ -82,4 +82,5 @@ IGL_INLINE void igl::compute_frame_field_bisectors( // Explicit template instantiation template void igl::compute_frame_field_bisectors, Eigen::Matrix >(Eigen::PlainObjectBase > const&, Eigen::PlainObjectBase > const&, Eigen::PlainObjectBase > const&, Eigen::PlainObjectBase > const&, Eigen::PlainObjectBase >&, Eigen::PlainObjectBase >&); template void igl::compute_frame_field_bisectors, Eigen::Matrix >(Eigen::PlainObjectBase > const&, Eigen::PlainObjectBase > const&, Eigen::PlainObjectBase > const&, Eigen::PlainObjectBase > const&, Eigen::PlainObjectBase >&, Eigen::PlainObjectBase >&); +template void igl::compute_frame_field_bisectors, Eigen::Matrix >(Eigen::PlainObjectBase > const&, Eigen::PlainObjectBase > const&, Eigen::PlainObjectBase > const&, Eigen::PlainObjectBase > const&, Eigen::PlainObjectBase > const&, Eigen::PlainObjectBase > const&, Eigen::PlainObjectBase >&, Eigen::PlainObjectBase >&); #endif diff --git a/include/igl/per_corner_normals.cpp b/include/igl/per_corner_normals.cpp index 4f93986ad..e0bd470f2 100644 --- a/include/igl/per_corner_normals.cpp +++ b/include/igl/per_corner_normals.cpp @@ -28,9 +28,9 @@ IGL_INLINE void igl::per_corner_normals( } template < - typename DerivedV, - typename DerivedF, - typename DerivedFN, + typename DerivedV, + typename DerivedF, + typename DerivedFN, typename DerivedCN> IGL_INLINE void igl::per_corner_normals( const Eigen::MatrixBase& V, @@ -47,9 +47,9 @@ IGL_INLINE void igl::per_corner_normals( } template < - typename DerivedV, - typename DerivedF, - typename DerivedFN, + typename DerivedV, + typename DerivedF, + typename DerivedFN, typename IndexType, typename DerivedCN> IGL_INLINE void igl::per_corner_normals( @@ -108,4 +108,5 @@ template void igl::per_corner_normals, template void igl::per_corner_normals, Eigen::Matrix, Eigen::Matrix, Eigen::Matrix >(Eigen::MatrixBase > const&, Eigen::MatrixBase > const&, Eigen::MatrixBase > const&, double, Eigen::PlainObjectBase >&); template void igl::per_corner_normals, Eigen::Matrix >(Eigen::MatrixBase > const&, Eigen::MatrixBase > const&, double, Eigen::PlainObjectBase >&); template void igl::per_corner_normals, Eigen::Matrix, Eigen::Matrix, Eigen::Matrix >(Eigen::MatrixBase > const&, Eigen::MatrixBase > const&, Eigen::MatrixBase > const&, double, Eigen::PlainObjectBase >&); +template void igl::per_corner_normals, Eigen::Matrix, Eigen::Matrix, int, Eigen::Matrix >(Eigen::MatrixBase > const&, Eigen::MatrixBase > const&, Eigen::MatrixBase > const&, std::vector >, std::allocator > > > const&, double, Eigen::PlainObjectBase >&); #endif diff --git a/python/CMakeLists.txt b/python/CMakeLists.txt index 799e93311..7a1477545 100644 --- a/python/CMakeLists.txt +++ b/python/CMakeLists.txt @@ -137,13 +137,13 @@ elseif(UNIX) set_target_properties(pyigl PROPERTIES SUFFIX ".so") # Enable flag if undefined symbols appear on pyigl module import to get notified about the missing symbols at link time - option(CHECK_UNDEFINED "Check for undefined symbols" OFF) + option(LIBIGL_CHECK_UNDEFINED "Check for undefined symbols" OFF) # Strip unnecessary sections of the binary on Linux/Mac OS if(APPLE) set_target_properties(pyigl PROPERTIES MACOSX_RPATH ".") - if(NOT CHECK_UNDEFINED) + if(NOT LIBIGL_CHECK_UNDEFINED) set_target_properties(pyigl PROPERTIES LINK_FLAGS "-undefined dynamic_lookup -dead_strip") endif() @@ -152,7 +152,7 @@ elseif(UNIX) endif() else() - if(CHECK_UNDEFINED) + if(LIBIGL_CHECK_UNDEFINED) target_link_libraries(pyigl PRIVATE ${PYTHON_LIBRARIES}) set_target_properties(pyigl PROPERTIES LINK_FLAGS "-Wl,--no-undefined") endif()