From a54d558f8236ccf42f551d1811ec2b3e9a912e46 Mon Sep 17 00:00:00 2001 From: James Andrews Date: Wed, 15 Aug 2018 13:12:55 -0700 Subject: [PATCH 1/2] "G can be same ref as G" -> "can be same ref as F" Former-commit-id: fe87d32fb87e44f295573ef131fa1e2c3e767d78 --- include/igl/qslim.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/igl/qslim.h b/include/igl/qslim.h index c1cd9bd44..3a808389e 100644 --- a/include/igl/qslim.h +++ b/include/igl/qslim.h @@ -23,7 +23,7 @@ namespace igl // max_m desired number of output faces // Outputs: // U #U by dim list of output vertex posistions (can be same ref as V) - // G #G by 3 list of output face indices into U (can be same ref as G) + // G #G by 3 list of output face indices into U (can be same ref as F) // J #G list of indices into F of birth face // I #U list of indices into V of birth vertices IGL_INLINE bool qslim( From 1a42b39c93620f2a888cf4945b7e8ad58ad4f54e Mon Sep 17 00:00:00 2001 From: James Andrews Date: Wed, 15 Aug 2018 17:11:54 -0700 Subject: [PATCH 2/2] Update qslim.h also complete the cut off sentence in the V comment Former-commit-id: bae373e510f943a9746c6041bba28410c79df971 --- include/igl/qslim.h | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/include/igl/qslim.h b/include/igl/qslim.h index 3a808389e..a85ad7918 100644 --- a/include/igl/qslim.h +++ b/include/igl/qslim.h @@ -18,7 +18,11 @@ namespace igl // mesh can have open boundaries but should be edge-manifold. // // Inputs: - // V #V by dim list of vertex positions. Assumes that vertices w + // V #V by dim list of vertex positions. Assumes that vertices with + // infinite coordinates are "points at infinity" being used to close up + // boundary edges with faces. This allows special subspace quadrice for + // boundary edges: There should never be more than one "point at + // infinity" in a single triangle. // F #F by 3 list of triangle indices into V // max_m desired number of output faces // Outputs: