Commit Graph
60 Commits
Author SHA1 Message Date
Tzanio Kolev e4c2152419 Update Copyright to 2010-2025 2025-02-03 12:17:26 -08:00
Will Pazner 78e593bea1 Ensure meshgen is set on empty ranks 2025-01-03 09:32:23 -08:00
Hugh Carson 449ae5e8c3 Fix bug where ncmesh would not discover new boundary attribute group 2024-10-11 10:56:28 -04:00
Hugh Carson 6c17447045 Fix triangle ambiguity by only labeling children after tree is finished. 2024-10-10 17:19:22 -04:00
Hugh Carson 4cf617347f Handle the nodes in the case of center -> corner -> root. Non ambiguous paths now have the ability to reorganize all faces discovered. Not handling child reallocation correctly yet 2024-10-09 15:38:23 -04:00
Hugh Carson f3add08ae3 Address MR feedback:
- Rewrapping to 80
- Forward some base methods to public access
- Restore some old implementation methods in terms of new versions
- Doyxgen and comment fixes
2024-09-12 14:14:07 -04:00
Hugh Carson 2f6871e449 CI Fixes:
- Unused variables
- Memory leak
- Initialization order
- Remove std::vector usage
- Fix char index into arrays
- Early exit if an empty ncsubmesh is constructed
- Array list initalizer was hardcoded to int
- Remove anonynmous namespace from ncmesh_tables.hpp, use static and
  constexpr instead
- Remove unneeded table includes in ncsubmesh.cpp and pncsubmesh.cpp
- Move trivial type assertion of Array to class body from constructor
- Fix warning about use of abs over std::abs in batched linalg
- Add parent hashtable accessors to bypass access controls in parent
  classes.
- Change loop condition to avoid need for ncmesh_tables.hpp include
- Change [ParSubMesh] to [SubMesh] for Catch2 category, the parallel
  is implicit in [Parallel] label
- Missing include in mesh_test_utils.cpp
- Fix bug for array access with empty ncmesh
2024-09-09 15:10:25 -04:00
Hugh Carson f052af3d6b Make style 2024-09-09 15:10:25 -04:00
Hugh Carson d0c358ab48 Refactor serial to use the same code branches as parallel for surface 2024-09-09 15:10:25 -04:00
Hugh Carson 7f0e9c8801 Delete alternative older implementation 2024-09-09 15:10:24 -04:00
Hugh Carson f96f8af545 Upgrade the internal face boundary attribute test for NC refinement of the volume submesh 2024-09-09 15:10:24 -04:00
Hugh Carson 4edd730ce7 ghost boundary attributes mean volume tests are passsing 2024-09-09 15:10:24 -04:00
Hugh Carson 06955c17d9 Fix the boundary attributes of subvolume issue without using an RT space 2024-09-09 15:10:24 -04:00
Hugh Carson 06a8b35570 Comment out a lot of printing, will need to delete properly. Fix up VolumeSubMesh test to be more succinct 2024-09-09 15:10:24 -04:00
Hugh Carson 92ff8c744f Reprotect some members of NCMesh, make exposed derived for testing, make hex nonconformal volume testing ok 2024-09-09 15:10:24 -04:00
Hugh Carson c269b1ea54 More bug fixes and testing
- Fix bug for higher order meshes
- Fix bug with missing fields in NCMesh copy ctor.
- Fix test_array double -> int casting.
- Add test for Hex volume submesh
2024-09-09 15:10:24 -04:00
Hugh Carson 013eace8a6 Fix issue where parent triangular faces discovered by child 3 might disagree with child 0,1,2. If an outer child rediscovers the face the parent face will be reordered. 2024-09-09 15:10:24 -04:00
Hugh Carson 8237b9212d Abandoning interior surfaces, the resulting spaces are too ambiguous and the results don't warrant the extra effort 2024-09-09 15:10:24 -04:00
Hugh Carson 009837f4c8 Collection of bug fixes:
- Fix to permute children if a grandchild discovers a different face node ordering. Running out of tests
- Fix bug for triangle faces where central face parent nodes were not being identified correctly.
- Fix bug in ParentFaceNodes where a central triangle face would discover parent nodes with a different orientation to the surrounding faces.
- Fix bug where check was on parent_nodes rather than face_nodes for a second node hit
2024-09-09 15:10:24 -04:00
Hugh Carson b991cb755e Rewrite of the parallel data structure, complete ncmesh is now built doing a leaf to root tree traversal. The ordering is inherited from the parent ncmesh, ensuring all ranks build the correct ncmesh structure. Can handle external nc boundaries, can't handle internal yet due to face instability. 2024-09-09 15:10:24 -04:00
Hugh Carson 5e3359a805 Preliminary work on developing NCSubMesh
Many small features and a lot of really quite dirty code, print statements etc. This comes from squashing a large number of commits together.
A few different strategies were tried and failed (partially building the NC structure, having ranks have different NC etc.) before arriving at
the final reverse tree traversal algorithm.
2024-09-09 15:10:24 -04:00
Veselin Dobrev e471334d2e Fix two small issues uncovered by the tests when using mfem+cuda and
hypre+cuda.
2024-05-03 19:51:37 -07:00
Stowell, Mark L d61d1159ec Re-enforcing "max boundary attribute + 1" convention 2024-04-02 12:24:04 -07:00
Stowell, Mark L 56c76c0d16 double -> real_t 2024-03-27 13:07:27 -07:00
Stowell, Mark L eeb2eb2a07 Fix for boundaries of 2D meshes 2024-02-28 15:50:39 -08:00
Stowell, Mark L cdaabd67ee Recreating interior boundary elements in submeshes 2024-02-10 14:13:49 -08:00
Stowell, Mark L 950fd77063 Adding explanatory comments and switching to FaceInformation struct for cleaner code 2024-02-10 13:35:32 -08:00
Stowell, Mark L e2c9258889 Communicating interior boundary attributes during ParSubMesh construction 2024-02-10 11:57:01 -08:00
Tzanio Kolev 87290fbf56 Update Copyright to 2010-2024 2024-01-27 13:06:49 -08:00
Will Pazner 11aa88c5e0 const correctness
Make num_codim_1 const using IIFE lambda.
2023-11-03 08:26:00 -07:00
Will Pazner 6118beb9e0 Merge remote-tracking branch 'origin/master' into bdr-1d
# Conflicts:
#	mesh/submesh/psubmesh.cpp
2023-10-24 09:21:28 -07:00
Will Pazner 86ec2bfa8d In 1D ParSubMesh, make sure group_stria and group_squad are initialized 2023-09-14 15:07:50 -07:00
Mittal, Ketan 1a0246734b merge with master and resolve conflicts 2023-08-25 17:41:40 -07:00
Will Pazner 9b4c527442 Deprecate Mesh::be_to_edge
Mesh::be_to_face should be used instead for 1D, 2D and 3D.
2023-08-09 07:48:10 -07:00
Will Pazner 5359237ffd Add boundary elements in 1D ParSubMesh 2023-08-09 07:48:10 -07:00
Stowell, Mark L 2ccb26a873 Fixing shared quad face orientations in ParSubMesh 2023-06-29 16:21:47 -07:00
Stowell, Mark L c19ea4c790 Adding boundary Point elements to 1D meshes consistent with boundaries in 2 and 3D meshes 2023-04-30 10:24:23 -07:00
Stowell, Mark L 65494eef22 Merge remote-tracking branch 'origin/master' into submesh-nd-dev 2023-04-19 14:45:37 -07:00
Stowell, Mark L 49c93a5cba Merge remote-tracking branch 'origin/master' into submesh-nd-dev
# Conflicts:
#	fem/fe/fe_base.hpp
#	fem/fespace.hpp
2023-04-17 14:09:04 -07:00
Stowell, Mark L ffb6dd72eb Supporting face orientations in 2D sub-meshes produced either as FromDomain or FromBoundary 2023-04-12 16:47:42 -07:00
Stowell, Mark L 4e9ed7fc51 Caching relative face orientations in SubMesh objects 2023-04-07 15:02:02 -07:00
camierjs e8d218ca23 Sanitize mesh/submesh/psubmesh.cpp tests/unit/mesh/test_psubmesh.cpp 2023-04-03 17:24:38 -07:00
Ketan Mittal 0f390f131b minor refactor 2023-03-31 07:20:13 -07:00
Ketan Mittal d78c9eb624 fix psubmesh for dim = spacedim 2023-03-30 16:21:58 -07:00
Stowell, Mark L 0ef605e1d0 Shared faces must be sorted with triangular faces first 2023-03-30 14:35:30 -07:00
Stowell, Mark L 9546cffb84 Reining in the new attribute numbers 2023-03-29 15:25:27 -07:00
Stowell, Mark L 85a06dcc1d Edge orientation fix 2023-03-13 18:54:05 -07:00
Tzanio Kolev 96e00dc815 Updated COPYRIGHT to 2010-2023 2023-03-11 16:58:18 -08:00
Ketan Mittal 0560039149 bdr attributes for 2D meshes 2023-02-11 15:21:53 -08:00
Julian Andrej 3258e39120 bugfix for surface submesh boundary elements from volume 2022-12-27 13:49:31 -08:00