Apply suggestions from code review

Co-authored-by: Ryan Curtin <ryan@ratml.org>
This commit is contained in:
Yashwant Singh Parihar
2020-08-19 09:13:19 +05:30
committed by GitHub
co-authored by Ryan Curtin
parent 2d50c195d6
commit a68a96ccbb
2 changed files with 3 additions and 4 deletions
+2 -3
View File
@@ -10,11 +10,10 @@
include("${SOURCE_DIR}/CMake/StripType.cmake")
strip_type("${PROGRAM_MAIN_FILE}")
# Extract the requried part from *main.cpp.
# Extract the required part from *main.cpp.
# Example: mlpack/methods/adaboost/adaboost_main.cpp
string(REGEX MATCHALL "\\/src\\/[A-Za-z\\/._]*" INCLUDE_MODEL_SAFE
string(REGEX REPLACE "${SOURCE_DIR}\\/src\\/" "" INCLUDE_FILE
"${PROGRAM_MAIN_FILE}")
string(REGEX REPLACE "\\/src\\/" "" INCLUDE_FILE "${INCLUDE_MODEL_SAFE}")
file(READ "${MODEL_FILE}" MODEL_FILE_TYPE)
if (NOT (MODEL_FILE_TYPE MATCHES "\"${MODEL_SAFE_TYPES}\""))
+1 -1
View File
@@ -19,7 +19,7 @@ using namespace mlpack::util;
// Fake ProgramDoc in case none is supplied.
static ProgramDoc emptyProgramDoc = ProgramDoc("", "", []() { return ""; },
[]() { return ""; }, {});
[]() { return ""; }, {});
/* Constructors, Destructors, Copy */
/* Make the constructor private, to preclude unauthorized instances */