Ok, handle NaNs correctly, and also check this in in trunk, not in the tags...

This commit is contained in:
Ryan Curtin
2014-03-09 05:13:00 +00:00
parent 83ea01d4bb
commit b49848a2b6
@@ -60,10 +60,18 @@ class WMultiplicativeDivergenceRule
t2.set_size(H.n_cols);
for (size_t k = 0; k < t2.n_elem; ++k)
{
// This may produce NaNs if V(i, k) = 0.
// Technically the math in the paper does not define what to do in
// this case, but considering the basic intent of the update rules,
// we'll make this modification and take t2(k) = 0.0.
t2(k) = H(j, k) * V(i, k) / t1(i, k);
if (t2(k) != t2(k))
t2(k) = 0.0;
}
W(i, j) = W(i, j) * sum(t2) / sum(H.row(j));
// Only update if the sum is not going to be 0, so as to prevent a
// divide by zero. If sum(H.row(j)) is 0, then t2 should be 0 too.
W(i, j) *= sum(t2) / sum(H.row(j));
}
}
}
@@ -111,10 +119,18 @@ class HMultiplicativeDivergenceRule
t2.set_size(W.n_rows);
for (size_t k = 0; k < t2.n_elem; ++k)
{
// This may produce NaNs if V(i, k) = 0.
// Technically the math in the paper does not define what to do in
// this case, but considering the basic intent of the update rules,
// we'll make this modification and take t2(k) = 0.0.
t2(k) = W(k, i) * V(k, j) / t1(k, j);
if (t2(k) != t2(k))
t2(k) = 0.0;
}
H(i,j) = H(i,j) * sum(t2) / sum(W.col(i));
// Only update if the sum is not going to be 0, so as to prevent a
// divide by zero. If sum(W.col(j)) is 0, then t2 should be 0 too.
H(i, j) *= sum(t2) / sum(W.col(i));
}
}
}