Commit Graph
26996 Commits
Author SHA1 Message Date
Ryan Curtin bc6aff9893 Merge pull request #3080 from SuvarshaChennareddy/fixing-comment
Fix comments in files that implement SVD methods for PCA
2021-11-01 18:59:21 -04:00
SuvarshaChennareddy 753af64f3d adding myself to contributer list 2021-11-01 19:01:22 +05:30
SuvarshaChennareddy 5cef31880e fix comment 2021-11-01 00:03:13 +05:30
Ryan Curtin 6b5ac41f70 Merge pull request #3070 from RishabhGarg108/dt-union
Use union instead of `splitPointOrPrediction` in decision tree
2021-10-24 15:26:32 -04:00
Rishabh Garg 903cd66d5c Fixed style in if condition. 2021-10-23 11:01:28 +05:30
Rishabh Garg 417bdae33d Fixed indentation of union. 2021-10-23 10:57:02 +05:30
Rishabh Garg 0fac9d42ac Fixed indentation of union. 2021-10-23 10:55:49 +05:30
Rishabh GargandRyan Curtin b4d709bad6 Apply suggestions from code review
Co-authored-by: Ryan Curtin <ryan@ratml.org>
2021-10-22 08:01:16 +05:30
Omar ShritandMarcus Edel 9e040c57c0 Remove boost any (#3006)
* Adding std_backport

Signed-off-by: Omar Shrit <omar@shrit.me>

* Define macro for any and any_cast

Signed-off-by: Omar Shrit <omar@shrit.me>

* Regexp replcement is working

Signed-off-by: Omar Shrit <omar@shrit.me>

* Change the backport library

Signed-off-by: Omar Shrit <omar@shrit.me>

* Change the prereqs to the new library

Signed-off-by: Omar Shrit <omar@shrit.me>

* Adding more boost::any

Signed-off-by: Omar Shrit <omar@shrit.me>

* Adding more boost::any

Signed-off-by: Omar Shrit <omar@shrit.me>

* Starting converting string_view in addition to std::any

Signed-off-by: Omar Shrit <omar@shrit.me>

* Use std::hash instead of boost::hash

Signed-off-by: Omar Shrit <omar@shrit.me>

* Remove boost string_view headers

Signed-off-by: Omar Shrit <omar@shrit.me>

* Clean boost headers

Signed-off-by: Omar Shrit <omar@shrit.me>

* Remove the last hidden boost::any

Signed-off-by: Omar Shrit <omar@shrit.me>

* Let us see if this passes on Windows

Signed-off-by: Omar Shrit <omar@shrit.me>

* Windows has it is own rules

Signed-off-by: Omar Shrit <omar@shrit.me>

* Let us try the Zplusplus switch

Signed-off-by: Omar Shrit <omar@shrit.me>

* Fix go binding const removal

Signed-off-by: Omar Shrit <omar@shrit.me>

* Let see if this make windows happy

Signed-off-by: Omar Shrit <omar@shrit.me>

* Add a typename before std::remove_cv

Signed-off-by: Omar Shrit <omar@shrit.me>

* Let us force C++17 on Windows

Signed-off-by: Omar Shrit <omar@shrit.me>

* Increase boost version on Windows

Signed-off-by: Omar Shrit <omar@shrit.me>

* Fix Windows Path for boost

Signed-off-by: Omar Shrit <omar@shrit.me>

* Remove the additional 0 from the path

Signed-off-by: Omar Shrit <omar@shrit.me>

* Keep only boost, and remove boost math and random

Signed-off-by: Omar Shrit <omar@shrit.me>

* Try to discover boost path

Signed-off-by: Omar Shrit <omar@shrit.me>

* Remove boost lib directory, no longer required

Signed-off-by: Omar Shrit <omar@shrit.me>

* There is no clear in C++17 standard

Also there is no need to clear the string if we are returning
function. C++ should delete it immediately

Signed-off-by: Omar Shrit <omar@shrit.me>

* Remove the const before the double in setParamPtr

Signed-off-by: Omar Shrit <omar@shrit.me>

* Remove boost any header

Signed-off-by: Omar Shrit <omar@shrit.me>

* Let us see if the tests are passing without these two

Signed-off-by: Omar Shrit <omar@shrit.me>

* Fix merge error for any_cast

Signed-off-by: Omar Shrit <omar@shrit.me>

* Fix bad merge

Signed-off-by: Omar Shrit <omar@shrit.me>

* It is looping in the while loop

Signed-off-by: Omar Shrit <omar@shrit.me>

* Adding more debugging symbols

Signed-off-by: Omar Shrit <omar@shrit.me>

* Adding all debugging symbols

Signed-off-by: Omar Shrit <omar@shrit.me>

* Add an empty string view, remove empty debug symbols

Signed-off-by: Omar Shrit <omar@shrit.me>

* Clean boost dis from windows

Signed-off-by: Omar Shrit <omar@shrit.me>

* Update src/mlpack/tests/string_encoding_test.cpp

Co-authored-by: Marcus Edel <marcus.edel@fu-berlin.de>

* Add LICENSE information about MNMLSTC library

Signed-off-by: Omar Shrit <omar@shrit.me>

* Add LICENSE to all the files

Signed-off-by: Omar Shrit <omar@shrit.me>

Co-authored-by: Marcus Edel <marcus.edel@fu-berlin.de>
2021-10-21 21:14:49 +05:30
Ryan Curtin 8d0a5d02a1 Merge pull request #3075 from rcurtin/det-output-fix
det: don't print filename unless it's actually given
2021-10-21 09:51:41 -04:00
Rishabh Garg cc092e330c Added documentation 2021-10-20 13:36:32 +05:30
Rishabh Garg c6350424e8 Made corresponding changes to DecisionTree class 2021-10-20 13:29:02 +05:30
Ryan Curtin f171cea1fc Merge pull request #3059 from rcurtin/r-binding-label-error
Handle incorrect labels for R bindings
2021-10-19 17:34:42 -04:00
Marcus Edel 97d25c5ad5 Merge pull request #2973 from rcurtin/julia-fix-categories
Julia: compute number of categories in categorical data.
2021-10-19 15:58:13 -04:00
Ryan Curtin dfe3f465d1 Fix an additional dependency for rcmdcheck. 2021-10-18 09:12:11 -04:00
Ryan Curtin 9a1646adb1 Merge remote-tracking branch 'origin/master' into julia-fix-categories 2021-10-16 12:33:28 -04:00
Ryan Curtin efb345e4cc Don't print the filename unless it was actually given. 2021-10-16 11:48:44 -04:00
Aakash kaushik c3a89f0bd4 Merge pull request #3071 from zoq/gov-update
Update NumFOCUS team voting responsibilities
2021-10-08 14:13:05 +05:30
Marcus Edel dc5d3524b1 Update NumFOCUS team voting responsibilities. 2021-10-07 20:20:30 -04:00
Rishabh Garg c1180b6bad Change splitPointOrPrediction into a union 2021-10-06 17:30:59 +05:30
Rishabh Garg ed0fe029e5 Merge branch 'master' of https://github.com/mlpack/mlpack 2021-10-06 16:21:49 +05:30
Himanshu Pathak 5d7304677f Adding copy constructor in convolution layer (#3067)
* Adding copy constructor in convolution layer

* Adding space in the end

* Adding Spaces
2021-10-05 09:05:59 +05:30
Marcus Edel 1ed59878da Merge pull request #3068 from shrit/fix_readme
Add a missing line for Redhat installation instruction.
2021-10-04 12:48:00 -04:00
Omar Shrit f7ebbea36b Add a missing line for Redhat installation
Signed-off-by: Omar Shrit <omar@shrit.me>
2021-10-03 20:16:55 +01:00
Ryan Curtin db641c20e6 Merge pull request #3065 from mlpack/cli11-header-updates-2.1.1
Upgrade CLI11 to 2.1.1
2021-10-01 20:14:57 -04:00
Yashwants19 aa67a91e11 Upgrade CLI11 to 2.1.1 2021-10-01 10:00:30 +00:00
Omar Shrit 9bbd7acca5 Merge pull request #3062 from shrit/clean_reorder_warning
Clean reorder warning
2021-09-28 17:08:15 +02:00
Omar Shrit 950064639b Fix the second reorder warning error
Signed-off-by: Omar Shrit <omar@shrit.me>
2021-09-26 22:32:39 +01:00
Omar Shrit fe64277743 Fix first reorder error
Signed-off-by: Omar Shrit <omar@shrit.me>
2021-09-26 22:30:18 +01:00
Aakash kaushik a5b0b4409c Merge pull request #3061 from shrit/remove_unused_paramater
Remove ar parameter to avoid the warning
2021-09-26 09:57:48 +05:30
Omar Shrit b21f30720a Remove ar parameter to avoid the warning
Serialization is not used in this layer, therefore the warning of
unused parameter is becoming annoying when trying to compile the
mlpack_test making it impossible to find different errors in small
terminal. Since we are using boost_visitor, the unfolding of layers
is taking several pages of terminal to print this small warning.

Hoping that this will mitigate one of the warning.

Signed-off-by: Omar Shrit <omar@shrit.me>
2021-09-23 23:19:09 +01:00
Omar Shrit 7ffc8088ef Disable autodownload by default (#2953)
* Disable autodownload be default

Signed-off-by: Omar Shrit <omar@shrit.me>
2021-09-22 23:05:50 +05:30
Ryan Curtin f0a669404f Merge pull request #3034 from rcurtin/r-duplicate-model-fix
Attempt to fix double-free of XPtrs for R bindings
2021-09-20 17:52:56 -04:00
Marcus Edel 18f42586cd Merge branch 'master' into r-duplicate-model-fix 2021-09-18 12:07:40 -04:00
jeffin sam acdbf4ca41 Merge pull request #3047 from swaingotnochill/split-data
Add checks for labels and input sizes for split function
2021-09-16 22:40:56 +05:30
Ryan Curtin cf9dcfb18f Throw errors when the user tries to pass 0 as a label. 2021-09-09 21:43:11 -04:00
Ryan Curtin 45de6e11e4 Merge pull request #3056 from shrit/clean_io_impl
Remove io_impl empty file
2021-09-09 20:53:44 -04:00
Omar Shrit 030e669e45 Remove io_impl empty file
Signed-off-by: Omar Shrit <omar@shrit.me>
2021-09-09 21:06:22 +02:00
Roshan Swain b57e8cab54 fixed size check test 2021-09-04 20:48:18 +05:30
Roshan Swain 34030e8034 fixed matrix label type 2021-09-04 20:44:13 +05:30
Ryan Curtin 4a91e1e50b Merge remote-tracking branch 'origin/master' into julia-fix-categories 2021-09-03 13:10:02 -04:00
Ryan Curtin e02ab3be54 Document Armadillo version policy. (#3048) 2021-09-01 02:31:50 +02:00
Marcus Edel bee9b848dd Bump minimum Armadillo version to 9.800 (#3043) 2021-08-31 15:41:25 +02:00
Roshan Swain ba90e9bb11 add checks for labels and input sizes for split function 2021-08-31 15:50:20 +05:30
jeffin sam c9b6057bd0 Merge pull request #3045 from vincent-courson/Addapt_mlpackFindPackage
Change CMAKE_SOURCE_DIR to CURRENT_SOURCE for easily import mlpack in Project
2021-08-30 21:36:33 +05:30
Vincent Courson 77cd3efcc7 Change CMAKE_SOURCE_DIR to CURRENT_SOURCE for easily import mlpack in Project 2021-08-30 03:38:07 +02:00
abh2kandAbhinav-Aidash 7c99839e51 group norm implementation (#3028)
* Add Group norm layer implementation.

Co-authored-by: Abhinav-Aidash <85210822+Abhinav-Aidash@users.noreply.github.com>
2021-08-24 14:59:42 -04:00
Ryan Curtin b32e587acb Fix R binding CI build (hopefully). 2021-08-19 11:32:59 -04:00
Ryan Curtin 4c40e4e5fb Only use one core to build. 2021-08-18 10:32:28 -04:00
Ryan Curtin 33cf3736cb Oops, fix compression option. 2021-08-17 16:01:18 -04:00