Commit Graph
26621 Commits
Author SHA1 Message Date
Rishabh Garg fccba9fb52 Reogranised tests for readability and updated tolerances for some tests 2021-07-12 10:36:33 +05:30
Rishabh Garg d0bb744684 Added remaining tests 2021-07-12 10:36:33 +05:30
Rishabh Garg 561c14062d Removed numClasses from regression tree codebase 2021-07-12 10:36:33 +05:30
Rishabh Garg 9539af8cae Removed the debugging code and reverted back to the previous version. 2021-07-12 10:36:33 +05:30
Rishabh Garg 8d1c188883 Fixed loading the boston housing data (finally) :) 2021-07-12 10:36:33 +05:30
Rishabh Garg 60c2239210 Fixed tests from the crazy merge that unexpectedly happened 2021-07-12 10:36:33 +05:30
Rishabh Garg ffb68e0f7c Debugging code 2021-07-12 10:36:33 +05:30
Rishabh Garg 442cb4284d Removed headers from csv and fixed loading of boston dataset 2021-07-12 10:36:33 +05:30
Rishabh Garg db1fcdc26b Amend RandomBinaryNumericSplit signature to support regression 2021-07-12 10:36:33 +05:30
Rishabh Garg 17ae3872fd Optimised MSEGain computation using prefix sum of squares🚀 2021-07-12 10:32:56 +05:30
Rishabh Garg 0ff17398a5 Making non template functions as inline to avoid duplicate definition error 2021-07-12 10:32:56 +05:30
Rishabh Garg 0717855241 Added tests on LARS dataset and a test where tree is trained on MAD gain 2021-07-12 10:32:56 +05:30
Rishabh Garg 917885b609 Fix bug in MAD gain 2021-07-12 10:32:56 +05:30
Rishabh Garg 34b5ac7bad Use armadillo's functions to evaluate mse and mad gains 2021-07-12 10:32:56 +05:30
Rishabh Garg b1f5a836d9 Minor style fixes and documentation updates from code review 2021-07-12 10:32:56 +05:30
Rishabh Garg ac0b08ead8 This was missed while changing labels to responses 2021-07-12 10:32:56 +05:30
Rishabh Garg 4dc37b23a8 Changed labels to responses throughtout regression tree codebase 2021-07-12 10:32:56 +05:30
Rishabh Garg 26477c778c Removed unnecessary test 2021-07-12 10:32:56 +05:30
Rishabh Garg e0487772ea Added NumLeaves() to regression tree 2021-07-12 10:32:56 +05:30
Rishabh Garg b7d2f22bdc Add MultiSplit tests that ensure that tree learns obvious patterns in data 2021-07-12 10:32:56 +05:30
Rishabh Garg 8d8687a928 Add a mock categorical dataset and test DecisionTreeRegressor on it 2021-07-12 10:32:56 +05:30
Rishabh Garg 44c2b5ca51 Reverted AllCategoricalSplit to use arma::vec for splitInfo 2021-07-12 10:32:56 +05:30
Rishabh Garg 6e34bc02c6 Add random numeric splitting strategy for regression tree 2021-07-12 10:32:56 +05:30
Rishabh Garg fdb90df2d3 Reverted splitInfo to arma::vec for old decision tree for numric splits 2021-07-12 10:32:56 +05:30
Rishabh Garg 57572aa876 Removed numLeaves from BestBinaryNumericSplit 2021-07-12 10:32:56 +05:30
Rishabh Garg c174f68d0f Reorganised tests and added tests to ensure gain correctness by hand calculating the values 2021-07-12 10:32:56 +05:30
Rishabh Garg 271e90130e Weighted gain computation in BestBinaryNumericSplit 2021-07-12 10:32:56 +05:30
Rishabh Garg 8e4b891c82 fixed failing test after merging master 2021-07-12 10:32:56 +05:30
Rishabh Garg b5c72f1268 Fixed MSEgain computation 2021-07-12 10:28:54 +05:30
Rishabh Garg b6145adab8 Add hand created dataset for testing 2021-07-12 10:28:02 +05:30
Rishabh Garg aa78c26d7a Added more debugging code 2021-07-12 10:27:38 +05:30
Rishabh Garg 64fde38ae8 Testing for bug in implementation 2021-07-12 10:27:24 +05:30
Rishabh Garg c2c85f0250 Add initial tests 2021-07-12 10:26:18 +05:30
Rishabh Garg 4f000d5894 Add evaluation metrics for testing 2021-07-12 10:26:18 +05:30
Rishabh Garg a3fc8d9fe6 Add to CMakeLists.txt 2021-07-12 10:26:18 +05:30
Rishabh Garg be81c14a52 Implement DecisionTreeRegressor 2021-07-12 10:26:18 +05:30
Rishabh Garg dcc96c056c Amend RandomBinaryNumericSplit signature to support regression 2021-07-12 10:25:30 +05:30
Rishabh Garg 0449ace922 Update documentation 2021-07-12 10:16:31 +05:30
Rishabh Garg c6f0d29457 Make LabelsType a new template parameter and use subvec for labels 2021-07-12 10:16:31 +05:30
Rishabh Garg c4e3d1fcc3 Add TODO for optimization in BestBinaryNumericSplit for regression 2021-07-12 10:16:31 +05:30
Rishabh Garg ab4f3c3646 Added tests for best binary split 2021-07-12 10:13:35 +05:30
Rishabh Garg 536c5f9880 Implemented best binary split for regression 2021-07-12 10:13:35 +05:30
Rishabh Garg 7e336ad118 Fixed implementation bug in calculating sum of subvector 2021-07-12 10:12:57 +05:30
Rishabh Garg 722df85864 Refactored BestBinaryNumericSplit 2021-07-12 10:12:36 +05:30
Rishabh Garg 2d20ce9099 Added tests for AllCategoricalSplit for regression 2021-07-12 10:12:19 +05:30
Rishabh Garg f541fe20b0 Added ignored numClasses to MSE and MAD gains 2021-07-12 10:11:58 +05:30
Rishabh Garg ff85e20b96 Shifted regression tree tests to new file 2021-07-12 10:11:17 +05:30
Rishabh Garg 6e6d60f2b3 Improved documentation 2021-07-12 10:10:01 +05:30
Rishabh Garg e3579871af Refactored AllCategoricalSplit patch 2 2021-07-12 10:10:01 +05:30
Rishabh Garg 37559821bf Refactored AllCategoricalSplit 2021-07-12 10:10:01 +05:30