## Issue #6446 - `approx_adv` broken and unused in `Lazy_exact_nt`
**Issue:** https://github.com/CGAL/cgal/issues/6446
**Problem:** `Lazy_exact_nt<ET>::approx_adv()` (lines 546-547 of
`Number_types/include/CGAL/Lazy_exact_nt.h`) accessed `this->ptr()`
which is a private member of the `Lazy` base class, causing a compile
error under any instantiation. The function is not documented, has no
tests, and has zero callers across the entire codebase.
**Fix:** Removed the `approx_adv()` method entirely. Users who need an
`Interval_nt_advanced` (`Interval_nt<false>`) from a `Lazy_exact_nt` can
use the existing public `approx()` method inherited from the `Lazy` base
class.
**Files changed:**
- `Number_types/include/CGAL/Lazy_exact_nt.h` (-3 lines)
## Summary of Changes
Some debug code written for AW2 was copy pasted poorly into AW3, and was
also not tested. The PR fixes this.
## Release Management
* Affected package(s): `Alpha_wrap_23`
* Issue(s) solved (if any): -
* Feature/Small Feature (if any): -
* License and copyright ownership: no change
Fixes#9319
#### Problem
`pybind11::detail::is_move_constructible<CGAL::SM_Halfedge_index>`
evaluates
to `false` while `std::move_constructible<CGAL::SM_Halfedge_index>`
correctly
evaluates to `true`. This inconsistency prevents pybind11-based Python
bindings
from properly wrapping types that hold or use `SM_Halfedge_index`.
#### Root Cause
`SM_Halfedge_index` contained five `typedef void` members
(`iterator_category`, `value_type`, `difference_type`, `pointer`,
`reference`)
added as a workaround for a g++ 4.4 ADL bug for `std::next`. pybind11
inspects `value_type` via legacy iterator_traits and, finding `void`,
concludes
the type is not a proper value type and marks it as not
move-constructible.
#### Fix
CGAL 6.0 raised the minimum GCC requirement to 11.4, making the g++ 4.4
workaround unnecessary. Remove the five `typedef void` members and their
explanatory comment. No code in the CGAL codebase references these
typedefs.
## Summary of Changes
In case all faces incident to a border were marked as _processed_ we
missed holes.
## Release Management
* Affected package(s): Polygon_repair
* Issue(s) solved (if any): fix#9325
* License and copyright ownership: unchanged
Spelling corrections
Note: the sentence "Triangle are triple of indices referring to position
of points in the input point range." in
Generator/doc/Generator/CGAL/point_generators_3.h should probably be
reformulated (maybe " Traingles are triplets of indices....")
Spelling corrections
Note: the sentence "Triangle are triple of indices referring to position of points in the input point range." in Generator/doc/Generator/CGAL/point_generators_3.h should probably be reformulated (maybe " Traingles are triplets of indices....")
Sébastien Loriot