Apply suggestions from code review

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This commit is contained in:
Simon Lukas Märtens
2026-07-21 17:23:00 +02:00
committed by GitHub
co-authored by Copilot Autofix powered by AI
parent 4ff99a6b8f
commit 1ffc7344b0
4 changed files with 4 additions and 5 deletions
+1 -1
View File
@@ -1,6 +1,6 @@
# This Makefile compiles the CBLAS routines
# Sources that are shared accross all APIs
# Sources that are shared across all APIs
set(COMMON_SOURCES cblas_globals.c)
# Error handling routines for level 2 & 3
+1 -2
View File
@@ -390,10 +390,9 @@ endif()
# Replace symbol names with their suffixed versions in the source content
foreach(symbol_name IN LISTS symbol_names)
set(symbol_variants "${symbol_name}")
string(TOLOWER "${symbol_name}" symbol_lower)
string(TOUPPER "${symbol_name}" symbol_upper)
foreach(symbol_variant "${symbol_lower}" "${symbol_upper}")
foreach(symbol_variant "${symbol_name}" "${symbol_lower}" "${symbol_upper}")
set(match_regex "(^|[^A-Za-z0-9_])${symbol_variant}([^A-Za-z0-9_]|$)")
set(replacement "\\1${symbol_variant}_64\\2")
string(REGEX REPLACE
+1 -1
View File
@@ -124,7 +124,7 @@ message(STATUS "Build Index-64 API as extended API with _64 suffix: ${BUILD_INDE
if(BUILD_INDEX64_EXT_API AND BUILD_INDEX64)
message(WARNING
"Building Index-64 API redundantly as extended API and default API."
"Building Index-64 API redundantly as extended API and default API. "
"Consider disabling one of them (BUILD_INDEX64_EXT_API / BUILD_INDEX64).")
endif()
+1 -1
View File
@@ -119,7 +119,7 @@ function(add_eig_executable name)
target_compile_options(${name}_64 PRIVATE ${FOPT_ILP64})
target_link_libraries(${name}_64 ${TMGLIB} ${LAPACK_LIBRARIES} ${BLAS_LIBRARIES})
# Add depedency to the global codegen target. Since we reuse the same
# Add dependency to the global codegen target. Since we reuse the same
# generated source file for multiple tests, the generation could be
# triggered by multiple targets when building in parallel.
add_dependencies(${name}_64 64bit_codegen)