Commit Graph
3416 Commits
Author SHA1 Message Date
NAKATA Maho 820ef1d794 cleanup: separate real and complex zero/one constants in {c,z}csdts
Replace REALONE/REALZERO and complex ZERO/ONE with
type-specific named constants in the CSD test routines:
ZERO/ONE for real scalars, and CZERO/CONE for complex values.

Update {C,Z}LASET, {C,Z}GEMM, and {C,Z}HERK call sites to use
the matching constant type, and replace literal imaginary zeros
in CMPLX/DCMPLX calls with the named real ZERO constant.

No functional change intended.
2026-04-11 23:02:17 +09:00
langou 774b05d15d Merge pull request #1221 from langou/origin/follow_up_on_PR1146
Follow up on pr1146 (v2)
2026-03-31 16:57:12 -06:00
Julien Langou 944e920ac6 address @mgates' suggestion: "I tend to reset pointers to NULL after freeing them, to avoid any possible confusion." 2026-03-31 09:18:46 -06:00
Julien Langou 6c4efb0307 address @mgates' suggestion: "A comment that joba == e is using V as workspace would be helpful. (Per later comment when transposing results.)" 2026-03-31 09:07:39 -06:00
Julien Langou bb1afab469 went back and forth on how to handle the case ((m==0)||(n==0)) 2026-03-28 14:23:22 -06:00
Julien Langou 077a97f9d7 address @mgates3 requested changes on this pull request (thanks!) 2026-03-28 14:15:52 -06:00
langou ed4d486f65 Merge branch 'Reference-LAPACK:master' into follow_up_on_PR1146 2026-03-28 13:40:15 -06:00
langou a884b29254 Merge pull request #1213 from langou/MINMN_EQ_0 2026-03-28 10:19:46 -06:00
langou d3388ade69 Merge pull request #1220 from nakatamaho/topic/xLARGV-fix-helper-naming
clargv,zlargv: rename local ABS1 helper to CABSMAX
2026-03-28 08:09:49 -06:00
langou 9130566c33 Merge pull request #1219 from nakatamaho/refactor/unify-abs1-to-cabs1
refactor: rename ABS1 statement function to CABS1 for consistency
2026-03-28 08:05:47 -06:00
langou d6bd7e3f4e Merge pull request #1218 from nakatamaho/fix/blas-cabs1_axpy
BLAS: inline SCABS1/DCABS1 into CAXPY/ZAXPY as statement function CABS1
2026-03-28 08:05:11 -06:00
NAKATA Maho 1ed1f080da clargv,zlargv: rename local ABS1 helper to CABSMAX
The local ABS1 statement function in CLARGV and ZLARGV does not compute
the usual complex ABS1/CABS1 quantity. It returns

    max(abs(real(z)), abs(aimag(z)))

and is used only as a scaling helper in the same algorithmic path as
CLARTG/ZLARTG.

Rename the helper to CABSMAX so that the name matches its actual
behavior and does not suggest CABS1 semantics.

No numerical behavior is changed.
2026-03-28 16:55:08 +09:00
NAKATA Maho ac82605ea9 refactor: rename ABS1 statement function to CABS1 for consistency
Several LAPACK, BLAS, and CBLAS source files defined a local statement
function named ABS1 for the complex 1-norm approximation:

    ABS1( X ) = ABS( REAL( X ) ) + ABS( AIMAG( X ) )
    ABS1( X ) = ABS( DBLE( X ) ) + ABS( DIMAG( X ) )

The majority of the codebase already uses CABS1 for this identical
purpose. This commit renames ABS1 to CABS1 in all remaining files
(definition line, declaration line, and all call sites within the
same file) to make the naming consistent across the repository.

A small number of fixed-form lines required continuation-line splits
to stay within the 72-column limit after the rename.

No numerical change. Statement functions are file-local in Fortran,
so there is no ABI or interface impact.

This is a preparatory cleanup before inlining these statement
functions (see issue #1200).
2026-03-28 14:46:42 +09:00
NAKATA Maho 0843d3ed4b BLAS: inline SCABS1/DCABS1 into CAXPY/ZAXPY as statement function CABS1
Replace external function references to SCABS1 and DCABS1 with a local
statement function CABS1 in CAXPY and ZAXPY respectively, eliminating
the dependency on those auxiliary routines.
2026-03-28 14:10:56 +09:00
langou c550a3638b Merge pull request #1215 from langou/typo_in_comment_of_xrotmg 2026-03-27 12:48:18 -06:00
langou 64e47cf7e2 Merge pull request #840 from weslleyspereira/try-lapack_namespace
In CMake, install BLAS::BLAS and LAPACK::LAPACK
2026-03-27 08:31:31 -06:00
Julien Langou 8d54a91fee typo, thanks to @jasonriedy for letting me know
issue with doxygen comments
2026-03-26 13:05:33 -06:00
Julien Langou e7b6349d39 oops 2026-03-26 12:56:16 -06:00
Julien Langou dc69275836 rewrite of lapacke_[x]gesvdq_work.c 2026-03-26 12:45:49 -06:00
Julien Langou e67e3b47d2 minor typos in ZGESVDQ 2026-03-26 08:36:49 -06:00
langou d6bf599fd7 (typo) Fix variable name 2026-03-26 08:30:15 -06:00
Julien Langou ea65bb77ba As suggested by Angelika,see PR#1035, use MINMN.EQ.0 instead of M.EQ.0 2026-03-26 08:05:24 -06:00
langou 034ada14fa Merge pull request #1035 from frjohnst/geqp3_Jul2024
xGEQP3 changes July 2024
2026-03-26 07:55:41 -06:00
langou 2ec774a2f6 Merge branch 'master' into try-lapack_namespace 2026-03-25 14:41:24 -06:00
langou a22074819d Merge pull request #967 from christoph-conrads/943-xBBCSD-read-of-unitialised-value
xBBCSD: fix uninitialized read
2026-03-25 14:31:29 -06:00
langou 89791177a7 Merge branch 'master' into 943-xBBCSD-read-of-unitialised-value 2026-03-25 13:21:59 -06:00
langou 1d7b5c10a5 Merge pull request #1052 from angsch/master
Converge >= and > usage in docs and implementation of GESVJ
2026-03-25 13:15:16 -06:00
langou 4f84ecc5ca Merge pull request #774 from mgates3/tgsen
fix workspace size in tgsen
2026-03-25 12:58:51 -06:00
langou 95640a9031 Merge pull request #1140 from MaartenBaert/fix-dlasd7
Fix documentation error and ordering bug in DLASD7
2026-03-25 12:52:49 -06:00
langou f954f62cd1 Merge pull request #1146 from yizeyi18/xgesvdq-more-jobuv
Fix `xGESVDQ`'s jobu and jobv support in LAPACKE
2026-03-25 12:36:10 -06:00
langou 8104c32fe8 Merge pull request #1168 from foxtran/refactor/ieeeck
Refactor IEEECK to avoid generating IEEE exceptions by using IEEE_ARITHMETIC
2026-03-25 12:32:58 -06:00
langou ac573b73bb Merge pull request #1187 from krystophny/fix/dgd-test-seed-fma-sensitivity
Fix DGS test seed to avoid FMA-sensitive ill-conditioned matrix
2026-03-25 12:24:30 -06:00
langou 92ca29dc64 Merge pull request #1212 from nakatamaho/fix/typo-fix-dmd 2026-03-25 04:11:13 -06:00
NAKATA Maho 33ec2a652c Fix typos in comment strings of [csdzd]chkdmd.f90
- intial/inital -> initial (K_traj loop and K_TRAJ==2 branch)
- eigencalues -> eigenvalues (GEDMD and GEDMDQ comment blocks)
- Rezidual -> Residual (WRITE output strings)
- rayleigh -> Rayleigh (proper noun, z/s/dchkdmd.f90)
- aigenvectors -> eigenvectors (s/dchkdmd.f90)
- localy -> locally (s/dchkdmd.f90 MKL note)
- whith -> with (s/dchkdmd.f90 MKL note)
- worksapce -> workspace (s/dchkdmd.f90 MKL note)
- ZGEDMDQ -> CGEDMDQ in comment blocks (cchkdmd.f90)
- ZGEDMD and ZGEDMDQ -> CGEDMD and CGEDMDQ in WRITE string (cchkdmd.f90)
2026-03-25 13:50:09 +09:00
langou 3aba0da0db Merge pull request #1211 from nakatamaho/fix/testparams 2026-03-24 20:55:26 -06:00
langou a4641a28a5 Merge pull request #1169 from sh-zheng/skew-symmetric-presubmit 2026-03-24 20:53:50 -06:00
NAKATA Maho ca938b93df Enable disabled test options in LAPACK TESTING input files
Turn on test options that were left disabled in several TESTING input files.

Set "Put T to test the driver routines" to T in cgg.in, dgg.in, sgg.in,
and zgg.in so the generalized nonsymmetric eigenvalue driver tests are run.

Also set "Put T to test the error exits" to T in cbb.in, dbb.in, sbb.in,
and zbb.in to restore the corresponding error-exit checks.
2026-03-25 10:34:36 +09:00
NAKATA Maho 4486765327 Enable disabled test options in LAPACK TESTING input files
Turn on test options that were left disabled in several TESTING input files.

Set "Put T to test the driver routines" to T in cgg.in, dgg.in, sgg.in,
and zgg.in so the generalized nonsymmetric eigenvalue driver tests are run.

Also set "Put T to test the error exits" to T in cbb.in, dbb.in, sbb.in,
and zbb.in to restore the corresponding error-exit checks.
2026-03-25 10:24:35 +09:00
langou 2f098d0fbe Merge pull request #1195 from jberg5/fix-f32-issue
Fix truncating large workspace values
2026-03-24 19:16:02 -06:00
langou dd3608ade7 Merge pull request #1208 from Reference-LAPACK/zrot_and_srot__NaN_checks_on_input_scalar
add NaN check for input scalars `s` and `c` to lapacke_crot and lapacke_srot
2026-03-24 19:15:36 -06:00
langou 7a5f0f890f Merge pull request #1209 from Reference-LAPACK/minor___zunbdb3
remove unused parameter ONE
2026-03-24 19:15:19 -06:00
Mark Gates 0dddb40aaf fix indentation 2026-03-24 20:43:58 -04:00
langou 93f72dd1f7 Merge branch 'master' into fix-f32-issue 2026-03-24 15:08:51 -06:00
langou c806564313 Merge pull request #1136 from langou/try__fix_1128__adding_part_of_angsch_suggestion
add NaN checks for input matrix A in GEEV, return error if NaN are in matrix A, NaNs in input are detected with LANGE (needed for scaling)
2026-03-24 14:40:09 -06:00
Julien Langou 7f4dff6336 oops 2026-03-24 14:35:02 -06:00
Julien Langou 8b52b5e82f remove unused parameter ONE 2026-03-24 14:27:06 -06:00
Julien Langou 8fa1db366b add NaN check for input scalars s and c to lapacke_crot and lapacke_srot 2026-03-24 14:18:29 -06:00
langou 10d120966e Merge pull request #1192 from kevinsung/zrot
add crot and zrot to LAPACKE
2026-03-24 14:13:46 -06:00
langou b760323bc5 Merge pull request #1196 from ilayn/fix_zunbdb3
FIX: Revert the conjugation removal in zunbdb3
2026-03-24 13:54:04 -06:00
langou eb5f719947 Merge pull request #1206 from nakatamaho/fix/trsyl3-ldswork-overwrite
Fix LDSWORK being overwritten during workspace query in xTRSYL3
2026-03-24 06:59:14 -06:00