Merge branch 'master' into minsurface-bugfix

bugfix accounting for new SetSubVector behavior
2025-09-17 03:33:24 -07:00 · 2025-06-27 08:35:03 -07:00
1 changed files with 6 additions and 12 deletions
@@ -179,12 +179,9 @@ private:

         dres_du->Mult(z, y);

-         auto d_y = y.HostReadWrite();
-         const auto d_x = x.HostRead();
-         for (int i = 0; i < minsurface->ess_tdofs.Size(); i++)
-         {
-            d_y[minsurface->ess_tdofs[i]] = d_x[minsurface->ess_tdofs[i]];
-         }
+         // Reuse z as a temporary vector to avoid unnecessary allocations.
+         x.GetSubVector(minsurface->ess_tdofs, z);
+         y.SetSubVector(minsurface->ess_tdofs, z);
      }

      // Pointer to the wrapped MinimalSurface operator
@@ -261,12 +258,9 @@ private:

         dres_du->Mult(z, y);

-         auto d_y = y.HostReadWrite();
-         const auto d_x = x.HostRead();
-         for (int i = 0; i < minsurface->ess_tdofs.Size(); i++)
-         {
-            d_y[minsurface->ess_tdofs[i]] = d_x[minsurface->ess_tdofs[i]];
-         }
+         // Reuse z as a temporary vector to avoid unnecessary allocations.
+         x.GetSubVector(minsurface->ess_tdofs, z);
+         y.SetSubVector(minsurface->ess_tdofs, z);
      }

      const MinimalSurface *minsurface = nullptr;
Author	SHA1	Message	Date
Tzanio Kolev	e70dc4f4ca	Merge branch 'master' into minsurface-bugfix	2025-09-17 03:33:24 -07:00
Julian Andrej	f5cb982b59	bugfix accounting for new SetSubVector behavior	2025-06-27 08:35:03 -07:00