phynexis-deps/openmp
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Bug fix for Bugzilla bug 26602: Remove function bodies with KMP_ASSERT(0)

Browse Source 
Fix for bugzilla https://llvm.org/bugs/show_bug.cgi?id=26602.  Removed functions
body consisted of the only KMP_ASSERT(0) statement.  Thus possible runtime crash
converted to compile-time error, which looks preferable (faster possible error
detection).

TODO: consider C++11 static assert as an alternative, that could
make the diagnostics better.

Patch by Andrey Churbanov

Differential Revision: http://reviews.llvm.org/D21304


git-svn-id: https://llvm.org/svn/llvm-project/openmp/trunk@272590 91177308-0d34-0410-b5e6-96231b3b80d8
This commit is contained in:
Jonathan Peyton
2016-06-13 21:33:30 +00:00
parent 146e0c7b5f
commit f7dc7b1746
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
runtime/src/kmp_dispatch.cpp
+4 -4
View File
@@ -190,7 +190,7 @@ struct dispatch_shared_info_template {
// test_then_add template (general template should NOT be used)
template< typename T >
static __forceinline T
test_then_add( volatile T *p, T d ) { KMP_ASSERT(0); };
test_then_add( volatile T *p, T d );
template<>
__forceinline kmp_int32
@@ -213,7 +213,7 @@ test_then_add< kmp_int64 >( volatile kmp_int64 *p, kmp_int64 d )
// test_then_inc_acq template (general template should NOT be used)
template< typename T >
static __forceinline T
test_then_inc_acq( volatile T *p ) { KMP_ASSERT(0); };
test_then_inc_acq( volatile T *p );
template<>
__forceinline kmp_int32
@@ -236,7 +236,7 @@ test_then_inc_acq< kmp_int64 >( volatile kmp_int64 *p )
// test_then_inc template (general template should NOT be used)
template< typename T >
static __forceinline T
test_then_inc( volatile T *p ) { KMP_ASSERT(0); };
test_then_inc( volatile T *p );
template<>
__forceinline kmp_int32
@@ -259,7 +259,7 @@ test_then_inc< kmp_int64 >( volatile kmp_int64 *p )
// compare_and_swap template (general template should NOT be used)
template< typename T >
static __forceinline kmp_int32
compare_and_swap( volatile T *p, T c, T s ) { KMP_ASSERT(0); };
compare_and_swap( volatile T *p, T c, T s );
template<>
__forceinline kmp_int32